Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <75dfee2a-4b2f-49dd-a1c7-1cc3a9d8dad3@amd.com>
Date:   Sun, 5 Nov 2023 21:19:42 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: drivers/vdpa/pds/debugfs.c:269:49: warning: '%02d' directive
 output may be truncated writing between 2 and 11 bytes into a region of size
 6
To:     "Michael S. Tsirkin" <mst@redhat.com>,
        kernel test robot <lkp@intel.com>
Cc:     oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org
References: <202311040109.RfgJoE7L-lkp@intel.com>
 <20231105075350-mutt-send-email-mst@kernel.org>
Content-Language: en-US
From:   "Nelson, Shannon" <shannon.nelson@amd.com>
In-Reply-To: <20231105075350-mutt-send-email-mst@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RlZCZ3B4d0taVW1KQ0xSQy9DVEVGd3dNOEttLzh1enROWGZvRExYNnZmSG1D?=
 =?utf-8?B?ckROMTl0WEJKSGx3YlZ1SHN4RXhnMTBGZWtIY0t3TVZRcVpNNjlRUHNxTnZM?=
 =?utf-8?B?R2U0VTRqY2VRRUY1MXhnVjJydTYxamp6N0JDdzB0MFFkSEVaeVhRYWRVMnBP?=
 =?utf-8?B?eEhGczNlR25NSk9MZW93OGZ3NEpPbTF0dEU0N3ZGQnhrU3ZCNXNtcEF6MThQ?=
 =?utf-8?B?bHpLUk9XeE54djV0RW1GZ2t0TVBGYjVWcVB6VCtGUlBwN1RiNGo5UWpOSTQv?=
 =?utf-8?B?bm1aa3FGMWtaTzg3a0tvRnlheE5sQ0Zvd1M4WmlXL3M4dzUxMUMxbzBIdWpZ?=
 =?utf-8?B?WkdOWFhqWU1BN1VOL2lta1lWTXg4QmZTeGkzSG9Bd1lqd0pXQkZRZ01zVDNS?=
 =?utf-8?B?dHN4ZkF0YkRPbW1nc1BBVFVhcWF6cWpYR1IwbHExT1c3MmppSlV6NlgrZUhy?=
 =?utf-8?B?VUFPS09zcFM4ckFmN1Q5NXZXUEdTcVlKZkk3ekRzRjkyOGRoZnRHVGU4ZlJD?=
 =?utf-8?B?WFBmT2o2UG4wWTNwWHh0UzNKdU8vZGV0ZlNlSnEyVWFhMXIzMGZ1bVlqNDhX?=
 =?utf-8?B?TVNoMHVsWXdBR29wYlJvSWxpNUtjT3BreWJFTHRsOWtjYzRzYjR1VTRpUjZo?=
 =?utf-8?B?VmtHWUN2N3hiTXRtS2UwT0RhU2FDL1BoNmFXbENqSmlVbUNnRmkrNDVITDh1?=
 =?utf-8?B?a1MwaWFiRlp2QlF3YVV1eXF1N1VKUG1aaFh2YjZONmc2TngrSFVCQ0daNTVN?=
 =?utf-8?B?K2wwdUpzOGpCckZzVjNCRmhrZkZxWnpRMkpZY2hGbXdTMVloOTV6TWNMalRS?=
 =?utf-8?B?QW5DaVQ1QzRXbUhJdFRLQUtYbGtnVG40NlhLMnlhdjF2M3VMUVg3b0dUR0tG?=
 =?utf-8?B?NnpOcmdvMWc0YnlzZm9XKzBKMUNPL0NzMUhKOFAwKzlzbFVRZlVvSzFXRWpH?=
 =?utf-8?B?VEZQblpYOEZSQ0xLMGY0cVd2YzBzSHMrakhsckdTcEVCVEJwZjdpdHR0MC81?=
 =?utf-8?B?WFVkZlBZdWFRSnBIMFdzZkRIZGVOOVErbjNSTnYxVk5UYWM3R0krV1BPSHIz?=
 =?utf-8?B?VEFrL09PMU4zTTVablRPa0JTNWFGL1NXZDFQb1gzTStuMGphdGdsMzNwd3A1?=
 =?utf-8?B?M0lNQ0U2R0hpN2VVM3J0cnZxaEVpRFRSM2lFWUxXZU84OENWRHFrbEE0RjVK?=
 =?utf-8?B?THJoUEJWa1Y1TGxVYkh5dElqMzQrRUpjVzNlQy9ocnBwdVBGZ2lJMnpSQmRo?=
 =?utf-8?B?R1E0aDN6TmlwK0k1N0ZxWmc5WVFaQy9QZWlhY3ZOSjhiQ0JEUHNkS2VVRlZT?=
 =?utf-8?B?akd2YkR3NHd6YnFoeThscTgvRzNuQWQ5STJDZDMyQ2JqK0wxcnU1MlFpc1Yx?=
 =?utf-8?B?dHJGaGp3SEFlSnZsTnBFdDIyQk9IemR2eGNFR1QwOFEySVZnNU9DRVpMMUdX?=
 =?utf-8?B?K21Zc1BpVmtwNGpKKzNVc2w5U0ptYUdkOTBHRUZESTFZOGY2dnhEYWpwelFS?=
 =?utf-8?B?eFpLUTRnT0RXQzVXVmh3QXgwTUFzOTZXN1hhNytNTjVDazNzblF6U21GYnZn?=
 =?utf-8?B?bkVVU1dJb3YvRS9WbkR0Q2pkdktvRHk4U01IcUpKM1F0Q1FvWHpDclVnSnU4?=
 =?utf-8?B?MElHTXpldUJLcUF2RUhBUXRDbFczRUdSU1pNZk5Hd0JKbzNvZlVCTWxNb1dY?=
 =?utf-8?B?aytESzB1YkVWbFRHVDVsMG41U09ZU0dZcGNvWlN3TWZhY1RoUFd2ZEtNbkF2?=
 =?utf-8?B?dytZMURNRGxoSUZaN3RkUXdkdUd0RlVDL0NlNCtzOXMzaURaa2EyQ2tJSTd6?=
 =?utf-8?B?dmVmMFA5eEhBTlhLSnh1V0pGVmRpSjhMbVg2dXE0QndnMFFBM0VyNVpXWStm?=
 =?utf-8?B?eWJXcmw1eUhlWVRWcnNzQ1dJdlBzOGF0VG51SGpCSkZiYjAzYnFEZEFpVG4r?=
 =?utf-8?B?RDU2NjVUSEd2R0FiUXc1Ni9WbHQvT1lkbHJmbDJpbTNRb0NPM1E3ZVhwT24v?=
 =?utf-8?B?bUtiQXJBbTlqdHJZK1BjSVVuYkxRSTZuWTRnaU9SMk9VRUxYN1ZETkN1KzRL?=
 =?utf-8?B?bWRNc3AvRVkxeTFnbmw5YldiNFMwdHhzRWVZTFlUeU9pMlVxWmhxRTl6dnp6?=
 =?utf-8?Q?Evxy5904YJDrcH9IZNdDuxR6+?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b42d1d15-3283-4582-abce-08dbde87fcdf
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6583.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2023 05:19:44.9234
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Kv20L/+uS4wt7HX81yaz205Sm24zi2x3l5gOoFV3tYlq09qaLYFSxXD45XPlYLe+niGS4BRIc/BeywzVDrqY4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6521
X-Spam-Status: No, score=-1.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Sun, 05 Nov 2023 21:20:47 -0800 (PST)

On 11/5/2023 4:57 AM, Michael S. Tsirkin wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> On Sat, Nov 04, 2023 at 01:36:05AM +0800, kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head:   8f6f76a6a29f36d2f3e4510d0bde5046672f6924
>> commit: 9a8864d2a8dc5c49acd66284fd382871d99b5db8 pds_vdpa: pds_vdps.rst and Kconfig
>> date:   4 months ago
>> config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231104/202311040109.RfgJoE7L-lkp@intel.com/config)
>> compiler: alpha-linux-gcc (GCC) 13.2.0
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231104/202311040109.RfgJoE7L-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202311040109.RfgJoE7L-lkp@intel.com/
>>
>> All warnings (new ones prefixed by >>):
>>
>>     drivers/vdpa/pds/debugfs.c: In function 'pds_vdpa_debugfs_add_vdpadev':
>>>> drivers/vdpa/pds/debugfs.c:269:49: warning: '%02d' directive output may be truncated writing between 2 and 11 bytes into a region of size 6 [-Wformat-truncation=]
>>       269 |                 snprintf(name, sizeof(name), "vq%02d", i);
>>           |                                                 ^~~~
>>     drivers/vdpa/pds/debugfs.c:269:46: note: directive argument in the range [-2147483641, 254]
>>       269 |                 snprintf(name, sizeof(name), "vq%02d", i);
>>           |                                              ^~~~~~~~
>>     drivers/vdpa/pds/debugfs.c:269:17: note: 'snprintf' output between 5 and 14 bytes into a destination of size 8
>>       269 |                 snprintf(name, sizeof(name), "vq%02d", i);
>>           |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>>
>> vim +269 drivers/vdpa/pds/debugfs.c
> 
>> 151cc834f3ddafe Shannon Nelson 2023-05-19  259
>> 151cc834f3ddafe Shannon Nelson 2023-05-19  260  void pds_vdpa_debugfs_add_vdpadev(struct pds_vdpa_aux *vdpa_aux)
>> 151cc834f3ddafe Shannon Nelson 2023-05-19  261  {
>> 151cc834f3ddafe Shannon Nelson 2023-05-19  262        int i;
>> 151cc834f3ddafe Shannon Nelson 2023-05-19  263
>> 151cc834f3ddafe Shannon Nelson 2023-05-19  264        debugfs_create_file("config", 0400, vdpa_aux->dentry, vdpa_aux->pdsv, &config_fops);
>> 151cc834f3ddafe Shannon Nelson 2023-05-19  265
>> 151cc834f3ddafe Shannon Nelson 2023-05-19  266        for (i = 0; i < vdpa_aux->pdsv->num_vqs; i++) {
>> 151cc834f3ddafe Shannon Nelson 2023-05-19  267                char name[8];
>> 151cc834f3ddafe Shannon Nelson 2023-05-19  268
>> 151cc834f3ddafe Shannon Nelson 2023-05-19 @269                snprintf(name, sizeof(name), "vq%02d", i);
>> 151cc834f3ddafe Shannon Nelson 2023-05-19  270                debugfs_create_file(name, 0400, vdpa_aux->dentry,
>> 151cc834f3ddafe Shannon Nelson 2023-05-19  271                                    &vdpa_aux->pdsv->vqs[i], &vq_fops);
>> 151cc834f3ddafe Shannon Nelson 2023-05-19  272        }
>> 151cc834f3ddafe Shannon Nelson 2023-05-19  273  }
>> 151cc834f3ddafe Shannon Nelson 2023-05-19  274
> 
> 
> So gcc can't figure out that i is positive in this loop :(
> 
> Let's make it unsigned I guess? Should calm it down.
> 
> Shannon could you send a patch please?

Yes, I've been a little snowed under the last couple of weeks, but will 
try to get to this and a couple other similar complaints in the next 
week or so.

sln


> 
>>
>> :::::: The code at line 269 was first introduced by commit
>> :::::: 151cc834f3ddafec869269fe48036460d920d08a pds_vdpa: add support for vdpa and vdpamgmt interfaces
>>
>> :::::: TO: Shannon Nelson <shannon.nelson@amd.com>
>> :::::: CC: Michael S. Tsirkin <mst@redhat.com>
>>
>> --
>> 0-DAY CI Kernel Test Service
>> https://github.com/intel/lkp-tests/wiki
>