Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp1934544rdf; Sun, 5 Nov 2023 22:17:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IEGbdO+TL9hTSdJEdrjd4j/zODL+sHj2fiJcoHWrzPS9MBF3DEvVr2wbuPEN0FuDkvIj6N3 X-Received: by 2002:a05:6808:10c4:b0:3b2:9d31:9d25 with SMTP id s4-20020a05680810c400b003b29d319d25mr36569123ois.31.1699251451561; Sun, 05 Nov 2023 22:17:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699251451; cv=none; d=google.com; s=arc-20160816; b=nLff9Icdsfr5cjydR0iZGSMQ5FnJqdHAYlLx1mYv+0cPaIUk/wm6qAjRcPPsQD+4Cm Tx6fgHPN3ZKAZ3G6ryBQ/1GAvLeT9rX1WGQWKT3RrjH+x7rVSM8zO/JRDumAHInUqlFj 0Kd5tFEGvOccLkTTUmKxPlWflvqfIzzDWm7p9CdlaBHFQ+mzQo/1pzKJaikW9LP2ibVE Z88BkV1Pq4+OYwMdQi1BjyNCJgVTcvwAZqWx6RX9aLu4z68cQijgkSZmGqxWlgSEOdIT issvEdusJPETIRV5pTH43tqVXhKpCieCQShsdh/6g4w3EhfdYM7uNvlafXalAeOjbCg7 0nZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :feedback-id:references:in-reply-to:message-id:subject:cc:from:to :date:dkim-signature; bh=I/NADm3y4JRhxPmSbj3v0umXGT2ZrmOBF5vX4lVtFkA=; fh=U8U8DhF7/A+1vVtl0JkPS6xMd2rGMx1r7xF+KOGaMUM=; b=E30H8WMg8DCQPzb2VbQj5h9l+Ql6G6UtcUbeoFePxsPfAHxkiju3p91Ih2vdVR6kOo CxohuGS3DAQYS8mv+lzBt31OBvm3ga4p4TACczNUC/isfRHolqfvYzHi6lH6N9A3Tnne 0qXqUomwdcDQkbwzVjz6Rf6aJhy1+Iu1ZaPVAsPiBJnoJgYjccTOuk5KnHcFnzxk6mcA e7S6tIPhFTBjUdt0YNRldD2gS419N8yMCjLILNwfQwCaQopMmXCZl1BzdHwYqLHlXPcs c9hD3OI0ljwrCdiO9tYdZ8PGbvICMRCJpsJxLhpIeh8t0mNRjRIIr/v0NQRgTsvio+DX eruQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail3 header.b=N1zInv7T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id fc41-20020a056a002e2900b006b864485166si7542231pfb.146.2023.11.05.22.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Nov 2023 22:17:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail3 header.b=N1zInv7T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 00DB0809B76A; Sun, 5 Nov 2023 22:17:29 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230406AbjKFGRQ (ORCPT + 99 others); Mon, 6 Nov 2023 01:17:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230319AbjKFGRP (ORCPT ); Mon, 6 Nov 2023 01:17:15 -0500 Received: from mail-0301.mail-europe.com (mail-0301.mail-europe.com [188.165.51.139]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C45E0B6; Sun, 5 Nov 2023 22:17:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1699251428; x=1699510628; bh=I/NADm3y4JRhxPmSbj3v0umXGT2ZrmOBF5vX4lVtFkA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=N1zInv7T/pcD6sBuNdVTKrruTrhFcEE2FbHE/yjdtzonYQm0fLTwS2vvsgvvRSj4x vdG7v/grIykNsjEbEoLgA1vCwsmqKLMRNWci2d/GVpHvXHybExbICVHxwRMB7rFjy6 fB5+DjF6NB+pjiDkhmStITYfKRUftKht+mLjsTKxQJTrVM3QjsxMVFy9JKdTmS9KyY s4E0yStEKblp8Zr61j5IqRymQz8d8HQnYTdnOO6yh9WLPZSmuhH7MDsr0jGgrqQ57U vQNqd9k8tLeNAhhG7kctPi61o9Y/mHJw2ODxOW5aCnn9APIGV9kCYwThiFMqvJLyfy N4LNPURNHqIZQ== Date: Mon, 06 Nov 2023 06:16:59 +0000 To: Su Hui From: Rahul Rameshbabu Cc: ping.cheng@wacom.com, jason.gerecke@wacom.com, jikos@kernel.org, benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2] HID: wacom_sys: add error code check in wacom_feature_mapping Message-ID: <87pm0nz9rc.fsf@protonmail.com> In-Reply-To: <20231106060815.104971-1-suhui@nfschina.com> References: <20231106060815.104971-1-suhui@nfschina.com> Feedback-ID: 26003777:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 05 Nov 2023 22:17:29 -0800 (PST) On Mon, 06 Nov, 2023 14:08:16 +0800 "Su Hui" wrote: > hid_report_raw_event() can return error code like '-ENOMEM' if > failed, so check 'ret' to make sure all things work fine. > > Signed-off-by: Su Hui > --- > v2: > - report the returned error (Rahul Rameshbabu) and __func__. Thanks for the patch. Like the addition of using __func__. Reviewed-by: Rahul Rameshbabu