Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   Ashwin Dayanand Kamat <kashwindayan@vmware.com>
To:     linux-kernel@vger.kernel.org
Cc:     kashwindayan@vmware.com, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
        hpa@zytor.com, thomas.lendacky@amd.com, jroedel@suse.de,
        brijesh.singh@amd.com, ganb@vmware.com, tkundu@vmware.com,
        vsirnapalli@vmware.com, akaher@vmware.com, amakhalov@vmware.com
Subject: [PATCH] x86/sev: Update ghcb_version only once
Date:   Mon,  6 Nov 2023 12:02:41 +0530
Message-Id: <1699252361-1286-1-git-send-email-kashwindayan@vmware.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BzOxQo6sgK9LNSwXkJl/LU7AlvCeRfCsgwtI1aseyQGFWSd52w/sWQJiIR+N?=
 =?us-ascii?Q?2idYulJbvcosus9nBQRlyRBHUiURy4EBfllp/HHD0/6ZfMEA+z1MA/r6tZKx?=
 =?us-ascii?Q?Gzl9OkktMmZSyb765IE6abIGc0kJQh2s9wsA5Dq5qM/cBYK75oZMYngKTj7U?=
 =?us-ascii?Q?Wu0aLSYn6ZGmMgeZmZScjkq03RSZIMOEYyP+8vi+OXosQRQrhSPRHzV3esRr?=
 =?us-ascii?Q?sIumi+EZo6ceGt0ZaW3ulDunIFK2y4flVFFr8ioBNNMC5YkfKFVtLyZ641Th?=
 =?us-ascii?Q?1VGBwk+swjNJH1PTuyiFp7gIXhkV/kqig3OKR7MTovqKWFLdgEawqmoh0hOV?=
 =?us-ascii?Q?hLjh0UmFw5dBBB06lCI85OomwjNP50aq61CfBfAdPjIUWB/2UAGdzfzlXA+q?=
 =?us-ascii?Q?KgKiURZP+eho7RRqobkchjg1QoYgFBbBivBA7ILxaeKziQMgY1bUrmec2u2l?=
 =?us-ascii?Q?IzyP/F/XO6bbT2W2/m6mXAPjcQi/ZfaI5wmJS3L7a7Tan7ny7SJFJqoeKLIu?=
 =?us-ascii?Q?m6vUnqShGx2Q6AQBnmxVCs17B2h4zh2399qCttok8LQhQUbI6Z53iNpCPPoR?=
 =?us-ascii?Q?bnPMcQuGoPaSZkfVCCo0ws2km18+ndhwWI0fc61UFg1Kkvir6Ly2KiG7rYAp?=
 =?us-ascii?Q?wbjqqfcuZPuCf129+yHt1FeG7nxXSREEg5vTMppB/ofo1P4nmkpsHPkwaW6E?=
 =?us-ascii?Q?zgiSEuP2kpKeZESUif8i9CWP/7uS4VCRZtHIneE3+swOEJRUgjXyA88FcnDw?=
 =?us-ascii?Q?xAuZkswDH1k+puThXje6drVXBXICh5iyZCzPij/QvnMtBAUHrRjF2xYNyMx7?=
 =?us-ascii?Q?pKk7fMJUpEfqwIlBIwyR2m0Bq9ja7pV3SDlhZ9vsxtAALLy5DRYs/1caBv2W?=
 =?us-ascii?Q?5GyNV7AOrZL1uHw0VElGde9++c0M45XYiZUTfbM9CZrJjskngHTcZzcUGyjC?=
 =?us-ascii?Q?MMEVFU7zqvohSWoz8Zuxv5YIm3fzaOqySSniSYXsFDTt2VNf6y/Cz167JOjd?=
 =?us-ascii?Q?tPQwyT/t6+151SNTW/f7Ffr2aL7COUA2NqOIVB9nffDM172x1Nw+0svTXI94?=
 =?us-ascii?Q?MAlHWDu3vxCAXC2WKI3FFvUFbN5bb77m8eB6TzVzy07oD/UowAossQmpXbvP?=
 =?us-ascii?Q?6it1n5UbeEsN4I+TTsslgeb6AxcLySg38VrQlr0kcCdMS2DIhmlcazZKqo0F?=
 =?us-ascii?Q?yKdnBThhbZvJTudjxiW6JNgG2+YTmr1IdAgNNObn3aZ2dbMDLxjU1BI3oVvb?=
 =?us-ascii?Q?1nAvwET7rq8FZ5VkAREV4JRG2cQtvzcVBFxE0zD39SRWO6qnrCIBYz5G26xm?=
 =?us-ascii?Q?Sm6jdZDu1LpF3W7jOfI3O36e9mN6l1ViWDzYIg1wnYdLBCt4kp8xVV2cJKr3?=
 =?us-ascii?Q?kVHqUpbSUtXqqN4/euQFq+ashKABsQKfQTbZZGrt9EzrQPaTyJbIg3/kNU5r?=
 =?us-ascii?Q?ZgRLpDYBDIy9hgIDWm3GeRF5bKqUPqcBqWeugfMPigW3NFtUuQ913pTvaO6k?=
 =?us-ascii?Q?agT0QEXoPNTquw/j2DlcBaGddHjMoFBYokUC773aJ/KmToC9LR9DC8ZWViS0?=
 =?us-ascii?Q?xlArWavqHXvnWc+hudjaztwbdf89rbLWR0zD/3oT?=
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1de87c79-67f3-43ac-5d2c-08dbde9232b9
X-MS-Exchange-CrossTenant-AuthSource: BL0PR05MB5409.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2023 06:32:50.2436
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jO4SHBP1Ro1Uw6FrM89Db+zt4GFM0iXgMAw7+HwWMxsAwZq+ZnWGmNyS9Gkh30LGi3Wktlkv4N54vH1b960mng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR05MB9359
X-Spam-Status: No, score=-1.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 05 Nov 2023 22:33:10 -0800 (PST)

kernel crash was observed because of page fault, while running
cpuhotplug ltp testcases on SEV-ES enabled systems. The crash was
observed during hotplug after the CPU was offlined and the process
was migrated to different cpu. setup_ghcb() is called again which
tries to update ghcb_version in sev_es_negotiate_protocol(). Ideally this
is a read_only variable which is initialised during booting.
This results in pagefault.

From logs,
[  256.447466] BUG: unable to handle page fault for address: ffffffffba556e70
[  256.447476] #PF: supervisor write access in kernel mode
[  256.447478] #PF: error_code(0x0003) - permissions violation
[  256.447479] PGD 8000667c0f067 P4D 8000667c0f067 PUD 8000667c10063 PMD 80080006674001e1
[  256.447483] Oops: 0003 [#1] PREEMPT SMP NOPTI
[  256.447487] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 6.1.45-8.ph5 #1-photon
.
.
.
.
.
[  256.447511] CR2: ffffffffba556e70 CR3: 0008000667c0a004 CR4: 0000000000770ee0
[  256.447514] PKRU: 55555554
[  256.447515] Call Trace:
[  256.447516]  <TASK>
[  256.447519]  ? __die_body.cold+0x1a/0x1f
[  256.447526]  ? __die+0x2a/0x35
[  256.447528]  ? page_fault_oops+0x10c/0x270
[  256.447531]  ? setup_ghcb+0x71/0x100
[  256.447533]  ? __x86_return_thunk+0x5/0x6
[  256.447537]  ? search_exception_tables+0x60/0x70
[  256.447541]  ? __x86_return_thunk+0x5/0x6
[  256.447543]  ? fixup_exception+0x27/0x320
[  256.447546]  ? kernelmode_fixup_or_oops+0xa2/0x120
[  256.447549]  ? __bad_area_nosemaphore+0x16a/0x1b0
[  256.447551]  ? kernel_exc_vmm_communication+0x60/0xb0
[  256.447556]  ? bad_area_nosemaphore+0x16/0x20
[  256.447558]  ? do_kern_addr_fault+0x7a/0x90
[  256.447560]  ? exc_page_fault+0xbd/0x160
[  256.447563]  ? asm_exc_page_fault+0x27/0x30
[  256.447570]  ? setup_ghcb+0x71/0x100
[  256.447572]  ? setup_ghcb+0xe/0x100
[  256.447574]  cpu_init_exception_handling+0x1b9/0x1f0

Fix is to avoid updating the variable after it has been initialised during booting.

Fixes: 95d33bfaa3e1 ("x86/sev: Register GHCB memory when SEV-SNP is active")
Signed-off-by: Ashwin Dayanand Kamat <kashwindayan@vmware.com>
Co-developed-by: Bo Gan <ganb@vmware.com>
---
 arch/x86/kernel/sev-shared.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/x86/kernel/sev-shared.c b/arch/x86/kernel/sev-shared.c
index ccb0915e84e1..a447908f2b4d 100644
--- a/arch/x86/kernel/sev-shared.c
+++ b/arch/x86/kernel/sev-shared.c
@@ -144,6 +144,9 @@ static bool sev_es_negotiate_protocol(void)
 {
 	u64 val;
 
+	if (ghcb_version)
+		return true;
+
 	/* Do the GHCB protocol version negotiation */
 	sev_es_wr_ghcb_msr(GHCB_MSR_SEV_INFO_REQ);
 	VMGEXIT();
-- 
2.39.0