Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Adrian Hunter <adrian.hunter@intel.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        =?iso-8859-2?Q?Kornel_Dul=EAba?= <korneld@chromium.org>,
        Radoslaw Biernacki <biernacki@google.com>,
        Gwendal Grignou <gwendal@chromium.org>,
        Asutosh Das <quic_asutoshd@quicinc.com>
CC:     Chaotian Jing <chaotian.jing@mediatek.com>,
        Bhavya Kapoor <b-kapoor@ti.com>,
        Kamal Dasu <kamal.dasu@broadcom.com>,
        Al Cooper <alcooperx@gmail.com>,
        Haibo Chen <haibo.chen@nxp.com>,
        Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>,
        Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>,
        Victor Shih <victor.shih@genesyslogic.com.tw>,
        Ben Chuang <ben.chuang@genesyslogic.com.tw>,
        Thierry Reding <thierry.reding@gmail.com>,
        Aniruddha Tvs Rao <anrao@nvidia.com>,
        Chun-Hung Wu <chun-hung.wu@mediatek.com>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V2 4/6] mmc: block: Retry commands in CQE error recovery
Thread-Topic: [PATCH V2 4/6] mmc: block: Retry commands in CQE error recovery
Thread-Index: AQHaDjLaTo9YqQ/5n0yX0FBiNZ7vjbBs66XQ
Date:   Mon, 6 Nov 2023 07:37:33 +0000
Message-ID: <DM6PR04MB6575383D23F5FC567D4A69CCFCAAA@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20231103084720.6886-1-adrian.hunter@intel.com>
 <20231103084720.6886-5-adrian.hunter@intel.com>
In-Reply-To: <20231103084720.6886-5-adrian.hunter@intel.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-2?Q?DEXakv15ei6l6eD0EmEkqAXP4f7ICeYYxv4KY3pKN/YM8jWOsuY7UTTaED?=
 =?iso-8859-2?Q?d/8qB+WROPHOUpMwBt/AVLOK1GYwWqbvLZ851jsSW258r+e4TWzx5uSv98?=
 =?iso-8859-2?Q?u50oF0bqObOb4yU/2vd92UK7u06FKPdsJHDHBV3w/uhdlmeRIY1M8LyD4k?=
 =?iso-8859-2?Q?Oa6nzHJejzF/QjWtUUrklux2LcyvEeDeX3zKsA2N+A4o1blIk/xydjC3pa?=
 =?iso-8859-2?Q?DTsjNX2UtnFfqFnlQJH8tf5EAyWsLaB59JiM9YJGKbjlAXlFFLTZ/FpYh+?=
 =?iso-8859-2?Q?n4RhWLFv+uTcqsyJRu1GtINgLW/D4qSqCirZV7pscKlG1bQoD8iF1Wtk3b?=
 =?iso-8859-2?Q?kEJUSWOchB48l+4zTr+oS3Odbe+Wcz4bXIcr/JfEerMjQlo3xz5YbQ6+SD?=
 =?iso-8859-2?Q?gpRAoq+Q5c8IIocpllXtSxRCVedgP3J83LZ4R+fVyFsVgnXC/iT2SkrOyb?=
 =?iso-8859-2?Q?z5FFzC3Re5kvO0l/LBaN9JHApNkyDYTon1/HfwGU58K+PdJ1sfadGqKpDI?=
 =?iso-8859-2?Q?O3vjqFfmzZstg1yKECgjsRMdlyZ1H3ph/8g0V8ltzbHi5LZ0QCIXS2aU8W?=
 =?iso-8859-2?Q?TsCS3BdNfC6NsBltTCO78dNyvlLrPkunEAuqH4gQyrNqJ46RZsWXHyDRrV?=
 =?iso-8859-2?Q?ldYyImDExaFnn96NHRmFioVWifGNrE3pYMptNACbUqa4xPIzHbrTA/+sVA?=
 =?iso-8859-2?Q?n1n7XCSRayNOaRmSc+bFKANXElFBqQBFnUUEbNRzDJ+ctFPBfmpKlVlYHU?=
 =?iso-8859-2?Q?F9dJfu3mJW8M2EaOT5VRh7z9aKda8Ifjqzla53f7XUJ9uFVwhr+a+z12jV?=
 =?iso-8859-2?Q?VraCwXn44m3P9kUHe2FdVgLw326ji25CfFNm6XFAWAEqDC//ARw7nRDl9g?=
 =?iso-8859-2?Q?z/SigRX3YNZuhAlzPl/4uc1hAUmIYwNkcxnVZdKsfKuXbrJlbKuqQ+yGrC?=
 =?iso-8859-2?Q?D1uAXDsEvJBeMu7chhcOkKr2/lf9H/J+mCiXQXqgia8hf8qNjl6mgvSwww?=
 =?iso-8859-2?Q?kGRznAPITEQoAuZnSvTy3LKAMbdtJVt04KZrlg7xj6d4iyyQANaqt2PBE+?=
 =?iso-8859-2?Q?LPGizNxiunWL5aBxzr1ll8kQCEsLHaBvmFXaZj6p3UiHwcZCebKHg1c3Ih?=
 =?iso-8859-2?Q?K1zXKYRLUrsG9La1Ldb2k7k6AQuSiHtBFV1FNcujLtyhNav6cwQvAqvV5+?=
 =?iso-8859-2?Q?HUJmoTr0kpzBJO0LwbGWI2/cCc2gAkjk9VhoOf31KPiSn1grCQOwK70Oyf?=
 =?iso-8859-2?Q?UW03n67hvq2j559ATmLerkK77EwQa1OSwl60IIEjvH9jF7mMmzqk30NS/I?=
 =?iso-8859-2?Q?XjLLuhQeuTrgq5uCJbtjaAaZqpQNLouTez6m4d6KEiyMKbm694jIZOq6g2?=
 =?iso-8859-2?Q?lfl2b4Tc4xDw+AbuWx/NMQvBElitpyIWy2Vf1aX3MasUxNpJyzLwGbb+KO?=
 =?iso-8859-2?Q?nEbX9txcCZidPKXhZDss1FU9/+dhYXzOX5Ftk0bH21OoudoehJkGTHQvf6?=
 =?iso-8859-2?Q?7mSw7wIlHubuE16Fcm+ZlisGVYu3p6srzzeSoGVwiCnccoMoe5sO1n+cYK?=
 =?iso-8859-2?Q?L21ryjWgQiBZRHHdVY6J4TSdzzJ6i68VfwtY1hazwmPpDfaSj0N2VA+O75?=
 =?iso-8859-2?Q?KWLndHZB3lo3Kq7ofk6vI8ATIwg5bGZjrC?=
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?iso-8859-2?Q?pO5brDUL+Mk2f4fXfve8fGPDRPg8fT1hiVUejWsUfMGjeFbbDJvZRDP72B?=
 =?iso-8859-2?Q?9P6BlxzSsoh20vFooeDyy0wqTNNDGG/B/JH4ivW4TLTRJJb7jBYCdffCvw?=
 =?iso-8859-2?Q?pGQRwNBOVBN/olGRuDZD3GeaKuN3+gS0B5mxORZkrtV3n9GHLGI2BfYytq?=
 =?iso-8859-2?Q?xb7easAVClpJ//6P/5U7XuashpmmBgat2GACFhfZygaczFDb2tKpFTSiBr?=
 =?iso-8859-2?Q?Prw3sSQEmr63Y0AbBqUF6GPkolaWOeewrygoh7B+Qb+CnyNcXjooaXkXeA?=
 =?iso-8859-2?Q?Wb8wZ3lnqGW/Ga/6EqXfuxF2pIcYnDaUPj6kSx3vuN/xJOtpdOzb0Nx2td?=
 =?iso-8859-2?Q?0G1eW0eNRuZfJGGBygRUD3Vf1FPawoxw7hletZJbtNfwDYTJhdsSpwEghc?=
 =?iso-8859-2?Q?vgLG0wTmFgyJxS5o6vdcVOVBMmmpXqp4hYFwcwCJbbIYg4MPfDnyexHXTr?=
 =?iso-8859-2?Q?6WXKtGJNTX8uYlQrTger+v19yhy9aYDV6vuIrTsc5qBK10Ldw2XnJ3ahLx?=
 =?iso-8859-2?Q?dNJFfJx1nB23j/N0P7I2qhDq9/l6GDbnlaxkKPwghufKDjRvhwocY+near?=
 =?iso-8859-2?Q?NBnJ8ihrE+UqkYKBW/ri+DAcApD1Rd/bJK89IpOvlNl9eOFKUr6dcPlezr?=
 =?iso-8859-2?Q?mT5J2mh5TEtvfaeP7RPgqkxLKRU6R0rd4slFfBRCIhkghaGJY5/sKibbNb?=
 =?iso-8859-2?Q?uZz/AYCaMgva2RKD1kZYUvKgCgB8LCjzg9kows+Fno4EDTx3HVQye1GuiW?=
 =?iso-8859-2?Q?GVejEKXHcXyK5TuhrRaXsD5E9EJQf3hHZAAhZwMmHssOIBSHrvlCbtFGD7?=
 =?iso-8859-2?Q?2aWfCZWMVDGxIuGPHMZJQ9DOBdi5CwPzh2etDwPL7aTT6lEWd9Pt6p0oLg?=
 =?iso-8859-2?Q?KpJrYSt9sZjMoAEH+clEpb9WALpaqGP7Y3dwSfAUtoRUnKUAK2dZi4SH44?=
 =?iso-8859-2?Q?cyRmHXjem0GoqAW1KoQ+7EKodM98EriK7Ffgs5fRzFKprYW2f6YWTTRver?=
 =?iso-8859-2?Q?Nx3DC2/PltRpnIFmnqMhzfyzKsXfHq4//lzXCdxdzO85p+0vfevzBYFg7u?=
 =?iso-8859-2?Q?QPrMJ3XFongBjGGSVZOzYDvm6UbNrRpBz19FQ9KFq/sVILdnbcVm9Fc6S0?=
 =?iso-8859-2?Q?k6vLfE6wGZapP7t+Yc0hew7F4z4vWmfsCSlzGo2nIuZU4PjZJ8qIauHprR?=
 =?iso-8859-2?Q?V8oIIXIHTrLG4kFLRYKiEMhIqrvfjiSP+w4=3D?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee3eec37-e3e5-4405-30a7-08dbde9b3d70
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2023 07:37:33.4575
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kVK5/b4XbmHw1YFkEz2gCaAxGGYnwpNLHSrtUIFP7DGMwyruhaFERAgEMh62OYiOXmhSuGMRiKEGI59aEStn9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR04MB6337
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Sun, 05 Nov 2023 23:38:03 -0800 (PST)

> It is important that MMC_CMDQ_TASK_MGMT command to discard the
> queue is successful because otherwise a subsequent reset might fail to fl=
ush
> the cache first.  Retry it and the previous STOP command.
>=20
> Fixes: 72a5af554df8 ("mmc: core: Add support for handling CQE requests")
> Cc: stable@vger.kernel.org
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

> ---
>  drivers/mmc/core/core.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index
> befde2bd26d3..a8c17b4cd737 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -551,7 +551,7 @@ int mmc_cqe_recovery(struct mmc_host *host)
>         cmd.flags        =3D MMC_RSP_R1B | MMC_CMD_AC;
>         cmd.flags       &=3D ~MMC_RSP_CRC; /* Ignore CRC */
>         cmd.busy_timeout =3D MMC_CQE_RECOVERY_TIMEOUT;
> -       mmc_wait_for_cmd(host, &cmd, 0);
> +       mmc_wait_for_cmd(host, &cmd, MMC_CMD_RETRIES);
>=20
>         mmc_poll_for_busy(host->card, MMC_CQE_RECOVERY_TIMEOUT, true,
> MMC_BUSY_IO);
>=20
> @@ -561,10 +561,13 @@ int mmc_cqe_recovery(struct mmc_host *host)
>         cmd.flags        =3D MMC_RSP_R1B | MMC_CMD_AC;
>         cmd.flags       &=3D ~MMC_RSP_CRC; /* Ignore CRC */
>         cmd.busy_timeout =3D MMC_CQE_RECOVERY_TIMEOUT;
> -       err =3D mmc_wait_for_cmd(host, &cmd, 0);
> +       err =3D mmc_wait_for_cmd(host, &cmd, MMC_CMD_RETRIES);
>=20
>         host->cqe_ops->cqe_recovery_finish(host);
>=20
> +       if (err)
> +               err =3D mmc_wait_for_cmd(host, &cmd, MMC_CMD_RETRIES);
> +
>         mmc_retune_release(host);
>=20
>         return err;
> --
> 2.34.1