Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Adrian Hunter <adrian.hunter@intel.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        =?iso-8859-2?Q?Kornel_Dul=EAba?= <korneld@chromium.org>,
        Radoslaw Biernacki <biernacki@google.com>,
        Gwendal Grignou <gwendal@chromium.org>,
        Asutosh Das <quic_asutoshd@quicinc.com>
CC:     Chaotian Jing <chaotian.jing@mediatek.com>,
        Bhavya Kapoor <b-kapoor@ti.com>,
        Kamal Dasu <kamal.dasu@broadcom.com>,
        Al Cooper <alcooperx@gmail.com>,
        Haibo Chen <haibo.chen@nxp.com>,
        Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>,
        Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>,
        Victor Shih <victor.shih@genesyslogic.com.tw>,
        Ben Chuang <ben.chuang@genesyslogic.com.tw>,
        Thierry Reding <thierry.reding@gmail.com>,
        Aniruddha Tvs Rao <anrao@nvidia.com>,
        Chun-Hung Wu <chun-hung.wu@mediatek.com>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V2 5/6] mmc: cqhci: Warn of halt or task clear failure
Thread-Topic: [PATCH V2 5/6] mmc: cqhci: Warn of halt or task clear failure
Thread-Index: AQHaDjLZw7S/sDZV6UOnOsoxT8d19LBs6+yw
Date:   Mon, 6 Nov 2023 07:38:32 +0000
Message-ID: <DM6PR04MB6575B4B1FD9565A3DC5B7DF1FCAAA@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20231103084720.6886-1-adrian.hunter@intel.com>
 <20231103084720.6886-6-adrian.hunter@intel.com>
In-Reply-To: <20231103084720.6886-6-adrian.hunter@intel.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-2?Q?h656EVXlZG8skE1u4qaadJ3+/Q63J9bFngyzur1sUGJ45v7yW+4PHInbBB?=
 =?iso-8859-2?Q?5Rj39/Vq0Ls6azjwqx+ltM9civXRPfLYPh+wKkKXjDk+z0yTtivR/DzUA/?=
 =?iso-8859-2?Q?FgjQ+PrqnZeJLTtFB8D3YDs/HoSTrDf5t2R50wbaHNran/S+RdB9eHHZTk?=
 =?iso-8859-2?Q?Il5puvG9bAavEZcWRykynqFL7O17OrpFEig7H74rMWV5CxtWWPH5zFJMGN?=
 =?iso-8859-2?Q?1X3QSibHRgCX+RvnIoRvIZvLXHx9kSerLsc/ZjSl1MesurttFtMesguRSD?=
 =?iso-8859-2?Q?zWAf7lFOpmbJCvAC0hTR/m5MG/omAUR5Xqocm9Uma2+xYkxY/wxd/vAQON?=
 =?iso-8859-2?Q?DbidDINnxzGWw/SzJFwRTEVPavzAnTcwDUzBZNRO/KLnMUrfKyJ0/GFJP3?=
 =?iso-8859-2?Q?xCCcklHVdIkccVk7SRfrfw9s2hWaHWt8CGJRzpH/j4lVDihoAOMs8RbFY3?=
 =?iso-8859-2?Q?//nZnD8A97eMaurSNb/CummH6TmPs+zaxHRurCV3TTjXXSZezl3vqK4biI?=
 =?iso-8859-2?Q?82z6wJ0O2uolg1AVyPKp93raflVeiMdaE1F2FI4ccJYXShSyegOBvReU/1?=
 =?iso-8859-2?Q?BH79L7Ob7VRmge2YcBB9xuiqsSh3KwR1NmCyUrtDR+R9G+AXj5y1FLqEb5?=
 =?iso-8859-2?Q?LkFn3TGwkmFxy5XgYjhEoDCUceNAt6L63CtedNMOwEPnBglnxj8kFO8fXY?=
 =?iso-8859-2?Q?S83cSXjD0H+yznq/IEGpBgFacDGEMHY8SwX+nB6v2uTiOvS7xtXiZjQLBd?=
 =?iso-8859-2?Q?pb164gt3awWxKR43zhAlxbaOt7qMV0xycf8MxdB5kjGPn19xkxmeOdiwc3?=
 =?iso-8859-2?Q?UP0JVM1nTFo1ouODJg2vFoDvHeFKzbCLCJPkqw8AwDtxdOY5r2YR5iUM2V?=
 =?iso-8859-2?Q?UsP3aUFWf+eCg6uhsMDrOL41zM3f3dGV/99S8bSyxqQNk42oN6qBjKSG+D?=
 =?iso-8859-2?Q?eR89xpBs1RvrDWBUQIRH8E2gWHeTEUwiKwLe+AL4cwGuCPMPS6zG6ujJLz?=
 =?iso-8859-2?Q?gx2EXXhK8345xdV6VgSzn+bMJByXEL9KwTmsW4o6c2zRp3r9Z1i8ufGBCm?=
 =?iso-8859-2?Q?L3YepSJz4/9cVQZ/pj52RkquxkNVZyD0OXWjlo80jsXBjuLKZAH1yHYjIy?=
 =?iso-8859-2?Q?h4eiAPr0IUlkV/UvPRu/6Ps39nR0iX8N4wc6xYvRd1K0+cyCf2A5ZqHBVn?=
 =?iso-8859-2?Q?0eFpUZdLnZ3oeNeNMPvHHLUi6W1hFlf7SWjmbT+u3LAYMiM2XJp4pvAqt1?=
 =?iso-8859-2?Q?oSSn6W9UjUO2++ECH/kDYbgdrBYj59eA10BIpLUyo9KIFrhqQ3+gdVRzJ/?=
 =?iso-8859-2?Q?Rsz+EvsZFapUeVApTtI6B2CmeKKKf7J+MbfNHV/ixlHc7eJZNJYOumpbUo?=
 =?iso-8859-2?Q?cwK60sjxcLPPtvGho3UL9rJlyhdAcn6YDOrk3NKiDcWYpelB9nyQ7yOsJO?=
 =?iso-8859-2?Q?W57/2pFOzgKrzfiCsJZnOKFcHFVfQnGDOZJojeHTHMvBkn7EYOd/qGbUP5?=
 =?iso-8859-2?Q?I7am0TNA2AIHY1aYgn8jk4QL5rOl92JxdTTHHWo+3FyAVtp1HbVN8L7TIN?=
 =?iso-8859-2?Q?lgAbG3ULHBLeNl3xYnYmoIUzRuyQsr2/+wOkNlvV2Nub0CzWy1On3u1Ikh?=
 =?iso-8859-2?Q?iK/m0NDDj3McVoWznKNkHENiSI+IdslxS3?=
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?iso-8859-2?Q?xtwumyvQoiMkwn0bhz6KnTQpiJQokUa3fauICVtNa/gdetmOTUFneSVGLx?=
 =?iso-8859-2?Q?gWOeYcE7eoJD78ywILP+EF+2ijojbuYGDKQHJ23BopxwVA/11aShBHV4jb?=
 =?iso-8859-2?Q?t59FFVwRfmAVSsJUx9EQ+yWa+/n/ce0oHgpRB5bjJXTgYKyiPYKu0fvSNd?=
 =?iso-8859-2?Q?Oo5YmXYrMO7X0RWvhqlum+jScbZHqWiWmTRx63h1iaAYZc7qISorNXKOqK?=
 =?iso-8859-2?Q?5fcG3bJzAeNHMJ4uf66XINhwCbBFW9oZ8MHotUYijhBbBZwtLu3x2mtgLb?=
 =?iso-8859-2?Q?2FgUP8wsrSnHezI3X2PgD4GeuLo+1OhDVP0NsLGoCkI/0XcvfqflK1o56Y?=
 =?iso-8859-2?Q?yYqJsNacoZg9geOyk3T+R1NHftQ+zpn5ZDnNBjze+E3zf0e7E66ImoCP6B?=
 =?iso-8859-2?Q?xWlTz4fNIlG9a5RQrL682tpvsZmOEnq4hMcl1XVVMHseBLdhcHM+D2si+n?=
 =?iso-8859-2?Q?IZvMykhZz4zciopxpaslVYvAfiE7eXZmK+g9Sj+Gvk3wloJKWlqD6v49Qa?=
 =?iso-8859-2?Q?BbuY/ifhZI7PQdAO4Ss1Zg+VwnZQ/3YhXQe8Yoq/HfVskaEXYmrYxL+zAx?=
 =?iso-8859-2?Q?0RjxMc8u3c8x2RFfI9a8XqRk7qWPU495CyIcEiewrAV/ZE+t9JhnwcjsTB?=
 =?iso-8859-2?Q?cse6bSc091KnaYiFs7qvMl7ywONH0yr0+Sd47aMVJElRKd2cYQ9ik9rI92?=
 =?iso-8859-2?Q?YFMYkN+GOB58Xfuri/McyLMQCofIa6IQ2Bi7IOUxEo+mTD6RWVTfphcilP?=
 =?iso-8859-2?Q?dpH5UXhRCbFP59dxnfZKHJkqNVlHxDI6V5bUA9hzb2bAG8x/2KIBrNDwQ+?=
 =?iso-8859-2?Q?WhZMDAH4KlBfcQAdQqaKsrFuSMaFtYX85+hmgpcSaY7KoCt9Hm4ZIyEwgP?=
 =?iso-8859-2?Q?ob7d05bQ/BUQwxV5QYmGlsbD9Hk71vsFVXVoGtg17+CGLxc4DJhl5/dPvo?=
 =?iso-8859-2?Q?uTSLt33b4BAZbOtwovX4RsAgskASfaEoQPVUATy7dd+LzUOjFL8ssZdxjn?=
 =?iso-8859-2?Q?6Q36ECfn+gmEm7HqfiYXhMPE/V7m9ih0JczeUB4YpuV82cHoOHvtv2sx5I?=
 =?iso-8859-2?Q?jTYqrpg03hNR/tvv2+IYpll7xBZkYLYoeCMi1t4+a3brH3iPapfW1T01Vm?=
 =?iso-8859-2?Q?IY/MjD6zoFxmLOcx8Y23qL+ksG8AeSCri0Rlusn5rcuK5bSJzKTIQydTkG?=
 =?iso-8859-2?Q?2VQ0T/M0slo2HI8sZC4cqZwIWupfO13Sv98=3D?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ebce004e-c559-4ba3-93d6-08dbde9b6085
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2023 07:38:32.3221
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6RfFGgDKX1uNqaZT40saLyMiyiTIQasRPg9fGiV1Qmx90qjKqGmnzNseW9FxGxUM8dn8hVF/kWn6ccse9GmG8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR04MB6337
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 05 Nov 2023 23:38:47 -0800 (PST)

> A correctly operating controller should successfully halt and clear tasks=
.
> Failure may result in errors elsewhere, so promote messages from debug to
> warnings.
>=20
> Fixes: a4080225f51d ("mmc: cqhci: support for command queue enabled
> host")
> Cc: stable@vger.kernel.org
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

> ---
>  drivers/mmc/host/cqhci-core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/mmc/host/cqhci-core.c b/drivers/mmc/host/cqhci-core.=
c
> index 15f5a069af1f..948799a0980c 100644
> --- a/drivers/mmc/host/cqhci-core.c
> +++ b/drivers/mmc/host/cqhci-core.c
> @@ -942,8 +942,8 @@ static bool cqhci_clear_all_tasks(struct mmc_host
> *mmc, unsigned int timeout)
>         ret =3D cqhci_tasks_cleared(cq_host);
>=20
>         if (!ret)
> -               pr_debug("%s: cqhci: Failed to clear tasks\n",
> -                        mmc_hostname(mmc));
> +               pr_warn("%s: cqhci: Failed to clear tasks\n",
> +                       mmc_hostname(mmc));
>=20
>         return ret;
>  }
> @@ -976,7 +976,7 @@ static bool cqhci_halt(struct mmc_host *mmc,
> unsigned int timeout)
>         ret =3D cqhci_halted(cq_host);
>=20
>         if (!ret)
> -               pr_debug("%s: cqhci: Failed to halt\n", mmc_hostname(mmc)=
);
> +               pr_warn("%s: cqhci: Failed to halt\n",
> + mmc_hostname(mmc));
>=20
>         return ret;
>  }
> --
> 2.34.1