Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp1965267rdf; Sun, 5 Nov 2023 23:50:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IHwpKnz9yrs0vmb3yQPrB5KZ8+v6EME0ZoCThgGHojMtyLpgWe+yKckZxsZDd7Z1DoICOun X-Received: by 2002:a17:902:f9ce:b0:1ca:a07b:36d with SMTP id kz14-20020a170902f9ce00b001caa07b036dmr23304166plb.48.1699257003194; Sun, 05 Nov 2023 23:50:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699257003; cv=none; d=google.com; s=arc-20160816; b=D0xVwNRjesdUDtcDUkjHHsXcbrlyS5y9lDj6jvaui/OoXsSDwHKERyYIuTGvd4OMzE 2+qJKcHKGKDmqFpkrxeuwRZUvGFwshxJsb3oEiQJj20HYrqK/L6c37spIdlKqKUHVT0S 6SdnRcsIW566gUuwgFgZ7LC+1C+XmsSm8Rdb4oOU6ldYVuGajXCGesxz0gemZleuxbI1 hUIECQXvCAidl0aSyX5Cd0A7vGR8N2Z2tGnvLSq+APEPOTyRyQr0xzKJH4dOOLE9AtV/ q3QrpTiU/4PAtdroLwVTaGt3/K4A7oR4PvRWFcDI6JqP5eiQIe7Cz2bRC4/hqnM5krnh R0JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JsR9ayW5W/B/juTQaypftAOI6FoM2p6JwLFtaaXiYeY=; fh=uQDFLEDemktyuJHP1XhMMRts9Z/jBrUPdpTMYKv9r20=; b=ccInbNma5kkyt5AU2DglpdBKM6hdK75I08cPvnSTAQ4ttFR6vG2XTwpqhAd5QLODi7 bgr0Z9odze1euhs72i9lLrLzr2kq49CEP1F+zf0R6m4/Br+x5n3ihTLRoEt254tD45/J NWjmryWy4X3fIBQ0WTop5mSIFy1eUAVelfqCcyZuGIgjLAm+FyyeItnnKIMD8ZHOFCJq +cfUrgKyB79vVdg0qmM+2cFJH47q6HPhmAqiHG18Rxp9RoeKN4cEDk/aFl/1ZaArSsY0 E9KxVJcbqrHtUtujQfSUg+rJs7MAEI0PLckECUDTy+st26azShrXKltuZobor6fb2iLP njxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="SSznQCH/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id kz16-20020a170902f9d000b001c9cc3a07c3si6940287plb.280.2023.11.05.23.50.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Nov 2023 23:50:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="SSznQCH/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 1405980B1328; Sun, 5 Nov 2023 23:50:01 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230514AbjKFHtx (ORCPT + 99 others); Mon, 6 Nov 2023 02:49:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229803AbjKFHtw (ORCPT ); Mon, 6 Nov 2023 02:49:52 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15D6C93; Sun, 5 Nov 2023 23:49:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JsR9ayW5W/B/juTQaypftAOI6FoM2p6JwLFtaaXiYeY=; b=SSznQCH//sjs76e1wLV444srrk IjB9fGYRmpH98jSF6D9OGwcgvbQaqTdm5CXHbU/Ves9131e8i7/fW7YMAGIBhViM6Azlh2HiGHZZ8 ScO1bEes4pdl4jnHCJlzr0zoI1oTJOXkbgRR9u5bi6OQwXwXAYDOsmxsjGvDY7DeUXiBMSx5NEmUn 2Tr/uf8AN4z3twUhnZZKV8AuvnvPBWc/RkkjUVZ3X9iXzkh5psGgYL2/4+Z66RPlWXbUN2le8YYb0 hr/mmhXZjnD6O9ZNH5xmrvdY6bL7shMS1Zc+C46kXVZqrjgO/Nyp2WWYqAdCI7rRELn6VYJwcaVS3 qjfAMdCA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qzuMZ-00G1sz-1b; Mon, 06 Nov 2023 07:49:35 +0000 Date: Sun, 5 Nov 2023 23:49:35 -0800 From: Christoph Hellwig To: Nathan Chancellor Cc: Christoph Hellwig , edumazet@google.com, davem@davemloft.net, dsahern@kernel.org, kuba@kernel.org, pabeni@redhat.com, ndesaulniers@google.com, trix@redhat.com, 0x7f454c46@gmail.com, fruggeri@arista.com, noureddine@arista.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, patches@lists.linux.dev Subject: Re: [PATCH net] tcp: Fix -Wc23-extensions in tcp_options_write() Message-ID: References: <20231031-tcp-ao-fix-label-in-compound-statement-warning-v1-1-c9731d115f17@kernel.org> <20231103165312.GA3670349@dev-arch.thelio-3990X> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231103165312.GA3670349@dev-arch.thelio-3990X> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 05 Nov 2023 23:50:01 -0800 (PST) Normally the kernel keeps the ifdef outside the function body and adds a stub. But this already looks like a huge imrpovement over the existing version to me.