Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Mon, 6 Nov 2023 09:08:57 +0100
From:   Maxime Ripard <mripard@kernel.org>
To:     Doug Anderson <dianders@chromium.org>
Cc:     Hsin-Yi Wang <hsinyi@chromium.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Jessica Zhang <quic_jesszhan@quicinc.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] drm/modes: Add a function to clear preferred modes
Message-ID: <sezmpwogythlst6hnmrpq4hepkdcd764vbgcojidlfotm5boa6@txbcylifakwz>
References: <20231102221309.1971910-1-hsinyi@chromium.org>
 <20231102221309.1971910-4-hsinyi@chromium.org>
 <CAD=FV=VUNdSzppccDO=y0iu_QR8nEe3poRLMmWvFMfZsnWZo4A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="zqnepkdr67hu4afr"
Content-Disposition: inline
In-Reply-To: <CAD=FV=VUNdSzppccDO=y0iu_QR8nEe3poRLMmWvFMfZsnWZo4A@mail.gmail.com>
Precedence: bulk


--zqnepkdr67hu4afr
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Nov 03, 2023 at 09:02:33AM -0700, Doug Anderson wrote:
> Hi,
>=20
> On Thu, Nov 2, 2023 at 3:13=E2=80=AFPM Hsin-Yi Wang <hsinyi@chromium.org>=
 wrote:
> >
> > Add a function to clear the preferred bit of a connector's existing mod=
es.
> > This is useful for edp panel to unset the preferred modes read from edid
> > if the panel has hard-coded modes.
> >
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> > ---
> > v1->v2:
> > - fix doc string (reported by kernel test robot).
> > - split mode and panel patches.
> > ---
> >  drivers/gpu/drm/drm_modes.c | 16 ++++++++++++++++
> >  include/drm/drm_modes.h     |  1 +
> >  2 files changed, 17 insertions(+)
>=20
> This seems fine to me.
>=20
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>=20
> Since it introduces a new API to the core and Hsin-Yi and I work
> directly together, I'd probably give this ~2 weeks on the list before
> landing so there is adequate time for people to comment. That'll be
> right in the middle of Plumbers, though, so it might be more like 3
> weeks. If someone non-ChromeOS wants to review and/or apply sooner, I
> certainly wouldn't object.

FTR, I just made some review on v1 that still applies to that version.

Maxime

--zqnepkdr67hu4afr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZUifGQAKCRDj7w1vZxhR
xdH7AQC1JzbaPpA3miMXGslhsTqX06/6ak67NTh9Xg6ELjtkkwD/eI7TgL8/stY9
lgUDUqvMS5ffwioajaaqRDIPwJ+V/gY=
=Usd2
-----END PGP SIGNATURE-----

--zqnepkdr67hu4afr--