Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <c6e7a2b1-1c5f-42cb-8b2b-49118ea0aa0c@intel.com>
Date:   Mon, 6 Nov 2023 16:52:25 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC v1 4/8] vdpa: Add new vdpa_config_ops to support iommufd
Content-Language: en-US
To:     Cindy Lu <lulu@redhat.com>, <jasowang@redhat.com>,
        <mst@redhat.com>, <jgg@nvidia.com>, <linux-kernel@vger.kernel.org>,
        <virtualization@lists.linux-foundation.org>,
        <netdev@vger.kernel.org>
References: <20231103171641.1703146-1-lulu@redhat.com>
 <20231103171641.1703146-5-lulu@redhat.com>
From:   Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <20231103171641.1703146-5-lulu@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFVRWkpzVVJPQ0ZLV2Q2ejVQMDAxRmozVUo0L2dIWkxtRCtET0krR1dSNmZ6?=
 =?utf-8?B?ZzI4MXlxSTRsVlEwQzJ3Q09OU250NVBkc0lzNmxUWVhlYWNBVnh0NDR4bnY2?=
 =?utf-8?B?eFZOUVBQbVNaQUxxZTBXbWhoYzRvRmtzTjEzdHp5Q0tvSWhlNmp2S3ZwNTZS?=
 =?utf-8?B?Y3hhMlNxc05ObDBzcHpiZ2JDaVdGdnJDNG1hU2VxM0JTU1B3aWNjVmZ3ZFpv?=
 =?utf-8?B?VnFpSFYxS0RkYUlLaGVtR2tLbzZNNTczZTJqekZTN2NmMzBuWUZoYVpBcVlB?=
 =?utf-8?B?M2x3OEJibjJBQkIwMW9yN29CMlU5Umc5ZkFFbkNRbGZwR0tNdmxaSEJmYW80?=
 =?utf-8?B?OHQxcXFxUVZtK0YxVHRWMFVFZUpnM1ErQTB6S3pBMHY5Wk5VNUNwOVRpYnZj?=
 =?utf-8?B?cy9rNTdDREdScmZvRFplYThvbktoSlMrcTFLblJGZExiZEJ4NUppaHVmVzdX?=
 =?utf-8?B?ZTloMGRnTDJZWWhvakNHUGhidVNnaFhLRUdVY08xZC9XZTJsRXhLRHhDWXda?=
 =?utf-8?B?aFliaHRaYUl4SFdTUW1yYXdLcHN6elZzd0FEbU9IbW1iK0NNdTlDUXNCYXdY?=
 =?utf-8?B?RHVZdGMzemx1VDJSeXl5cFMzeFlZQnhDVkR4NFFyMldYdGx2Ym0zNGloU04z?=
 =?utf-8?B?YmNEUTM2NFVoV1MzWW1xMVdacXRJeGdZSk9SYkRJdE13OHRMdXFnZkxOTGVw?=
 =?utf-8?B?WU01ZWlsVlN5d3VnUy9iSDdrdmwxMTNhbnhFcjEvemZ5M09JYTdyM3VRMWt2?=
 =?utf-8?B?cEYvK29SQTdVZ2xaZjJ6NHl2K1B3OFovYmxXdUpaSHB2ZTZYUzltVkdnLytP?=
 =?utf-8?B?a2JzbGtydTdtZ0FMK3lRbEVaOHFPL2pOdkY5WUI0YmJPSmhrZERJMEV5dU1n?=
 =?utf-8?B?RVdzRXhBUXo4OWNjNGlLTC9aS3kvdW9ZcTBrU25TK1JhY1BLckpnME92SGhM?=
 =?utf-8?B?dmszOGxUYi8yQU0wbUV0bmpKVXVwb2dySy9waGUwakRaZFR1Z1Zadzg5emdL?=
 =?utf-8?B?d0xuSTVZaVdkSUdYSE1Ib0xjeGZyRVBSVWVuWkxNL2IrZm1mc1RlOVF3RjhR?=
 =?utf-8?B?MVczbzJVcTRtR1BIR3Q0eVI2VEdzUTZHZE9VNnRUTmhBS1V6bjNGU015QWNO?=
 =?utf-8?B?dmRacTRuaVhmSTlMQi9ZTUdWd3R0eDBmdG91OWkzeWVJR1pLcjFzNFhYVEV4?=
 =?utf-8?B?aktqdDZBWHhERVo4UU9QMzZSVEFsU1hKbkJzK1EyUDNRajNuUlI4dUF1alUy?=
 =?utf-8?B?UUhyYVczazZkbmJ3ZFBuVTB1NjA3REQ2dzdQelBIRmpiRnh6MDVJWmQrT2Rp?=
 =?utf-8?B?QS8wQWpKK0lXUlVsaHRIV2hLaHNFR3BxeVA5WXd0Y1hjOXR3aE9XVW5YVE93?=
 =?utf-8?B?aXZvQlR4YjgyUUdIYmFKQWdpY3ZzUE9XcnNBKy96a3phNWg2eStZNHJ0a2xX?=
 =?utf-8?B?L2RJVWZHSWszb0ZINFUyck5UelhBaVBzdGpiYWZFZUVzb3UzelRWcjYvT3pk?=
 =?utf-8?B?dFZ5NDEwR2kyUTd1UEpNaFBDcWllVzNTMmMrZmlvQmhXbkxJT2dXWmpsdW9k?=
 =?utf-8?B?d3NHUzRPcXJjNmliSXh5Qk0zL0Nvc3hPUFNSL1pOVjliVVFTNXN2U3hpYmgx?=
 =?utf-8?B?RmlOeHlENWs4MG80ME1DTWJDY0JwS3FlNEtDNzlGTVdyc283bWZmazJ2eVdJ?=
 =?utf-8?B?RkN2OUE2b1doend2L2t5WGZSL2VRamhTME5XU3RhMkRpcUVremd4THdYSGZx?=
 =?utf-8?B?WHVEbS8wUDZrZjI2Ni9SQWVRbmtJcHFxRHptT1VMQVlIVlhGTVBEbzc3bG1Q?=
 =?utf-8?B?K245T0xaUURCYlBmd2tVV0FkNUsvdnFTd3k0M1FNQ3hTSTI1dEZ5SVdPQTAv?=
 =?utf-8?B?bldqTlY4ZzkrMzMxcjR5dmRNWU8wNlE0Q1hNd2JFTDZLaUJqRnRSZk1zTnUv?=
 =?utf-8?B?UDBhODI1QmY2RzRlRXQwSHJiTk9lSTVsVUVXMEFoQ1dGTlBuVytQa0JIOGtW?=
 =?utf-8?B?STk0UHNUMDVXT2VYUW5IY1BxYitmN01hMjNRd2JlYkFQR1BLemlaOVFUSWNx?=
 =?utf-8?B?K3l5eENDMUozeVk1ZmVXelBtYXJWamlDaTc1MnZWY0FkNkxWUXAxM252V0p2?=
 =?utf-8?Q?i2xsa32l8JkEOgpX/055F7Xq2?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 55997bb0-e7f5-472d-893a-08dbdea5583d
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2023 08:49:53.8346
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: spsn8+AFOUW2u0Rqy0RdyD+NTBv4E0lIPDNWXIoiEAmm5XiTpTEoHM8wi3yx3qJabA8FWvJQYSU/kuVoZzK06A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7925
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 06 Nov 2023 00:50:11 -0800 (PST)

On 2023/11/4 01:16, Cindy Lu wrote:
> Add 4 new vdpa_config_ops function to support iommufd
> 
> Signed-off-by: Cindy Lu <lulu@redhat.com>
> ---
>   include/linux/vdpa.h | 38 +++++++++++++++++++++++++++++++++++++-
>   1 file changed, 37 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h
> index 0e652026b776..233d80f9d910 100644
> --- a/include/linux/vdpa.h
> +++ b/include/linux/vdpa.h
> @@ -5,6 +5,7 @@
>   #include <linux/kernel.h>
>   #include <linux/device.h>
>   #include <linux/interrupt.h>
> +#include <linux/iommufd.h>
>   #include <linux/vhost_iotlb.h>
>   #include <linux/virtio_net.h>
>   #include <linux/if_ether.h>
> @@ -97,6 +98,12 @@ struct vdpa_device {
>   	struct vdpa_mgmt_dev *mdev;
>   	unsigned int ngroups;
>   	unsigned int nas;
> +	struct iommufd_access *iommufd_access;
> +	struct iommufd_device *iommufd_device;
> +	struct iommufd_ctx *iommufd_ictx;
> +	unsigned long *vq_bitmap;
> +	atomic_t iommufd_users;
> +	bool iommufd_attached;
>   };
>   
>   /**
> @@ -332,6 +339,17 @@ struct vdpa_map_file {
>    *				@vdev: vdpa device
>    * @free:			Free resources that belongs to vDPA (optional)
>    *				@vdev: vdpa device
> + * @bind_iommufd:              use vdpa_iommufd_physical_bind for an IOMMU
> + *                             backed device.
> + *                             otherwise use vdpa_iommufd_emulated_bind
> + * @unbind_iommufd:            use vdpa_iommufd_physical_unbind for an IOMMU
> + *                             backed device.
> + *                             otherwise, use vdpa_iommufd_emulated_unbind
> + * @attach_ioas:               use vdpa_iommufd_physical_attach_ioas for an
> + *                             IOMMU backed device.
> + * @detach_ioas:               Opposite of attach_ioas
> + * @free:			Free resources that belongs to vDPA (optional)
> + *				@vdev: vdpa device

duplicated kdoc.

>    */
>   struct vdpa_config_ops {
>   	/* Virtqueue ops */
> @@ -402,6 +420,13 @@ struct vdpa_config_ops {
>   
>   	/* Free device resources */
>   	void (*free)(struct vdpa_device *vdev);
> +	/* IOMMUFD ops */
> +	int (*bind_iommufd)(struct vdpa_device *vdev, struct iommufd_ctx *ictx,
> +			    u32 *out_device_id);
> +	void (*unbind_iommufd)(struct vdpa_device *vdev);
> +	int (*attach_ioas)(struct vdpa_device *vdev, u32 *pt_id);
> +	int (*detach_ioas)(struct vdpa_device *vdev);
> +
>   };
>   
>   struct vdpa_device *__vdpa_alloc_device(struct device *parent,
> @@ -570,4 +595,15 @@ struct vdpa_mgmt_dev {
>   int vdpa_mgmtdev_register(struct vdpa_mgmt_dev *mdev);
>   void vdpa_mgmtdev_unregister(struct vdpa_mgmt_dev *mdev);
>   
> -#endif /* _LINUX_VDPA_H */
> +int vdpa_iommufd_physical_bind(struct vdpa_device *vdpa,
> +			       struct iommufd_ctx *ictx, u32 *out_device_id);
> +void vdpa_iommufd_physical_unbind(struct vdpa_device *vdpa);
> +int vdpa_iommufd_physical_attach_ioas(struct vdpa_device *vdpa, u32 *pt_id);
> +int vdpa_iommufd_physical_detach_ioas(struct vdpa_device *vdpa);
> +int vdpa_iommufd_emulated_bind(struct vdpa_device *vdpa,
> +			       struct iommufd_ctx *ictx, u32 *out_device_id);
> +void vdpa_iommufd_emulated_unbind(struct vdpa_device *vdpa);
> +int vdpa_iommufd_emulated_attach_ioas(struct vdpa_device *vdpa, u32 *pt_id);
> +int vdpa_iommufd_emulated_detach_ioas(struct vdpa_device *vdpa);
> +
> +#endif

-- 
Regards,
Yi Liu