Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <5b0f8705-71cb-4c4c-a70c-d9d3a15886cb@intel.com>
Date:   Mon, 6 Nov 2023 10:31:57 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [alobakin:pfcp 5/20] drivers/iio/imu/adis16475.c:363
 adis16475_set_freq() warn: set_bit() takes a bit number
To:     Nuno Sa <nuno.sa@analog.com>
CC:     Dan Carpenter <dan.carpenter@linaro.org>,
        <oe-kbuild@lists.linux.dev>, <lkp@intel.com>,
        <oe-kbuild-all@lists.linux.dev>,
        Przemek Kitszel <przemyslaw.kitszel@intel.com>,
        <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <ff4ef031-774e-4e4d-a009-31f242bf6aee@kadam.mountain>
Content-Language: en-US
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <ff4ef031-774e-4e4d-a009-31f242bf6aee@kadam.mountain>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MG9iWnZoWGZIOVFrZDlZMFRvYzY4YkZCTUZPRkFmSnJqVDQ0Zkdhd2NYZjFj?=
 =?utf-8?B?L2s5NkszbVZuUnlCMU5SZWlDSElac1J3Q3BMdTc1UU92cUFvdVdyZFRJTDFP?=
 =?utf-8?B?d1BNZ0dkN0l2UlNiZEtIYXFMTFpneWg1eEsvV3ArR0NraVloVGx3TjUvaDRD?=
 =?utf-8?B?aENIem5jOEhockdMSWl1bU9wWWhIc1FGRU9WS2luYytRQnlWd1R6L0RhdkpJ?=
 =?utf-8?B?ZEVPV25saDRIYi82OTkzdjljcVpMMVh5ekFGb1B5NEtyb3Q4eDdleHpXRlow?=
 =?utf-8?B?dENMOHpUM1RtUGE4ZzhYUWxPN21kUDVVenlHaGdKTXBsVkU0aHZCd3c5dWpO?=
 =?utf-8?B?VTMvVDBLRzFiT0UwZE41OS9wT3J3VXc0Mmx0ek5PVXZGR1BadkV6QXcwMW95?=
 =?utf-8?B?ck1DVHVNVHk4U0hjQUtsQXFYekE0bXBmakUwRGRoSU5UN3V5K0xFWUoxa0xR?=
 =?utf-8?B?OW5QUW1MSE1MbSt3NTZYbWxoZXFSRWRrS2E1cC9pMmh2WnNMdlR0bFBSQ2Y2?=
 =?utf-8?B?ZkxYK0U5TWRBbUxzTjBvRHFCRmJqYWVxS2owQUJmSU1ieVArRURjWGZrSHNP?=
 =?utf-8?B?enBabEJMeUp4clVJeTZmR2VTRHJGbzB6SXdQd1Vpc1kycXByL3ozeXdxa0xX?=
 =?utf-8?B?N2J5N3l0ZjYzY2thd3JtZWdyRXVZMXptS1VCNGZmRXZUdi9IdlMxcDVuakIr?=
 =?utf-8?B?YlE0TUtUSlNFZUtYaCtRb3ppeXlYeXh3MTFNc3NWc2lyK2ljbHp6cXJBU0JL?=
 =?utf-8?B?bHJqZEkrRysvT3lmcGRhVFMxWGhDZ0xaMHFyUFVLTkZmMTc0K3lUSjlPd3p3?=
 =?utf-8?B?VzdlVDVzUmU0dVNCSzQ3MFJIYzBJQWtRb0VyNGpBSkpySDJPOHpiREhhYzNY?=
 =?utf-8?B?RXdTTHBRd0JyV3lmVG9GZC9LYXJqL2N3cjMwUnRtTFdpRSszaTF2dHFiaitn?=
 =?utf-8?B?Q0pMZ3ZpUG9oczFpK2R5ZnhDNC9pdGFRREhjeFhtQjBxNDR2K1ZyOHpkRFpS?=
 =?utf-8?B?K3psaWUvRjNrVWk0eHJqQ01RajZod1NlcTUwRktDTjdmTVc4aFNyVExsWU9I?=
 =?utf-8?B?RjZNVjJTdXEyMGxqOUttTGwxNjN6TFpaTWV2R3FjazNsSmRrcWZiYW1mNmpy?=
 =?utf-8?B?c25hTkwvNjVVaFFRd1RHL0RweTI2WHN3R21RU2I3VkZUaXFlTE80VnpoRjN6?=
 =?utf-8?B?YWZZMHA5ck5acFEvQWFyMmV0ZzFaZmRoMzlSR253SDVPRmlzd3hxTFFYTUdV?=
 =?utf-8?B?bDdXemtjVHJwc0ZyTnB3aTE2Q3p3T05aQ3FrbjNKSTQxTHlvNHV4Ly9DV1Mv?=
 =?utf-8?B?elpiN2J1cGZ5VHl1YnpCOFVCa08zMU0zdTA1UXAzNDc2WGkyQS9lNndDa3pV?=
 =?utf-8?B?ZUNhRUxnU1pPN2ZNMC85YWNvblNKQ0F2Y0M0dHhsd1VZRENZQmN3OHg3L28v?=
 =?utf-8?B?VjhMZ2Ftb1RiR0lGZ1RQWGVxei9uc2E3M2JxYVEyR3k0QUR4OWYyYWdrVW9U?=
 =?utf-8?B?c1NzR0VyYTZjWm5ocm5lc2U2UmcvVjVIdjN2YUxuUHVTSWJmeW9Mc3RwTlVC?=
 =?utf-8?B?WDRuOXpqY000Q2JueHRUaDIyUXIwZjRrUnRQTTRmai9SWlZEM0p0NG94R2dE?=
 =?utf-8?B?SkZHTm1ad3V1V2RLRnE3UmRlNzZsSmw1MG4zNEFoTDg3NGtvSkt5L2VOY0wz?=
 =?utf-8?B?ODJqWE4rcHdYODJlVjdMelo5WkVSUlBwOGswV3RqWlp1V1hZT0lTdzRCeVdR?=
 =?utf-8?B?STYvY1JGNnNSb3l2VGhnOHJyLytuU216SWdNMERVRitnZDVrdTVIRlpwTGJI?=
 =?utf-8?B?OGZzMCs4SnBmZitCVThmZDZRTDY5Um1qR1BJYUN6Q3BKdmpxOWlVbys3dGpS?=
 =?utf-8?B?bFZwTWFXMVF5eXVMV0YvdGtDNjVQbmRsa2wxVXBqRFR4YXg4S1F5eUErVXlY?=
 =?utf-8?B?bUVSbDJBZVpJT3hPZU9PWEtUbXZFbjdUYkdrMnVvTzB4YVRjQXNKb0ozeHB3?=
 =?utf-8?B?SDRMbkxHUGxzelV0bmVKdXB5eHE3aGxNWElPTjQ5TVNkczBQbDA0bytSZFo3?=
 =?utf-8?B?UDJLOGdOVGdZdEpmNkZNeFo3MURlTlNiandLSEFETVlYUUVDRVgwbXJUY3g0?=
 =?utf-8?B?RWlqVURFUldRWmhVRnhURnpTY3cvdlFkM3FKWGpVTXVOZ0tuNi9sQ2VhYXFL?=
 =?utf-8?B?dEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 35a35cf7-cf71-4dd6-eb0d-08dbdeab894f
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2023 09:34:13.4604
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o0TpdiXmuwOC9uauLYERgtAt/9jhjVbHImg5BsLlD7BxpjFNGzhnZxsODlIVgyS7EPA1tWjpU87GzDbfKnFun6/GKpU3ED5mLJnQJOJvuyw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5817
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 06 Nov 2023 01:34:37 -0800 (PST)

From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Mon, 6 Nov 2023 11:50:03 +0300

Hi,

> tree:   https://github.com/alobakin/linux pfcp
> head:   89565e300e3d4033b8bb568774804fdc09d4f3cc
> commit: 945a0d6e86d97bf60f2fae88ee557ed3eae18b94 [5/20] bitops: let the compiler optimize {__,}assign_bit()
> config: i386-randconfig-141-20231105 (https://download.01.org/0day-ci/archive/20231106/202311060647.i9XyO4ej-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce: (https://download.01.org/0day-ci/archive/20231106/202311060647.i9XyO4ej-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> | Closes: https://lore.kernel.org/r/202311060647.i9XyO4ej-lkp@intel.com/
> 
> smatch warnings:
> drivers/iio/imu/adis16475.c:363 adis16475_set_freq() warn: set_bit() takes a bit number
> drivers/iio/imu/adis16475.c:363 adis16475_set_freq() warn: clear_bit() takes a bit number
> drivers/iio/imu/adis16475.c:416 adis16475_set_filter() warn: set_bit() takes a bit number
> drivers/iio/imu/adis16475.c:416 adis16475_set_filter() warn: clear_bit() takes a bit number
> 
> vim +363 drivers/iio/imu/adis16475.c
> 
> fff7352bf7a3ce Nuno Sá 2020-04-13  357  
> 9da1b86865ab43 Nuno Sá 2021-09-20  358  	adis_dev_unlock(&st->adis);
> fff7352bf7a3ce Nuno Sá 2020-04-13  359  	/*
> fff7352bf7a3ce Nuno Sá 2020-04-13  360  	 * If decimation is used, then gyro and accel data will have meaningful
> fff7352bf7a3ce Nuno Sá 2020-04-13  361  	 * bits on the LSB registers. This info is used on the trigger handler.
> fff7352bf7a3ce Nuno Sá 2020-04-13  362  	 */
> fff7352bf7a3ce Nuno Sá 2020-04-13 @363  	assign_bit(ADIS16475_LSB_DEC_MASK, &st->lsb_flag, dec);
> 
> assign_bit() takes a bit number like 0.  But this is passing BIT(0) so
> it's like BIT(BIT(0)).  Which is fine until you get to 5.

Is this intended? There are 2 places where you pass
%ADIS16475_LSB_DEC_MASK and %ADIS16475_LSB_FIR_MASK, which is `BIT(0)`
and `BIT(1)` respectively, to assign_bit(), which takes 0, 1 etc.

> 
> 
> fff7352bf7a3ce Nuno Sá 2020-04-13  364  
> fff7352bf7a3ce Nuno Sá 2020-04-13  365  	return 0;
> 39c024b51b5607 Nuno Sa 2021-02-18  366  error:
> 15aacc980dcb32 Nuno Sa 2021-02-18  367  	adis_dev_unlock(&st->adis);
> 39c024b51b5607 Nuno Sa 2021-02-18  368  	return ret;
> 

Thanks,
Olek