Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <f8d6c53d-f241-4ba6-9e27-4d6bc5fbed05@intel.com>
Date:   Mon, 6 Nov 2023 11:07:52 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net v2] net: ti: icssg-prueth: Fix error cleanup on
 failing pruss_request_mem_region
Content-Language: en-US
To:     Jan Kiszka <jan.kiszka@siemens.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        MD Danish Anwar <danishanwar@ti.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        "Lopes Ivo, Diogo Miguel (T CED IFD-PT)" <diogo.ivo@siemens.com>,
        Nishanth Menon <nm@ti.com>,
        "Su, Bao Cheng (RC-CN DF FA R&D)" <baocheng.su@siemens.com>
References: <06ed13ca-9f52-4b49-9178-aae245bfd958@siemens.com>
From:   Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <06ed13ca-9f52-4b49-9178-aae245bfd958@siemens.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXlBKzgxVzNDRmI5VklybmFXbm92WlBvbm9jQlFJVkNnYjVvclBCMlo0elRZ?=
 =?utf-8?B?T2djSkUyUjd3V1kwc1RYMG1rNXNsQmRudHRoUUYrTU5kZlRGTWJKOWxpVE9B?=
 =?utf-8?B?SGNEeThoV1RGQUR0MXhpNlJvWllXY0tMY0x1WW80RW5ydGdNZWdTU2huaHpP?=
 =?utf-8?B?Q1hqcUt3aDF5eE5RNytEY2NMbWVmUy9wbGRLTzZ1bDVUODBMTVVDUS9KUXVr?=
 =?utf-8?B?ME5vR1U2OG9uS0hpZTZhWmZvSG9td0QxQ3BvTmN4RjRkQkloMUlQT3hUVVpl?=
 =?utf-8?B?RXExRFprMS9OQWJwR0xlOHc1WkRxOFJHckhGdmtZTFdoTURuQWV3Z0FIVmVr?=
 =?utf-8?B?eFdXTHFaWXlkT0xnaElpQUdVam9tZFN4TFFmL2pJcnJQMFdWZXNnQXJlTk1a?=
 =?utf-8?B?NmdsVHdETFFMdUROcE9sbGlaUlJGQUZYWi9zVVhRc1ZVUTAxMEVTakI1QklF?=
 =?utf-8?B?UGkvUmdWcUhDUmV1UjdxOUhvbnBGbFNTT0daU2VqdlBZWm9iR3VnNkRHeE5i?=
 =?utf-8?B?dnlaWXp3dEZBcExqdHgrajR1VlNhanlPQ2dmaVBCTWdUTUdWS0FMdFloWHFD?=
 =?utf-8?B?Umx2TVBYWXM3b2pVYzlUajNzclJRdi8wZ2orSUJLZUNOTVgzRTZFYWxuSU5F?=
 =?utf-8?B?RFNZYS9nbmhIZW91M0l0d1c4aUNMZUxSZlZZeE43b0ljbEdUUVpXUDNCWTlk?=
 =?utf-8?B?TGk0cS9qSU1Mdk9tbjBnd1hvaWE0YmVNQmFRSzFxSE1MQytUQW15bnhJak9W?=
 =?utf-8?B?T0ZrNDJwQ2MrSi9TbHJ3d3I3QnpwVktkcWpiVGdEMFFzek1yMS8rZHJNWWNK?=
 =?utf-8?B?bmNFSGhXZ1pYZFArNC9VSlhUUk8vK2RaVjlaOHRBeUt1ek5nNytWcTJjMGxP?=
 =?utf-8?B?MzhJMUZqM0YzRGcrM0xNVVI3T252QjJLQ214VmNZdXJSbGJ5dmMzYURuQlEx?=
 =?utf-8?B?cU9SYW81SmdoakJxMUQveHlRcEsyZWRxa0xBK0k5K2l3RGZZSkN5eFcxNlRX?=
 =?utf-8?B?NmJ3Y0ZPWXN6TXNJSUNiOTFrZVlyWldNM0VOSVByR2U1c2REZWVYYlcvTFpV?=
 =?utf-8?B?SGFybDVDam4rSzBGeXJUYXhHNHYvbVFVbXhyeEZRQlpYZjhmY3NZcEszMVFi?=
 =?utf-8?B?SnNYS2RUQnFoM2NReExZRlV6ME9zSXF6UmJjU21VcEwxTmpqNGpVUlUybWJt?=
 =?utf-8?B?MzVOQk5LN2xWeklhdlBxVExjbUJJWkY2TzRXOCszSHlOam85ei9hYlhmTDlQ?=
 =?utf-8?B?QWxzQ3FnSStlWlhZWkF4MnppVVMweWVoSk1pa1cycEwwTVRkMUY2cXhIZWNW?=
 =?utf-8?B?N3JEUTVlTFFrWEFqT0ZIcHhVRVUyR0RDc2l2VjZZckFkd0x0RVp6eHBTVEVn?=
 =?utf-8?B?MEJadnJnbVJOLzA0R1FOdmsvVnV2RFBjM05LOFlsbDcyK2hRL1laZGRLMWFs?=
 =?utf-8?B?dldHZVV4M1ZPV2oyYk8zZGNTckdqVExMTGU4KzgvZXZBNmM4SUhNV0xkclJh?=
 =?utf-8?B?MmszbHd5QW01R1IyV045aXI1T1ZhTFNrVmhkWVl2VnJMZTM2WTJzaDhqTUpO?=
 =?utf-8?B?dWg3dmxrcTZPV1ZCeTlqL2hNWFdTWUZkZ0UzYVFpS29wZlk4cHNTK1lxV2k1?=
 =?utf-8?B?OVdaSklUYUF6OXNPNjQ2cHlrM2kvWHRzVXl0RXREOXJ4TFRuY01HekQ0aE9M?=
 =?utf-8?B?WXZlc1JsNFp3VnMxT0xJbG9LdVNsRGx2eHdzMlJJYzhvOXM4VC80QklxaVFS?=
 =?utf-8?B?Qmg1Uk9sMFVGZ3cybmZZYmtBeG1HNUR3YVh6WHNxQnV1MkluUVlrMjVyTitx?=
 =?utf-8?B?bDNQWWNkN2s1Rk9JZXlmejRjZ2F6M1VNT2dpYk9NanVDV05xa1djTE9RTkpo?=
 =?utf-8?B?eHlWRVdsdlFlbElLdlpDQmNzYnBxdlJQQTVVdHVvOFdCTFcvaGNhazJwRCtu?=
 =?utf-8?B?Uy9zVjZPOUR1ZVZmYmJMakN5dWh0emp4TjNzZDMrMVhmdStlQWg4cXBEYWtT?=
 =?utf-8?B?Tnp6c0t3bkphOS9ZM1lNQ3hQMjZ6YjFTNWlKOFAvaXV1WVdOU2hWbHU5WG1m?=
 =?utf-8?B?dVVCODdKWi8wWDNPSzJycVFKL2phNE1mQ0J6REZjSUVkeW92c1RWRzREMmtY?=
 =?utf-8?B?Y0xhL3psWHRLZ0tXTnJLZVBFcUJuR1I4WGhSSTh3Rmw1OWVlN1pOWERocHc4?=
 =?utf-8?B?UkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b1fcb43b-8ae0-410f-3f34-08dbdeb04085
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2023 10:07:58.3835
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hPdIOX/5tovWuIwPukKMbzJlXkbWLW8ZEkHX+olHooWdNcdr1UIksW8HFzTwu3SfQJYXuWWvnfybenAMsLYmXiXt8nP0xzS2zSm8yJtFgEU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7309
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 06 Nov 2023 02:08:21 -0800 (PST)


On 05.11.2023 10:51, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> We were just continuing in this case, surely not desired.
> 
> Fixes: 128d5874c082 ("net: ti: icssg-prueth: Add ICSSG ethernet driver")
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---

Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

> 
> Changes in v2:
>  - add proper tags
> 
>  drivers/net/ethernet/ti/icssg/icssg_prueth.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> index d119b2bb8158..845e8a782d3a 100644
> --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> @@ -2063,7 +2063,7 @@ static int prueth_probe(struct platform_device *pdev)
>  				       &prueth->shram);
>  	if (ret) {
>  		dev_err(dev, "unable to get PRUSS SHRD RAM2: %d\n", ret);
> -		pruss_put(prueth->pruss);
> +		goto put_pruss;
>  	}
>  
>  	prueth->sram_pool = of_gen_pool_get(np, "sram", 0);
> @@ -2215,6 +2215,8 @@ static int prueth_probe(struct platform_device *pdev)
>  
>  put_mem:
>  	pruss_release_mem_region(prueth->pruss, &prueth->shram);
> +
> +put_pruss:
>  	pruss_put(prueth->pruss);
>  
>  put_cores: