Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp2020191rdf; Mon, 6 Nov 2023 02:13:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IG/8lKh4978b4NnnA2n5JXng4xKdWy8s48WbWUEWpVSCiLMlZUfJ96HkLaPTuTi08fG8SSS X-Received: by 2002:a05:6870:1004:b0:1d5:b1c7:3617 with SMTP id 4-20020a056870100400b001d5b1c73617mr22495488oai.13.1699265582320; Mon, 06 Nov 2023 02:13:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699265582; cv=none; d=google.com; s=arc-20160816; b=Mvg3JGsMvMd4NRIFdbs/dw+pT3NYxwEJC0U2kHw1/OZVAv0Wk05rYJcfk32MCelST5 1YGfj0D21lLDCyxuVS8j8wC3lc231MxxC2Vyk7N1/QL59i5VibLaEP1HWJF/0f5tR3y6 SXIivDuZAKBbtd8WAe/yWrjmgvEsSQkOQUnddmkMb7bHrVcmFsQCGFT0ET69C0tcuBtQ WsVTJzk+UMrDmhcodKZeMcWtgH67EfUfMvEzibOG9pEKgeTwOyRJPBC8SR/mFzbNvUse Spi23+yfTtmckpJXqTKa3X4i/AeezMQxUN1eiFQZ46a0hykKHBoEkXr0UQSZcDERadhu 8DlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id; bh=mjupEx+CtxFpKoV5IJ+BjCC78N3dxhUaOHWLHBs6Y6E=; fh=1n243WGTIGEnbscWtVRu5QiTpQ8FGifzkMEOziSODuQ=; b=XppiHQcdpDlfLBPy56hUo4gU6KDyy05a6HrV53bleytJLTr3vBQ9Tjt4ndOsRQSTVm bT0a8JvkxX34iiaH6F/zYx8wQuwStjwrO+mpToDBfLQ+QcVq08piFDd8BopHdH733Cdx WTPFijbRtSduZyhfOUBA6cl2Xq3KnMalNrf/cBuxbHwTrNDb2Rs90d1tjXUyXQh/Itaq rHp/ecqwJS/TCCrw3od8QMC1ufs7dOtZIo3bvEiH2DAGqbaKHJc8TSEdh/4qfgLigJjJ 2ARDpi+nP5998RJwZqYQL7wzsQ3FIIAWyvVLKyLl/BosaUBhMQ+00kCfsoCh01o+o7ES gkZw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id u123-20020a637981000000b0057771e49c25si2090799pgc.693.2023.11.06.02.13.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 02:13:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 99BCD8051B39; Mon, 6 Nov 2023 02:12:59 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230284AbjKFKMw (ORCPT + 99 others); Mon, 6 Nov 2023 05:12:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230211AbjKFKMv (ORCPT ); Mon, 6 Nov 2023 05:12:51 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 62388D57 for ; Mon, 6 Nov 2023 02:12:47 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B309FEC; Mon, 6 Nov 2023 02:13:31 -0800 (PST) Received: from [10.57.40.236] (unknown [10.57.40.236]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 675873F6C4; Mon, 6 Nov 2023 02:12:44 -0800 (PST) Message-ID: Date: Mon, 6 Nov 2023 10:12:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/4] mm: swap: Swap-out small-sized THP without splitting To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, david@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, ryan.roberts@arm.com, shy828301@gmail.com, wangkefeng.wang@huawei.com, willy@infradead.org, xiang@kernel.org, ying.huang@intel.com, yuzhao@google.com, Barry Song References: <2fe5ce7e-9c5c-4df4-b4fc-9fd3d9b2dccb@arm.com> <20231104093423.170054-1-v-songbaohua@oppo.com> Content-Language: en-GB From: Steven Price In-Reply-To: <20231104093423.170054-1-v-songbaohua@oppo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 06 Nov 2023 02:12:59 -0800 (PST) On 04/11/2023 09:34, Barry Song wrote: >> Yes that's right. mte_save_tags() needs to allocate memory so can fail >> and if failing then arch_prepare_to_swap() would need to put things back >> how they were with calls to mte_invalidate_tags() (although I think >> you'd actually want to refactor to create a function which takes a >> struct page *). >> >> Steve > > Thanks, Steve. combining all comments from You and Ryan, I made a v2. > One tricky thing is that we are restoring one page rather than folio > in arch_restore_swap() as we are only swapping in one page at this > stage. > > [RFC v2 PATCH] arm64: mm: swap: save and restore mte tags for large folios > > This patch makes MTE tags saving and restoring support large folios, > then we don't need to split them into base pages for swapping on > ARM64 SoCs with MTE. > > This patch moves arch_prepare_to_swap() to take folio rather than > page, as we support THP swap-out as a whole. And this patch also > drops arch_thp_swp_supported() as ARM64 MTE is the only one who > needs it. > > Signed-off-by: Barry Song > --- > arch/arm64/include/asm/pgtable.h | 21 +++------------ > arch/arm64/mm/mteswap.c | 44 ++++++++++++++++++++++++++++++++ > include/linux/huge_mm.h | 12 --------- > include/linux/pgtable.h | 2 +- > mm/page_io.c | 2 +- > mm/swap_slots.c | 2 +- > 6 files changed, 51 insertions(+), 32 deletions(-) > > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index b19a8aee684c..d8f523dc41e7 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -45,12 +45,6 @@ > __flush_tlb_range(vma, addr, end, PUD_SIZE, false, 1) > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ > > -static inline bool arch_thp_swp_supported(void) > -{ > - return !system_supports_mte(); > -} > -#define arch_thp_swp_supported arch_thp_swp_supported > - > /* > * Outside of a few very special situations (e.g. hibernation), we always > * use broadcast TLB invalidation instructions, therefore a spurious page > @@ -1036,12 +1030,8 @@ static inline pmd_t pmdp_establish(struct vm_area_struct *vma, > #ifdef CONFIG_ARM64_MTE > > #define __HAVE_ARCH_PREPARE_TO_SWAP > -static inline int arch_prepare_to_swap(struct page *page) > -{ > - if (system_supports_mte()) > - return mte_save_tags(page); > - return 0; > -} > +#define arch_prepare_to_swap arch_prepare_to_swap > +extern int arch_prepare_to_swap(struct folio *folio); > > #define __HAVE_ARCH_SWAP_INVALIDATE > static inline void arch_swap_invalidate_page(int type, pgoff_t offset) > @@ -1057,11 +1047,8 @@ static inline void arch_swap_invalidate_area(int type) > } > > #define __HAVE_ARCH_SWAP_RESTORE > -static inline void arch_swap_restore(swp_entry_t entry, struct folio *folio) > -{ > - if (system_supports_mte()) > - mte_restore_tags(entry, &folio->page); > -} > +#define arch_swap_restore arch_swap_restore > +extern void arch_swap_restore(swp_entry_t entry, struct folio *folio); > > #endif /* CONFIG_ARM64_MTE */ > > diff --git a/arch/arm64/mm/mteswap.c b/arch/arm64/mm/mteswap.c > index a31833e3ddc5..14a479e4ea8e 100644 > --- a/arch/arm64/mm/mteswap.c > +++ b/arch/arm64/mm/mteswap.c > @@ -68,6 +68,12 @@ void mte_invalidate_tags(int type, pgoff_t offset) > mte_free_tag_storage(tags); > } > > +static inline void __mte_invalidate_tags(struct page *page) > +{ > + swp_entry_t entry = page_swap_entry(page); > + mte_invalidate_tags(swp_type(entry), swp_offset(entry)); > +} > + > void mte_invalidate_tags_area(int type) > { > swp_entry_t entry = swp_entry(type, 0); > @@ -83,3 +89,41 @@ void mte_invalidate_tags_area(int type) > } > xa_unlock(&mte_pages); > } > + > +int arch_prepare_to_swap(struct folio *folio) > +{ > + int err; > + long i; > + > + if (system_supports_mte()) { > + long nr = folio_nr_pages(folio); > + for (i = 0; i < nr; i++) { > + err = mte_save_tags(folio_page(folio, i)); > + if (err) > + goto out; > + } > + } > + return 0; > + > +out: > + while (--i) > + __mte_invalidate_tags(folio_page(folio, i)); > + return err; > +} > + > +void arch_swap_restore(swp_entry_t entry, struct folio *folio) > +{ > + if (system_supports_mte()) { > + /* > + * We don't support large folios swap in as whole yet, but > + * we can hit a large folio which is still in swapcache > + * after those related processes' PTEs have been unmapped > + * but before the swapcache folio is dropped, in this case, > + * we need to find the exact page which "entry" is mapping > + * to. If we are not hitting swapcache, this folio won't be > + * large > + */ Does it make sense to keep arch_swap_restore taking a folio? I'm not sure I understand why the change was made in the first place. It just seems odd to have a function taking a struct folio but making the assumption that it's actually only a single page (and having to use entry to figure out which page). It seems particularly broken in the case of unuse_pte() which calls page_folio() to get the folio in the first place. Other than that it looks correct to me. Thanks, Steve > + struct page *page = folio_file_page(folio, swp_offset(entry)); > + mte_restore_tags(entry, page); > + } > +} > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index fa0350b0812a..f83fb8d5241e 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -400,16 +400,4 @@ static inline int split_folio(struct folio *folio) > return split_folio_to_list(folio, NULL); > } > > -/* > - * archs that select ARCH_WANTS_THP_SWAP but don't support THP_SWP due to > - * limitations in the implementation like arm64 MTE can override this to > - * false > - */ > -#ifndef arch_thp_swp_supported > -static inline bool arch_thp_swp_supported(void) > -{ > - return true; > -} > -#endif > - > #endif /* _LINUX_HUGE_MM_H */ > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > index af7639c3b0a3..33ab4ddd91dd 100644 > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -897,7 +897,7 @@ static inline int arch_unmap_one(struct mm_struct *mm, > * prototypes must be defined in the arch-specific asm/pgtable.h file. > */ > #ifndef __HAVE_ARCH_PREPARE_TO_SWAP > -static inline int arch_prepare_to_swap(struct page *page) > +static inline int arch_prepare_to_swap(struct folio *folio) > { > return 0; > } > diff --git a/mm/page_io.c b/mm/page_io.c > index cb559ae324c6..0fd832474c1d 100644 > --- a/mm/page_io.c > +++ b/mm/page_io.c > @@ -189,7 +189,7 @@ int swap_writepage(struct page *page, struct writeback_control *wbc) > * Arch code may have to preserve more data than just the page > * contents, e.g. memory tags. > */ > - ret = arch_prepare_to_swap(&folio->page); > + ret = arch_prepare_to_swap(folio); > if (ret) { > folio_mark_dirty(folio); > folio_unlock(folio); > diff --git a/mm/swap_slots.c b/mm/swap_slots.c > index 0bec1f705f8e..2325adbb1f19 100644 > --- a/mm/swap_slots.c > +++ b/mm/swap_slots.c > @@ -307,7 +307,7 @@ swp_entry_t folio_alloc_swap(struct folio *folio) > entry.val = 0; > > if (folio_test_large(folio)) { > - if (IS_ENABLED(CONFIG_THP_SWAP) && arch_thp_swp_supported()) > + if (IS_ENABLED(CONFIG_THP_SWAP)) > get_swap_pages(1, &entry, folio_nr_pages(folio)); > goto out; > }