Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <d7806b70-12f2-405f-a875-61137a9c6490@intel.com>
Date:   Mon, 6 Nov 2023 11:15:46 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net v2] net: ti: icssg-prueth: Add missing icss_iep_put to
 error path
Content-Language: en-US
To:     Jan Kiszka <jan.kiszka@siemens.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        MD Danish Anwar <danishanwar@ti.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        "Lopes Ivo, Diogo Miguel (T CED IFD-PT)" <diogo.ivo@siemens.com>,
        Nishanth Menon <nm@ti.com>,
        "Su, Bao Cheng (RC-CN DF FA R&D)" <baocheng.su@siemens.com>
References: <c8081537-f26a-4147-83f3-0c890e824192@siemens.com>
From:   Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <c8081537-f26a-4147-83f3-0c890e824192@siemens.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enNuVXJZTFU1L3pXbzBSbUcvUWZTQWtuMTc5UEZSTm92aXl4NUZRN3NxRWFP?=
 =?utf-8?B?L3hzdjZ0Uzh4T2k3ci84MVFubzVrWk53aTJTbnJhVzVqQmdQZzZYREhCdFNT?=
 =?utf-8?B?QVFvYnRLeXBSci9qU1JwdVQramdrK2R1Y2RUUDBYQWhOT0xxcHhJUVpZeVBG?=
 =?utf-8?B?ZVJibFo5UXZMZmVwbXB2TndGYXNKZHJtaDBkSTVuYnVpWHpuRU1RWGJUZkFO?=
 =?utf-8?B?TDFvWFpUUTVnRGpicTNvNDFFZkFEamh3MExSYnpaZEE4cmNYb0kzM2RHSTJJ?=
 =?utf-8?B?R1U5WGVUZzdCdkF3VEtaRFNVZGV0ZXh2Q0VuZ0lQUEpiQTV1WkcrWGRxbk1C?=
 =?utf-8?B?MnZROUZOZGdYazRhdVN2QWJLMW9BS1B1bEExRUJXZWRrZDU5ZEFRR0lxbmtD?=
 =?utf-8?B?cVE4eCtlcElteHFjYnFobldsSk5lQVdNSThlcUFqWDlxSGR4bDVXTXN1M0xW?=
 =?utf-8?B?NGI1WndTNjBKenVESktLSWlHTzBrQzd5bWYvVGNTa0NQVW92UzN6MEJpYmRQ?=
 =?utf-8?B?eVJqNWN1NlhpSzdrOWU1c2I4UjlNREJkazluQ0hFNUJNMVg4d2ZCUWR1RjdR?=
 =?utf-8?B?SlpuVUltK0JRTEVIVW9ramVybGpFVVhaWkZmZVVhUHFMUDUvTUI4eSt0TkM2?=
 =?utf-8?B?OVZxUklyNGV6WXJtY2VIVms1aTlVd09PQUl5cFV6dHRGLzk2czJDMk80NEY1?=
 =?utf-8?B?R1A2NTVwRUU0MVBvWnJyQTlVaFhUSUtOK1MrZTF1WGU5Y2lGK0RTR1A2SzJY?=
 =?utf-8?B?WjNLQ0Y1ajRkUXVUK0UveGRmRjFxWFZSaHdhaEVEU1pOTUsxWVk4emNaL0J0?=
 =?utf-8?B?S1dqRk9OWGVIejRYWmhENEU1d1J3MG5RMXdCTHFlVnUwdDhRS1VsNWx2d1Rw?=
 =?utf-8?B?dkxnOGk5Y2U0MGpkWUQvOHdTaERZcmRLazF3RGI2TkpVWVRyVVVVUkR2S3hG?=
 =?utf-8?B?Sk1ZdnB1dUV0WDd1VW1FNlVyTG9SNW13clhpQWlXajZOZDY4aThBSFNGM0dh?=
 =?utf-8?B?QjQ5dCtnckNzVUVlU0l3RkljUVBVRjlLSHJKTTdyZjlWYTV1U1B1bVBwSGxI?=
 =?utf-8?B?MUV4cTJRaFRZbmQ0NlJDZzd2VkpITWhaNDFIQTBGeGZnSERod1F2UXd1aU0x?=
 =?utf-8?B?S09najBKcjVoVi8zdVVia2xaWHZYTWUvaFN4UUxYa0p3aU5iRFI5NHRGM1pJ?=
 =?utf-8?B?SWUwcnRUVExVZXdjeFh5V1ZpR0MzNXltN3g0OElKaHNhU1lOSW9rbmdMb3Q3?=
 =?utf-8?B?cElUOWxCK3hSemw2OW5aaFplY2tOZXgwcVZEcjdBcWwzYk9XREkydXFtU0ZX?=
 =?utf-8?B?VHRoenRuT2ozRGVOeFpPbkg0SEh0aXJhbHJsZzhtYjhHR0xmaFA3d2h1NDRR?=
 =?utf-8?B?elRwNGpRZzdyVUVvbWhtWDJYUGVOeGtaVE56RU5HMnRvZ3kyVjJJTE1PZE9n?=
 =?utf-8?B?RGU3WFBHVElTeE55Zng4SkVwM3hKRUlRRllEaS9mZ21RUWorb2s2Um8yejM0?=
 =?utf-8?B?SkdHaEJLWXdYdzc3Um9yOXZzdHlzdEJselExTTRiNzZzSmE4Q21PbWFZZytN?=
 =?utf-8?B?L0JidGRFYm9tMGRFUXUxZGVXaTJHajFnRUNub2ZlQUI1bVpUYmxQZy9aZkxX?=
 =?utf-8?B?NDdaMUtxb01FVjBYdGN5Z2tTWThVZ2wzVjRuZnFocFVIeXhlYkhDZzRrWVBJ?=
 =?utf-8?B?a1dGbnVaeTVvdytZdUZvdmxsRWJpUTRVUjFPNThCeC9QQTJzM3RkYW50a3hW?=
 =?utf-8?B?d2RkMllRMzZjMEJVWi9YdnFrWEJpMU5GLzNGUXNJSXRGNFVsdXRpWGIwMm9C?=
 =?utf-8?B?cGNLejQxUm5wR0l6YWhNdDhZTVp0cGM2WjFOSGFoNVhIWXNFcVFpb3lCYXM1?=
 =?utf-8?B?dkhmNlUxdVYyV1NsNG5sY1RkVzZxTGFwR3B4dWpDeVAwZFZFTmpVVk00TEpT?=
 =?utf-8?B?cWU5VXhKNTVIYUg5K1FiV3hMaDBla0FwSFJuYkpUd0dzZ0h6YVRpMlZVdHJE?=
 =?utf-8?B?UFlpNHdZbk1OWG9ZcFFkQ3N6NWQ0a3hBdDU4bUNsK0o4R211dXE3R041aHVP?=
 =?utf-8?B?RUc3OFEwZVhDSE4yOGhkekQ1YlpjVlBvcHJkYjVFczcwMklQVERaOFFnTVhZ?=
 =?utf-8?B?MjhsbkxvZ1pQMCtHSnQrdWhNajRTUXNYU0tsYkNHb1IxdDBkUE9kaWlJdUNS?=
 =?utf-8?B?aUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 77fdd307-2379-480d-e29e-08dbdeb15ace
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2023 10:15:51.9989
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EKQMBmCNhf5WcuHsHaNiPwb375nl4IChu/pXJNNJnUXtIgbxq6RgN3pr+Bu5CP05VDxPRiVeB+0YnQHrmh2n9GZ7vq4zyFgxFvzUzrEg3sY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6659
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 06 Nov 2023 02:16:15 -0800 (PST)


On 05.11.2023 10:51, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Analogously to prueth_remove.
> 
> Fixes: 186734c15886 ("net: ti: icssg-prueth: add packet timestamping and ptp support")
> Fixes: 443a2367ba3c ("net: ti: icssg-prueth: am65x SR2.0 add 10M full duplex support")
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
> Changes in v2:
>  - add proper tags
> 
> This was lost from the TI SDK version while ripping out SR1.0 support - 
> which we are currently restoring for upstream.
> 
>  drivers/net/ethernet/ti/icssg/icssg_prueth.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> index 6c4b64227ac8..d119b2bb8158 100644
> --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> @@ -2206,6 +2206,9 @@ static int prueth_probe(struct platform_device *pdev)
>  	if (prueth->pdata.quirk_10m_link_issue)
>  		icss_iep_exit_fw(prueth->iep1);
>  
> +	icss_iep_put(prueth->iep1);
> +	icss_iep_put(prueth->iep0);

We could improve it even more IMO.
If we fail to get prueth->iep0 we go to the free_pool (already done)
If we fail to get prueth->iep1 we should go to something like "put_iep0" which calls icss_iep_put(prueth->iep0);
And in case of exit_iep we can call icss_iep_put(prueth->iep1);

> +
>  free_pool:
>  	gen_pool_free(prueth->sram_pool,
>  		      (unsigned long)prueth->msmcram.va, msmc_ram_size);