Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Mon, 6 Nov 2023 11:32:40 +0100
From:   Maxime Ripard <mripard@kernel.org>
To:     oushixiong <oushixiong@kylinos.cn>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/atomic-helper: Call stall_checks() before allocate
 drm_crtc_commit
Message-ID: <6yqalig6nvnlpt7loetugjdgp5z4w3qwhpqpzzsygffp5w32d6@guq6v3g2z7tq>
References: <20231106073742.158905-1-oushixiong@kylinos.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="bagq6jfn47h4mlnv"
Content-Disposition: inline
In-Reply-To: <20231106073742.158905-1-oushixiong@kylinos.cn>
Precedence: bulk


--bagq6jfn47h4mlnv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Nov 06, 2023 at 03:37:42PM +0800, oushixiong wrote:
> From: Shixiong Ou <oushixiong@kylinos.cn>
>=20
> Calling stall_checks() before allocating drm_crtc_commit not after that.
>=20
> Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn>

Generally speaking, we need much more context than that.

What bug did you encounter that makes you say that it should be moved?
How can we reproduce it? How long has that issue been in the code? What
makes you say that this is the right solution?

Maxime

--bagq6jfn47h4mlnv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZUjAyAAKCRDj7w1vZxhR
xQw6AQClvst8daaSOBV5ptS1/p9TCemvn6ZjiXg0Vqm+6z8yxwD/aAgROmtskcol
T+ZUxPYGekPgmrBGoCVcitgZ3Ztc8Ac=
=ghBa
-----END PGP SIGNATURE-----

--bagq6jfn47h4mlnv--