Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <bf2b6899-fad0-4ac7-a906-e8d361e5a46d@intel.com>
Date:   Mon, 6 Nov 2023 12:18:04 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [alobakin:pfcp 5/20] drivers/iio/imu/adis16475.c:363
 adis16475_set_freq() warn: set_bit() takes a bit number
Content-Language: en-US
To:     =?UTF-8?Q?Nuno_S=C3=A1?= <noname.nuno@gmail.com>,
        Nuno Sa <nuno.sa@analog.com>
CC:     Dan Carpenter <dan.carpenter@linaro.org>,
        <oe-kbuild@lists.linux.dev>, <lkp@intel.com>,
        <oe-kbuild-all@lists.linux.dev>,
        Przemek Kitszel <przemyslaw.kitszel@intel.com>,
        <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <ff4ef031-774e-4e4d-a009-31f242bf6aee@kadam.mountain>
 <5b0f8705-71cb-4c4c-a70c-d9d3a15886cb@intel.com>
 <f040255ef1b3be87050b8255c947b4b375e75a02.camel@gmail.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <f040255ef1b3be87050b8255c947b4b375e75a02.camel@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RmY0SjhPVUxYNDhKZnhxb1MvTitDRmVreERsY0VvejhYWFBMSy9KOExhL2Fy?=
 =?utf-8?B?K0I5c3BXc3BsSUZBeFRwTGpoU0k5ZFVPb0crckFkclo5dkZSWGlBWjNIT3dL?=
 =?utf-8?B?dVJ5TlFMaXloT0JuWC9RRjhlcnFkb2FWbHA3ZTVCRUVkc1FvQ1JmTUFOTmFm?=
 =?utf-8?B?ZEJBZVFiWVBzTC9GR1VRWTNvSCtEOU1Wd2NYeTU5eGsvSFpzbE92bkdDblNU?=
 =?utf-8?B?UTVJTW1kTDRiRlhUcW53L2lZaTJBMGZXcStKWHhGcW9ZV1gxWG9OZU1rL2NU?=
 =?utf-8?B?bDRYT0x0YldqdWUzalFIRlNSaWxJUnNNQ25neG82ZDNzZGFyZWdkdmU0ZDhK?=
 =?utf-8?B?cUhWeDZBc1FlQ1VXWmR1TnE0SlhLU0lkeE9yYm84MlNiRGorQ2VQQURXNjZu?=
 =?utf-8?B?VzV0RHNlZXZNNjFlVnU0Tm5mTlJPYU10OC91cENxd0pUWWJkUkloWkZ3ZVpE?=
 =?utf-8?B?Q04vaTNORytuUFpoTzh4alhCVm55OENYenJQNW1CYW51c1AwOUkyYTFkcFV3?=
 =?utf-8?B?dmltRWNvZWRMVTI2TUZiY0tIYmFaSStTMHl5Q1luaXorS3oyZzBTWDlwa2Nw?=
 =?utf-8?B?MEY5enRoWG44endlTFpSdXRkcWxURWxNcW45eEdJTFVEWE9QWGVyQVhYbmJN?=
 =?utf-8?B?UGFnMlN0d2p6MnEwQmFESlkxT3BFeUxpbU1pQnpibWpURjB0ZFgveThXQjFw?=
 =?utf-8?B?MHNLWW5WWXMvaDBiZmkvZHJ6cmNvck1YNXBxMmxyZjBnN2ZRS0d2Y2FneHJ1?=
 =?utf-8?B?TzdWN3lWamM4VCtYU3BUL1NEeDhyTkh6dUpxdytNOTlQR29iUFQySHRXV2lV?=
 =?utf-8?B?dmhnRWxLN3VOTCtmUFNMdVVLdjRFdWFEbUkxZ1Z2UXh1QWJMQlVMY3k1RkJG?=
 =?utf-8?B?a2FNL1hxekphS2tVVG1vS0dlKzFYYk52NnFJc3pwR3NsY2FCajVjcU96cmZs?=
 =?utf-8?B?R3Bna0ZKM1h4UTNoS0VsSlFvZkxsaGNEZFV4UWVSQkRpSEJlVVVkaFViR1dJ?=
 =?utf-8?B?bnBIdG5neWtHcXJEMHVjSVNQLzZ4VnNIdkVyR01LZUJzNDV2dkN6Yzh5ZlJI?=
 =?utf-8?B?eGNFOWdEYkZJbEVlSXNqVEg1QVcyNUNseGVja1IvcE44MXptb0dGQzFldGxq?=
 =?utf-8?B?TEJYcldCSjFwVEtrN2xRckRYakJ0bjB4VWRBZ1JYSzd0WFZ4czBIUFMwQ3NT?=
 =?utf-8?B?MVg0VVRRUEFJMnJQT1RuMzRnZTBNT0QzZ3praUE3NmdJenJGdU12QkNmVlZv?=
 =?utf-8?B?YkhZcGxlNk05MHB5REVneE5xWEFsbjJ4enFuZXZRU1ByWG1rcnRHSkdZWEVi?=
 =?utf-8?B?K3pQVE8xT0hVUDhoWjlvU3FNREpSRURWQk50dFNSb0JVNVorZjg3TW1OZXkw?=
 =?utf-8?B?UzczZksrdXEvcWlQcXcvaWZ5M2lUaC8rUjFrTTQrZlE1U0tQa2dJcDcxRlcr?=
 =?utf-8?B?bzdZTzVDWEMzQVl1MVIrakZ3MlBwVVJpeVZSeVVmbHdjZS9oYnZDNVNDaUxU?=
 =?utf-8?B?SWdiQTNmUFdVcG1qSDd0c3pqR0dKVXBwMStjSnp2RVhCVFIyWmhtQUFDdG02?=
 =?utf-8?B?UCsyUFcyVTN6bVZHYlN4SFJ2SmlIK0kvaFUzeW9oa1FYdUZJc01IalRSRXk0?=
 =?utf-8?B?dU5hRVRieExmMjN3OWVBM2hOZ2lpR1NyeFZHN0Nwa2VRaVJ3TkpOMWJ5ams0?=
 =?utf-8?B?UjBxMEhjdEdTWHhIK0d2TlZ1Vjk0TkNmeFE1bGRZMCtnYlpoWnhWRFpXeWg2?=
 =?utf-8?B?dHIzMnByU3A0NU8rVmdxMmdCRWhPdkpSanloSHFnTlpLZldZYUc0QVFuazRy?=
 =?utf-8?B?bldHQjE5WFNOdzFNQlc4bGFJYVdveGFSNWVNdGg5YU5GWEFSKzN4Y0IwOXdH?=
 =?utf-8?B?VlRiS0I4ZitIUmVxMDJ2S1lOWElleElHWEt3TkxFSzMyVXhnNTJCQXhPUjdX?=
 =?utf-8?B?T0UzdDFIWGVTTy9lT3YzbjYxdUlmWTBma3AveHdTK3E3dGU3UnN6Q09WUkcy?=
 =?utf-8?B?a2N5bmVrUW1nRnBwY3ZaSWRRQnVKbGhnYkF6NHU2Y1Fxai9FMzBaeHUyWlhS?=
 =?utf-8?B?N21uL1JqVURJR2l5emRoSXFYQlp3SUlxQkEyNjhuK1VTdzB6OUoreEk5Z2xY?=
 =?utf-8?B?U3ZiSDhEZytDK25oVitnMXVmVE1uN213bUx5RkFXYllNdTUyalhlZEMzQUs0?=
 =?utf-8?B?MlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: aa6fafb1-8e70-4921-fea4-08dbdeba5bc3
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2023 11:20:19.4549
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c7OJU+4lz+iif2y5/+NCaIGNoL3gXyVa7KMRwq5jlqXSpoKZW3PuiBgojnGUxBQgrg6NqCNvEa8AvuCcNtU+XvXJucoeWQVvRMY5rxGrAOg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8749
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 06 Nov 2023 03:20:47 -0800 (PST)

From: Nuno Sá <noname.nuno@gmail.com>
Date: Mon, 06 Nov 2023 11:07:16 +0100

> Hi Olek,
> 
> On Mon, 2023-11-06 at 10:31 +0100, Alexander Lobakin wrote:
>> From: Dan Carpenter <dan.carpenter@linaro.org>
>> Date: Mon, 6 Nov 2023 11:50:03 +0300
>>
>> Hi,
>>
>>> tree:   https://github.com/alobakin/linux pfcp
>>> head:   89565e300e3d4033b8bb568774804fdc09d4f3cc
>>> commit: 945a0d6e86d97bf60f2fae88ee557ed3eae18b94 [5/20] bitops: let the compiler
>>> optimize {__,}assign_bit()
>>> config: i386-randconfig-141-20231105
>>> (https://download.01.org/0day-ci/archive/20231106/202311060647.i9XyO4ej-lkp@intel
>>> .com/config)
>>> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
>>> reproduce:
>>> (https://download.01.org/0day-ci/archive/20231106/202311060647.i9XyO4ej-lkp@intel
>>> .com/reproduce)
>>>
>>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>>> the same patch/commit), kindly add following tags
>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
>>>> Closes: https://lore.kernel.org/r/202311060647.i9XyO4ej-lkp@intel.com/
>>>
>>> smatch warnings:
>>> drivers/iio/imu/adis16475.c:363 adis16475_set_freq() warn: set_bit() takes a bit
>>> number
>>> drivers/iio/imu/adis16475.c:363 adis16475_set_freq() warn: clear_bit() takes a
>>> bit number
>>> drivers/iio/imu/adis16475.c:416 adis16475_set_filter() warn: set_bit() takes a
>>> bit number
>>> drivers/iio/imu/adis16475.c:416 adis16475_set_filter() warn: clear_bit() takes a
>>> bit number
>>>
>>> vim +363 drivers/iio/imu/adis16475.c
>>>
>>> fff7352bf7a3ce Nuno Sá 2020-04-13  357  
>>> 9da1b86865ab43 Nuno Sá 2021-09-20  358          adis_dev_unlock(&st->adis);
>>> fff7352bf7a3ce Nuno Sá 2020-04-13  359          /*
>>> fff7352bf7a3ce Nuno Sá 2020-04-13  360           * If decimation is used, then
>>> gyro and accel data will have meaningful
>>> fff7352bf7a3ce Nuno Sá 2020-04-13  361           * bits on the LSB registers.
>>> This info is used on the trigger handler.
>>> fff7352bf7a3ce Nuno Sá 2020-04-13  362           */
>>> fff7352bf7a3ce Nuno Sá 2020-04-13
>>> @363          assign_bit(ADIS16475_LSB_DEC_MASK, &st->lsb_flag, dec);
>>>
>>> assign_bit() takes a bit number like 0.  But this is passing BIT(0) so
>>> it's like BIT(BIT(0)).  Which is fine until you get to 5.
>>
>> Is this intended? There are 2 places where you pass
>> %ADIS16475_LSB_DEC_MASK and %ADIS16475_LSB_FIR_MASK, which is `BIT(0)`
>> and `BIT(1)` respectively, to assign_bit(), which takes 0, 1 etc.
>>
> 
> Sorry, I'm missing the point in here... This should be a simple mask as 
> GENMASK(1, 0) setting/clearing the bits when appropriate. Obviously,

assign_bit() does not take a bitmask as a first argument, but a bit number.

I.e. if you want to switch BIT(0), you call it like assign_bit(0, ...),
not assign_bit(BIT(0), ...). Same for the bit nr 1.

I can make and send a quick fix if you prefer.


> ADIS16475_LSB_DEC_MASK and ADIS16475_LSB_FIR_MASK are not properly defined
> :sweat_smile:
> 
> - Nuno Sá
>>
>>>
> 

Thanks,
Olek