Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Mon, 6 Nov 2023 20:19:08 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Regressions <regressions@lists.linux.dev>,
        Linux LEDs <linux-leds@vger.kernel.org>
Cc:     Tim Crawford <tcrawford@system76.com>,
        Jeremy Soller <jeremy@system76.com>,
        System76 Product Development <productdev@system76.com>,
        Lee Jones <lee@kernel.org>, Pavel Machek <pavel@ucw.cz>,
        Johannes =?utf-8?Q?Pen=C3=9Fel?= <johannes.penssel@gmail.com>
Subject: Re: Fwd: sysfs: cannot create duplicate filename
 .../system76_acpi::kbd_backlight/color
Message-ID: <ZUjnzB2RL2iLzIQG@debian.me>
References: <b5646db3-acff-45aa-baef-df3f660486fb@gmail.com>
 <ZT25-gUmLl8MPk93@debian.me>
 <dc6264c4-d551-4913-a51b-72c22217f15a@traphandler.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="mLSYxFe79vSgKXQn"
Content-Disposition: inline
In-Reply-To: <dc6264c4-d551-4913-a51b-72c22217f15a@traphandler.com>
Precedence: bulk


--mLSYxFe79vSgKXQn
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Nov 04, 2023 at 01:01:56PM +0100, Jean-Jacques Hiblot wrote:
>=20
>=20
> On 29/10/2023 02:48, Bagas Sanjaya wrote:
> > On Thu, Oct 26, 2023 at 02:55:06PM +0700, Bagas Sanjaya wrote:
> > > The culprit seems to be commit c7d80059b086c4986cd994a1973ec7a5d75f8e=
ea, which introduces a new 'color' attribute for led sysfs class devices. T=
he problem is that the system76-acpi platform driver tries to create the ex=
act same sysfs attribute itself for the system76_acpi::kbd_backlight device=
, leading to the conflict. For testing purposes, I've just rebuilt the kern=
el with the system76-apci color attribute renamed to kb_color, and that fix=
es the issue.
> >=20
> > Jean-Jacques Hiblot, would you like to take a look on this regression,
> > since you authored the culprit?
> Hi,
>=20
> The offending commit stores the color in struct led_classdev and exposes =
it
> via sysfs. It was part of a series that create a RGB leds from multiple
> single-color LEDs. for this series, we need the color information but we
> don't really need to expose it it via sysfs. In order to fix the issue, we
> can remove the 'color' attribute from the sysfs.
>=20

OK, see you in the patch!

--=20
An old man doll... just what I always wanted! - Clara

--mLSYxFe79vSgKXQn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZUjnyAAKCRD2uYlJVVFO
o00MAP46Ar3NgVvRankXk1V4h3zoLCr89KoQ1Lfibtd5doJaUQD/cn2uxDs4aSlz
/9jB4eJEcHBWxonDhaWcpvJGoxYoRgw=
=lEvF
-----END PGP SIGNATURE-----

--mLSYxFe79vSgKXQn--