Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp2120508rdf; Mon, 6 Nov 2023 05:26:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IE1qmS2zP1dZzINqIfUXrTJglB+oMMv/5yDjpnq2LVH9/Y10OS+f+UdGSxR7I9SMQJDtOK0 X-Received: by 2002:a05:6a20:7d88:b0:16b:8067:23a7 with SMTP id v8-20020a056a207d8800b0016b806723a7mr37795105pzj.24.1699277212258; Mon, 06 Nov 2023 05:26:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699277212; cv=none; d=google.com; s=arc-20160816; b=Vp8CnD3lKQSuZFGT4Bfy2UGM4TiwaCFYH8sE53QRXhw4txxmB/kVhQ98E8oravDSQn MedC9pQjCAuIcxEchly3Hv63lnHPVROzeMJt0jfyibnaehPfVhsKrRnLkANU8rl67Sdr F1vYqzPL4hm7Jc0ZOmovjKD2HV2hYFqg+IaesVKwkRXjF0uVEbAWibxzpgaA3Djma/Wh lG4ONp4f+l0gzdIfBnfH5mWAMOfAXMsXQsPyQqSQJ0tKq57iwPbHQYPEf8JpSEqchZqt 2OYzmTYUwhv0B9N4jRhledhjuiskuMsNHViv7SbebMg58MIsy3VSw4NKG1EZ/nUOH3Jg YZJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:thread-index :content-transfer-encoding:mime-version:message-id:date:subject :in-reply-to:references:cc:to:from; bh=CZeYswN6e79YP10moFvhwkhS+Kj7AQnoUjiDJYc/5Y0=; fh=Dbr+YQLIi4XHF42aZmdOVoO9NhVhPqiB+EvtUEAgiSw=; b=rIr4tXmAHUBLA+Y07zsE5XtTIlmpbnktCgJqZEvMuEZKCzaO+iWWfStwVXMUBBotkA wAs5lpvdxff1axY+fH6PixKzeLW6L7VygWWI0X86EblrVSEYLhiLVImyfDU9X/jj+iBz BH4i2gGe2fp+ff4vtpnu+Vimef/6q/usfFZ7O3n4xq5GKJTI1X7o13L/Oz03ZKykd0Rw SiRmh7Nckz+NwqyFhscBC3xGZrt30dH9y9sCG5aPF5ZZ28JzqSJWXZP6I+n52VzugoYD uwr2hMLzlK6hr2byb0OPWYhqj4ZmmPes2URR5Z7iT2+GAwsTBumPucKiziht8yVUHtpp qTgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id y4-20020a056a001c8400b006bd78b99aa5si8182643pfw.334.2023.11.06.05.26.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 05:26:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 349578028A74; Mon, 6 Nov 2023 05:26:51 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232586AbjKFN0m convert rfc822-to-8bit (ORCPT + 99 others); Mon, 6 Nov 2023 08:26:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232565AbjKFN0j (ORCPT ); Mon, 6 Nov 2023 08:26:39 -0500 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 415C9112 for ; Mon, 6 Nov 2023 05:26:33 -0800 (PST) X-UUID: 68c1e78aac2d4c9eae9324cf631b5914-20231106 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.32,REQID:3237dc1b-63d0-413f-8adf-db743d8e797b,IP:10, URL:0,TC:0,Content:10,EDM:0,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:15 X-CID-INFO: VERSION:1.1.32,REQID:3237dc1b-63d0-413f-8adf-db743d8e797b,IP:10,UR L:0,TC:0,Content:10,EDM:0,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:15 X-CID-META: VersionHash:5f78ec9,CLOUDID:179d35fc-4a48-46e2-b946-12f04f20af8c,B ulkID:231106212621OQUAH2A4,BulkQuantity:0,Recheck:0,SF:66|23|17|19|43|64|1 02,TC:nil,Content:4,EDM:-3,IP:-2,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,CO L:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD X-UUID: 68c1e78aac2d4c9eae9324cf631b5914-20231106 X-User: oushixiong@kylinos.cn Received: from laptopjrnhc6sg [(222.247.111.235)] by mailgw (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 288226259; Mon, 06 Nov 2023 21:26:20 +0800 From: To: "'Maxime Ripard'" Cc: "'Maarten Lankhorst'" , "'Thomas Zimmermann'" , "'David Airlie'" , "'Daniel Vetter'" , , References: <20231106073742.158905-1-oushixiong@kylinos.cn> <6yqalig6nvnlpt7loetugjdgp5z4w3qwhpqpzzsygffp5w32d6@guq6v3g2z7tq> In-Reply-To: <6yqalig6nvnlpt7loetugjdgp5z4w3qwhpqpzzsygffp5w32d6@guq6v3g2z7tq> Subject: =?gb2312?B?u9i4tDogW1BBVENIXSBkcm0vYXRvbWljLWhlbHBlcjogQ2FsbCBzdA==?= =?gb2312?B?YWxsX2NoZWNrcygpIGJlZm9yZSBhbGxvY2F0ZSBkcm1fY3J0Y19jb21taXQ=?= Date: Mon, 6 Nov 2023 21:26:15 +0800 Message-ID: <000301da10b4$d4e90690$7ebb13b0$@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: 8BIT X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFcR3YQO3CUUdc1Zt+jjVoM53ycrQINT5JbsVhur6A= Content-Language: zh-cn X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 06 Nov 2023 05:26:51 -0800 (PST) Hi, I think it will cause memory leaks if too many nonblock commit works return -EBUSY. You can try to send large number of nonblock commits by drmModeAtomicCommit(). -----?ʼ?ԭ??----- ??????: Maxime Ripard ????ʱ??: 2023??11??6?? 18:33 ?ռ???: oushixiong ????: Maarten Lankhorst ; Thomas Zimmermann ; David Airlie ; Daniel Vetter ; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org ????: Re: [PATCH] drm/atomic-helper: Call stall_checks() before allocate drm_crtc_commit Hi, On Mon, Nov 06, 2023 at 03:37:42PM +0800, oushixiong wrote: > From: Shixiong Ou > > Calling stall_checks() before allocating drm_crtc_commit not after that. > > Signed-off-by: Shixiong Ou Generally speaking, we need much more context than that. What bug did you encounter that makes you say that it should be moved? How can we reproduce it? How long has that issue been in the code? What makes you say that this is the right solution? Maxime