Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <41eff9b4-3041-4a1e-ba28-b16d866cd894@intel.com>
Date:   Mon, 6 Nov 2023 14:39:48 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [alobakin:pfcp 5/20] drivers/iio/imu/adis16475.c:363
 adis16475_set_freq() warn: set_bit() takes a bit number
Content-Language: en-US
To:     =?UTF-8?Q?Nuno_S=C3=A1?= <noname.nuno@gmail.com>,
        Nuno Sa <nuno.sa@analog.com>
CC:     Dan Carpenter <dan.carpenter@linaro.org>,
        <oe-kbuild@lists.linux.dev>, <lkp@intel.com>,
        <oe-kbuild-all@lists.linux.dev>,
        Przemek Kitszel <przemyslaw.kitszel@intel.com>,
        <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <ff4ef031-774e-4e4d-a009-31f242bf6aee@kadam.mountain>
 <5b0f8705-71cb-4c4c-a70c-d9d3a15886cb@intel.com>
 <f040255ef1b3be87050b8255c947b4b375e75a02.camel@gmail.com>
 <bf2b6899-fad0-4ac7-a906-e8d361e5a46d@intel.com>
 <e29dc510c78205d87b573e0fe185dc7c7d509310.camel@gmail.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <e29dc510c78205d87b573e0fe185dc7c7d509310.camel@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cHFvZXE2M0Z4RDJrN2RVNUZCL09ZQTdNTi81R1V6VEt4aUNqZE1GK1F4Tlkr?=
 =?utf-8?B?UzBpZExzR3BaU1pUYit4VkNhVTNZZHJlTDhxOSt0bHVUNzhCL2d0WlhFS3h1?=
 =?utf-8?B?alRSSFVYV2VET09MUlREaldneFRCclVPREc1M3dtMlNyK09oWHQwc3F2cmNh?=
 =?utf-8?B?WmVNTTJTcFRhellMMk13STllNDZ5bVJhY1p4OU5uTDZEK2Nta05LVGdBUnc4?=
 =?utf-8?B?MGdSM2JHRmR2QjlkMDBLUXlZWFplVjk3YzVYd2c0V1JpVlFlTmF0RDlEVENv?=
 =?utf-8?B?cjVHWGpRYXpQY2orN0xLaG1SRkNLRWM5ZEJJRk9rditTenNtZmRld3pNand5?=
 =?utf-8?B?c1NWVnZvejBCdDVHMlRZRUxPRmdJZTlqOVEzMGppUHBxZ3FRc25NMWp1MUpn?=
 =?utf-8?B?K0Y5U1RjUmdmeHdJSWxlTjVycGhLVGRCVFU1SlVKQ00yTXhvWnFFRjRJQU5q?=
 =?utf-8?B?Y1BRdDNDM2Q4SmRld2FwZTZoM2MraGVleGNFQldKemlzb083M01Ld3EzK0VX?=
 =?utf-8?B?YXZhdWJUVWZ1MmJVS3IrK0lYMnlSdVBpb2Z1SkFBU3VoUGZrc3Y0WW5yT0pM?=
 =?utf-8?B?MGZ1V2thRFJEYlo0QnBLZGpXQjh1Y04xTmJsQzZCTVZDT05uR1QwekZhV0ZE?=
 =?utf-8?B?QkZ2UkJKa2JteDg5R09XRE5SNXBtaXZOV2VFWmlQRXR0cVc0S1FhWXI0N3hX?=
 =?utf-8?B?THZ0YWxObFowZkpZcHY4V2lpaWkzTGdzSWxSSWJsZERuckVZUFR4MUdwRVJy?=
 =?utf-8?B?WUE2bFlETjFuUkRKRVpEaWtuUEthdWNLUUg4YVo3V0I0MjlpVTBjVGxqTFh3?=
 =?utf-8?B?UDR1VmdWSHZXK1Q1MG9wSXpxVnRJVTBnZTR3QnQyMy9OQ1NyN0VObWFkYXQx?=
 =?utf-8?B?RXFPWGFsa2d6NjJ4NSsyQnBXSkN0TndPVEdDV2Fra0l2Nm93ek5Oblk0cFVs?=
 =?utf-8?B?T1NzMHZnUEtsYUhTSlFhTGN2Ylgxc2dsQXJlN0g4SkR0Mng2N2VjMmZDVzVU?=
 =?utf-8?B?UmxXdlZxSEplRk9VNittdmh3eDBzQ0FsMWJMdVFoOStYdVp0MHBGMEdUeGNl?=
 =?utf-8?B?WXI5WE1pU20rRlpzZVdKQXFuSjE2M2tLZkp3NFhFTVFMNmU0VUVEZHB0OHh2?=
 =?utf-8?B?c1dhejhMMTFxVGxPMUNGRStBRlF5T3hJeXhseVFwQ1JhbGx6QnZoeklrM1Nq?=
 =?utf-8?B?dXhTa09jTlArK0JFQ3R2aWlnb2Z6cXBpYTloYUFHRlQvTEhlRnk1bWNUV2pp?=
 =?utf-8?B?M2ozVGRXd01mZERDRlZZaE9rOG9USVhMaFNEZ2QxRTN3RG5WbFZMdE5UeHZP?=
 =?utf-8?B?cDRKUjUwL3loeHRvYURwQnVCZTJqeDhmZ0FlS1ZtNGkrMWJBQWgvdjZ3bFNu?=
 =?utf-8?B?YVBkQWN6bG1hUDFPV3FlblZRaHNqSHkwRmo0YWQrK3B3VkFUaVRBSlIrTEUx?=
 =?utf-8?B?VElQNnh1blBLbFJCT05LdzU0MHdLTHZ1dkt1SU9zQk1wVW1XTDJaL0x4U1lx?=
 =?utf-8?B?R3BTU2xvVVVrMHJISVVCT3dYamF2QUxmTjBaRGhMMklubVVmdnBQOUYvTVR3?=
 =?utf-8?B?R0MvYk4xajk1OG9ESEd1NTRBNzVBVGtGZ2hrcGdCRGVrNlcyN0kyYTlDZWJl?=
 =?utf-8?B?VzBKNFJtMnJ3T1JoUDdOK1pqWHFBMzdDL2Jyb3ZWMDQweHIyNk05ejZJUG83?=
 =?utf-8?B?QTlLQkpnaTBrb1lHMnhyL3ZRWVFxQ3VwN3U3U0lZVWFkdmtxVSt2TUlSTVZF?=
 =?utf-8?B?d2pRRmhDb09RYTV6dXBDbi9yNy96M0VpWVQvd3pZZlNZMlYwdGlwS1hkYlFr?=
 =?utf-8?B?dGljTUxZbTNldWMvQ2UyUW4zY2NLbXF4YTRZWGtNd2d4YWdza1lySEYxV2tx?=
 =?utf-8?B?VGF3QTFyVVlQeDJyb2wzNHNUMUxQWnUzS2NEL1dqUmF5RTJXQjRhajJsWW9I?=
 =?utf-8?B?NWo2NmJEUE9TdGg3NkU0L0svT3ZQeDZWMElpMGZiUGFnSEY4S0ZQR0cwd2VP?=
 =?utf-8?B?NjEvejFldWJpakh6YkJMdDVxS3I3NkZNRkFTbmNFbk9VWmJFaHY3ci9pWVVl?=
 =?utf-8?B?emJDOERBVFd1empYb1F2Yy96d2VYanlxdGt6R0R0b1cxczFjdVc0QmFnZm5V?=
 =?utf-8?B?ZEhIYmx5TnFXVDZ5NlY3SFpPY3RYRWdwcnFvK0VFaW83SUQzVW85TnBQMzhq?=
 =?utf-8?B?Vmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5560e23f-f5ad-4e32-babf-08dbdece28b4
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2023 13:42:03.7196
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6lJ9Tm4ZFEK+zQWsZYtgzLLJFOrofj8QVU1jo0pxy7A6vqAhOQc0QrOV+OPbNfnlRHBSrwn9t1c+tH/1rJRj0FSrPiYYSMwD9Tom+eRRCFc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6067
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 06 Nov 2023 05:42:25 -0800 (PST)

From: Nuno Sá <noname.nuno@gmail.com>
Date: Mon, 06 Nov 2023 13:02:58 +0100

> On Mon, 2023-11-06 at 12:18 +0100, Alexander Lobakin wrote:
>> From: Nuno Sá <noname.nuno@gmail.com>
>> Date: Mon, 06 Nov 2023 11:07:16 +0100

[...]

>> assign_bit() does not take a bitmask as a first argument, but a bit number.
>>
>> I.e. if you want to switch BIT(0), you call it like assign_bit(0, ...),
>> not assign_bit(BIT(0), ...). Same for the bit nr 1.
>>
> 
> Yes, I know... if you look at my reply to Dan you can see I realized that already :) 

Oh okay :)

> 
> I guess by the time I first sent this time I didn't knew or maybe just a dumb
> mistake...
> 
> I'll send a patch later today removing the BIT() from the #define, thx!

Nice! Don't forget the tags the build bot asked for :p

BTW, I believe the reason why this warning triggered after my commit is
that before it, assign_bit() is a static inline, but becomes a macro
then. smatch becomes able to see through it that it indeed is a wrapper
around set_bit()/clear_bit() and realizes the first argument is invalid.

> 
> - Nuno Sá
> 

Thanks,
Olek