Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Mon, 6 Nov 2023 15:19:22 +0100
From:   Johan Hovold <johan@kernel.org>
To:     Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc:     linux-renesas-soc@vger.kernel.org,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] gnss: ubx: add support for the reset gpio
Message-ID: <ZUj16pzYG_6WR5Jc@hovoldconsulting.com>
References: <20230921133202.5828-1-wsa+renesas@sang-engineering.com>
 <20230921133202.5828-4-wsa+renesas@sang-engineering.com>
 <ZS1AxSRL4F5WBvnC@hovoldconsulting.com>
 <ZTYcD8l+lUlLog91@ninjato>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="2TOfkmwbPXlIz3N9"
Content-Disposition: inline
In-Reply-To: <ZTYcD8l+lUlLog91@ninjato>
Precedence: bulk


--2TOfkmwbPXlIz3N9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 23, 2023 at 09:09:03AM +0200, Wolfram Sang wrote:
> > So this means that the reset line will be asserted indefinitely in case
> > the GNSS receiver is not used. Are you sure that's a good idea?
>=20
> Yup. Saves power. We do this for our ethernet PHYs as well. Any reasons
> not to do this?

AFAIK you should generally not try to use reset this way as you may end
up leaking current (and possibly other complications).
=20
> > I don't know yet which module this is for, or how this signal is
> > supposed to be used, but the above makes this look more like an
> > active-high (regulator) enable signal. Perhaps that's what it is or
> > should be modelled as (i.e. as a fixed regulator).
>=20
> Nope, it is a RESET_N pin.

And the neo-m8 hardware integration manual explicitly says that it shall
not be used as a disable signal:

	1.5 I/O pins
	RESET_N: Reset input
	Driving RESET_N low activates a hardware reset of the system.
	Use this pin only to reset the module. Do not use RESET_N to
	turn the module on and off, since the reset state increases
	power consumption.

Some of the other modules in this family says so explicitly also in the
datasheet.

Johan

--2TOfkmwbPXlIz3N9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQQHbPq+cpGvN/peuzMLxc3C7H1lCAUCZUj15gAKCRALxc3C7H1l
CJIwAQCUyRJ2dOra5odtunrzTEfmSEGT8aqQKG1u1/YOvdgjWgD/d4i5DubnOWFW
dGzRIgQl92TRBa3jBbCYWLFr0uqHdQ0=
=Z+gS
-----END PGP SIGNATURE-----

--2TOfkmwbPXlIz3N9--