Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Mon, 6 Nov 2023 15:49:14 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Florian Eckert <fe@dev.tdt.de>
Cc:     Eckert.Florian@googlemail.com, pavel@ucw.cz, lee@kernel.org,
        kabel@kernel.org, gregkh@linuxfoundation.org,
        linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Subject: Re: [Patch v2] leds: ledtrig-tty: free allocated ttyname buffer on
 deactivate
Message-ID: <20231106144914.bflq2jxejdxs6zjb@pengutronix.de>
References: <20231106141205.3376954-1-fe@dev.tdt.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cuxqxbsy7asbpnbl"
Content-Disposition: inline
In-Reply-To: <20231106141205.3376954-1-fe@dev.tdt.de>
Precedence: bulk


--cuxqxbsy7asbpnbl
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 06, 2023 at 03:12:05PM +0100, Florian Eckert wrote:
> The ttyname buffer for the ledtrig_tty_data struct is allocated in the
> sysfs ttyname_store() function. This buffer must be released on trigger
> deactivation. This was missing and is thus a memory leak.
>=20
> While we are at it, the tty handler in the ledtrig_tty_data struct should
> also be returned in case of the trigger deactivation call.
>=20
> Cc: stable@vger.kernel.org
> Fixes: fd4a641ac88f ("leds: trigger: implement a tty trigger")
> Signed-off-by: Florian Eckert <fe@dev.tdt.de>

I already provided that to v1, but my reply and the v2 crossed, so I'm
forwarding my tag to this v2:

Reviewed-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--cuxqxbsy7asbpnbl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmVI/OkACgkQj4D7WH0S
/k4dugf/d+mVIkYj3WhRH5DuFSBGNO7Oni01gKNpAmSw1/lhYmVAd5l39RU1n6qR
L4AKALqT+nNBFdeZcSGfPcNMMxZKNE56Np45S/4KwBk71D6l/CsYqqgk/wJhMfhP
Tfu3gBrTlSjyWvtWO8llhJHRuEZf1LpfCNA1hMjtzyZuv4LHlugp3C4/fb3QvE6j
MqyK4LudbsPFaqod7+IhW9S0+mKHwDTwCgPHsTc8IUUFSpq/XR0sAe5Jp16BXm7g
V4JSyz5MzddPiPRVjFFlTb9NfmNVfaAcBJ8l1Lx45dQpmkqrOUedd+68luvewdYY
Y/8+E4Ilcqp6JfHbi00jO9jsH95paQ==
=Oo3i
-----END PGP SIGNATURE-----

--cuxqxbsy7asbpnbl--