Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp2180330rdf; Mon, 6 Nov 2023 07:02:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IHmxvtgzk3BWLhqNQQmpmX0Bqebx8tpL2AM1onrYuB6QdqL2oVDudzWPg/I/ruqpTS5VXmq X-Received: by 2002:a05:690c:fd4:b0:5a7:ab45:539d with SMTP id dg20-20020a05690c0fd400b005a7ab45539dmr12864687ywb.2.1699282932225; Mon, 06 Nov 2023 07:02:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699282932; cv=none; d=google.com; s=arc-20160816; b=o1Xk4N0lO3KWmhHzpx247/FXO+xF/XXbPLHklkAc7R8K5VEbKApgYNMaxCXfqz32P8 b5cRSgjMACsqCgZpNlxg+Ihu/hLTf5xaq/9Psdc8P5anukSfADFtf/P3/qoSDVrM1uVG MtlXZ8zyefh9K+zhhV2M4I/0V+jj99R42UqfOumZswLL+fr+qAdRwzu/JzDflRJSU8tB NgEbJcAAm1iXqMGQtC9q6dIWPoSMcsTTBoxfnR7djtr1eUnMtvRIQhTkwJ9Fa9cpOLRu hf9VwVolfx63CdrJIa4cZkXCJQwxVQpCXY78Uh6Ex26IEa+0gXNWzwO7pu9nsRgpIFKx 5QOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=b7iXtTXs5x3zBQ50r/ONsfKnmqQOIxW29Dm5vzOyD/Y=; fh=gYrCt47V3CbCb62RPmeRmK/9xhaALdBdTYp7ZhBoVH4=; b=IdHTI6qECo0w65L4V1UI09W23BVtO8ezS7kM1RQA83rTmx0hDaSySskKLr4p+kElze 780UArb8KkDvI7OZwfNrP4mK55df0RoqBcmQNI2ufjPBI93KSPa28djjmfjQH/INdMPu MX8hzLAAubNEQrxsuFAHyp3nCcYDIT+VmlEiBZmVT7hRUaP46x0M/CgyT1b1y4CmYNM/ wymqvuIM64WD1rB4Hwz0a8oqG67SCcDGAYxLu6fn3Zuqz1tR5ByaXJapYPFOGo8ph04/ hCyTwqlulKdgGnhkS58ctS2yHdr3ZNZdan0fg0j70/QAPryZuBJz9wyuCzMh+VrhfJik oibg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ve0HWqsY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id b129-20020a0dc087000000b005a7be4964ebsi5003158ywd.77.2023.11.06.07.02.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 07:02:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ve0HWqsY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id AD7098026ADB; Mon, 6 Nov 2023 07:01:14 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232329AbjKFPA5 (ORCPT + 99 others); Mon, 6 Nov 2023 10:00:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231920AbjKFPAe (ORCPT ); Mon, 6 Nov 2023 10:00:34 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62EDD112 for ; Mon, 6 Nov 2023 07:00:31 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPS id 587C3C433AB; Mon, 6 Nov 2023 15:00:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699282829; bh=ECVz3lGtxGBADvHCPjD3ljOMk1SrC44aHNctP69FqWA=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=Ve0HWqsYZ7iBWx1g4i9SnchJy7OTfFLp4Q+idNXNM6rEFU9GScI8crupJ6pg61cGY rx3MKzC+p0hXHS4POrC45Ywjlx4mRdUxKcwNqOG4jbMi26LR+Vd/oEKaQg9X5YEaHH bFnJdDYqDKL60+9RECyLH4Hnopwio4tTRSX5lfTXib9P4ORNUhV/8zQFP6vT2xX1BG sNflCSWy2/VoNneUMpcJ1FL3a25Ptq/5RJoiEOVTRtxwWVXqo+MzgG76yvY3VVQkHX wLRGGhiJVp+rBBCtu4LkkuP1evMYodX9As2jk3pEXuKjn368w12BXvBx5w7/S3ens2 lP2qltjeez4Aw== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 3A455E0009D; Mon, 6 Nov 2023 15:00:29 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2] riscv: provide riscv-specific is_trap_insn() From: patchwork-bot+linux-riscv@kernel.org Message-Id: <169928282923.16503.13448855296252108096.git-patchwork-notify@kernel.org> Date: Mon, 06 Nov 2023 15:00:29 +0000 References: <20230829083614.117748-1-namcaov@gmail.com> In-Reply-To: <20230829083614.117748-1-namcaov@gmail.com> To: Nam Cao Cc: linux-riscv@lists.infradead.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, linux-kernel@vger.kernel.org, bjorn@kernel.org, guoren@kernel.org, conor.dooley@microchip.com, bjorn@rivosinc.com X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 06 Nov 2023 07:01:15 -0800 (PST) Hello: This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt : On Tue, 29 Aug 2023 10:36:15 +0200 you wrote: > uprobes expects is_trap_insn() to return true for any trap instructions, > not just the one used for installing uprobe. The current default > implementation only returns true for 16-bit c.ebreak if C extension is > enabled. This can confuse uprobes if a 32-bit ebreak generates a trap > exception from userspace: uprobes asks is_trap_insn() who says there is no > trap, so uprobes assume a probe was there before but has been removed, and > return to the trap instruction. This causes an infinite loop of entering > and exiting trap handler. > > [...] Here is the summary with links: - [v2] riscv: provide riscv-specific is_trap_insn() https://git.kernel.org/riscv/c/b701f9e726f0 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html