Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <8371368263aea64bc0f635f723cb6ca9d0176dea.camel@gmail.com>
Subject: Re: [alobakin:pfcp 5/20] drivers/iio/imu/adis16475.c:363
 adis16475_set_freq() warn: set_bit() takes a bit number
From:   Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To:     Alexander Lobakin <aleksander.lobakin@intel.com>,
        Nuno Sa <nuno.sa@analog.com>
Cc:     Dan Carpenter <dan.carpenter@linaro.org>,
        oe-kbuild@lists.linux.dev, lkp@intel.com,
        oe-kbuild-all@lists.linux.dev,
        Przemek Kitszel <przemyslaw.kitszel@intel.com>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Mon, 06 Nov 2023 16:16:09 +0100
In-Reply-To: <41eff9b4-3041-4a1e-ba28-b16d866cd894@intel.com>
References: <ff4ef031-774e-4e4d-a009-31f242bf6aee@kadam.mountain>
         <5b0f8705-71cb-4c4c-a70c-d9d3a15886cb@intel.com>
         <f040255ef1b3be87050b8255c947b4b375e75a02.camel@gmail.com>
         <bf2b6899-fad0-4ac7-a906-e8d361e5a46d@intel.com>
         <e29dc510c78205d87b573e0fe185dc7c7d509310.camel@gmail.com>
         <41eff9b4-3041-4a1e-ba28-b16d866cd894@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-11-06 at 14:39 +0100, Alexander Lobakin wrote:
> From: Nuno S=C3=A1 <noname.nuno@gmail.com>
> Date: Mon, 06 Nov 2023 13:02:58 +0100
>=20
> > On Mon, 2023-11-06 at 12:18 +0100, Alexander Lobakin wrote:
> > > From: Nuno S=C3=A1 <noname.nuno@gmail.com>
> > > Date: Mon, 06 Nov 2023 11:07:16 +0100
>=20
> [...]
>=20
> > > assign_bit() does not take a bitmask as a first argument, but a bit n=
umber.
> > >=20
> > > I.e. if you want to switch BIT(0), you call it like assign_bit(0, ...=
),
> > > not assign_bit(BIT(0), ...). Same for the bit nr 1.
> > >=20
> >=20
> > Yes, I know... if you look at my reply to Dan you can see I realized th=
at already
> > :)=20
>=20
> Oh okay :)
>=20
> >=20
> > I guess by the time I first sent this time I didn't knew or maybe just =
a dumb
> > mistake...
> >=20
> > I'll send a patch later today removing the BIT() from the #define, thx!
>=20
> Nice! Don't forget the tags the build bot asked for :p
>=20

Just sent it... Hopefully no tags were forgotten! I was not sure about the =
Fixes tag
but added it anyways as this is indeed fixing something (even though the bu=
g was
never triggered).

- Nuno S=C3=A1