Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Mon, 06 Nov 2023 15:33:14 +0000
Message-ID: <86edh228xx.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Kunkun Jiang <jiangkunkun@huawei.com>
Cc:     Oliver Upton <oliver.upton@linux.dev>,
        James Morse <james.morse@arm.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Zenghui Yu <yuzenghui@huawei.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>, Gavin Shan <gshan@redhat.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.org>,
        "open list:IRQCHIP DRIVERS" <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <kvmarm@lists.linux.dev>,
        <wanghaibin.wang@huawei.com>
Subject: Re: [RFC PATCH] KVM: arm/arm64: GICv4: Support shared VLPI
In-Reply-To: <1fb8353e-e9c4-2570-c2ca-ec537c18ac4d@huawei.com>
References: <20231102143507.840-1-jiangkunkun@huawei.com>
        <87msvt6cc7.wl-maz@kernel.org>
        <1fb8353e-e9c4-2570-c2ca-ec537c18ac4d@huawei.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 06 Nov 2023 14:59:01 +0000,
Kunkun Jiang <jiangkunkun@huawei.com> wrote:
> 
> The virtio-pci driver write entry1-6
> massage.data in the msix-table and trap to QEMU for processing. The
> massage.data is as follow:
> > entry-0 0
> > entry-1 1
> > entry-2 1
> > entry-3 1
> > entry-4 1
> > entry-5 1
> > entry-6 1

Urgh... is vp_modern_queue_vector() used in your configuration? This
is ... terrible.

I wonder if PCIe actually allows this sort of thing.

In any case, this sort of behaviour breaks so many thing in KVM's
implementation that I'd recommend you disable GICv4 until we have a
good solution for that.

	M.

-- 
Without deviation from the norm, progress is not possible.