Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp2206508rdf; Mon, 6 Nov 2023 07:37:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IGRfKZPUm1uXOi7I/f67xbGKaUXVLaFjJ7wCCcA1ug8fjEDByA4tnb4qEAA+Qv4mfUw2fOE X-Received: by 2002:a05:6871:10f:b0:1e9:54ef:4806 with SMTP id y15-20020a056871010f00b001e954ef4806mr55148oab.9.1699285056983; Mon, 06 Nov 2023 07:37:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699285056; cv=none; d=google.com; s=arc-20160816; b=G7hldnGs8OQfnIPle2o7wMgTr+bjqZFcYbGgUTLW52R1ReVE96GEGzLQBC+33OpEB4 jFIoHlyVNwz0U4NnGklrOpB6FCSSHgVgn4eWHWIxOjqr4ttgOcKqYP0sWW4Uno3PhcoZ bl6CC4Mkke0EfSgBalk0iaweLyeVatqJr73lVo+07GaM2DQrfEOquXNLNvPVm3fAs6vU yjPGXj5rsbYYYC748qNQTjdmccg541gTzh1XxhJArYOB5g8y/1BMxGtBVEi0OfqJHoAP IiGF7E1/dHSFteMiCnY3/7ye/CN1ovG9Wx6EfyLjq6hYdC5HmgsUEJqSc4fW8+SEjuEX BNYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=PhVYoqkFGDBmHN5xLHueJkfMTMCbvKcxSBfu8WwI8JM=; fh=Wdr5KDZ7s721t+e3mipShyFip4x7putJvx5P4ip954s=; b=DiQBRptwCGnSHHu0t657Vd1NZoOgJVOI6LNx0u2vwzLJ7ySI/WicelS+YJEbTu5uOf 60n/pYb1DCNKRMEeR/K689uQTKJHQj7W6l80gOHDtlmJnASAw8Xekohl37iwnsUW6CCB nmJ8JNWaTqF9DMM7fQqmeCtohVoTew682dNgAZvfNJjfZrtbp+0m5Zg1LY7oQa3Cd7di a9HVup9qrJGn0O93gKl4AwU2+qFcoxQlc9ikrPX+kMezuQYXuAimE6b06op+amA8RKgU S1iQgXvslqXavc0DB5iOH6+7UxnRwrRn9SDeRqLszXteV6Ka/+6vj/Dph0g6oc6xjR+A shxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l2IetvyK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id r20-20020a6560d4000000b005b87df75d54si7876925pgv.83.2023.11.06.07.37.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 07:37:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l2IetvyK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id BBFB180BD536; Mon, 6 Nov 2023 07:37:34 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232072AbjKFPh1 (ORCPT + 99 others); Mon, 6 Nov 2023 10:37:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231277AbjKFPh0 (ORCPT ); Mon, 6 Nov 2023 10:37:26 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 878D3B8 for ; Mon, 6 Nov 2023 07:37:23 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEB56C433C8; Mon, 6 Nov 2023 15:37:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699285043; bh=PhVYoqkFGDBmHN5xLHueJkfMTMCbvKcxSBfu8WwI8JM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l2IetvyKN1oDLRoz0HwVEHgm8jvWm0ezF3BJYiPp/+QBjj2ntLMAZ096AFg17aTJf mQIX9NVE8OerkpCihyfIFcIV6qlOx+uk3UEurxuzcI31bpB1dgx4lpQWZbQ+0Oso6L ZGjNPVBJs0PZtkPvjQw7FbMubGzmv+l+hYTv50nwNQYUhpKYUoRBB31yp97Z81Zsc0 diVdo1B3wj1X/GLk5HP5DEa+OD5zZfUSJeqxN3DUtXMYbnXlIXMK5fQj+VVuCX84x/ qCuBhEl4SkI75MFJuD/Pv+fEoC6U0HifRS7g2D3Xp8oWPj0t4zYOO26CZD+PM/DoAR m0ZlAXp+BAWvQ== Date: Mon, 6 Nov 2023 16:37:20 +0100 From: 'Maxime Ripard' To: oushixiong@kylinos.cn Cc: 'Maarten Lankhorst' , 'Thomas Zimmermann' , 'David Airlie' , 'Daniel Vetter' , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: =?utf-8?B?5Zue5aSNOiBbUEFUQ0hdIGRybS9hdG9taWMtaGVscGVy?= =?utf-8?Q?=3A?= Call stall_checks() before allocate drm_crtc_commit Message-ID: References: <20231106073742.158905-1-oushixiong@kylinos.cn> <6yqalig6nvnlpt7loetugjdgp5z4w3qwhpqpzzsygffp5w32d6@guq6v3g2z7tq> <000301da10b4$d4e90690$7ebb13b0$@kylinos.cn> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="h44eb5yewsfjbvln" Content-Disposition: inline In-Reply-To: <000301da10b4$d4e90690$7ebb13b0$@kylinos.cn> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 06 Nov 2023 07:37:34 -0800 (PST) --h44eb5yewsfjbvln Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, On Mon, Nov 06, 2023 at 09:26:15PM +0800, oushixiong@kylinos.cn wrote: > I think it will cause memory leaks if too many nonblock commit works return > -EBUSY. Do you *think* or are you sure? If you are sure, then please write down everything I mentioned earlier in the commit log and resend the patch. Maxime --h44eb5yewsfjbvln Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZUkIMAAKCRDj7w1vZxhR xbu4AQC4X4AXCLB1i6aJtzCDqCh3TGotHlxtKKbT4mkBrEI+bwD/QGr2Ba6VVzjC 2pz/3i33zZW48TE5qeR9gewfVBg+Cws= =V8FP -----END PGP SIGNATURE----- --h44eb5yewsfjbvln--