Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, oe-kbuild-all@lists.linux.dev,
        linux-kernel@vger.kernel.org,
        Simon Horman <simon.horman@corigine.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        kernel test robot <lkp@intel.com>
Subject: [PATCH net] net: enetc: shorten enetc_setup_xdp_prog() error message to fit NETLINK_MAX_FMTMSG_LEN
Date:   Mon,  6 Nov 2023 18:03:11 +0200
Message-Id: <20231106160311.616118-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OqEx/Ed4N3WEcJ0eRuAZ8n6biEQJ9ygNtRJ+2GwK1ONiiRIIze1fpQWOdH1L?=
 =?us-ascii?Q?HQLJj8yZsOAGK9xrPxtAg6Sk9SG8G0X8d/zz65EVf5E3S0FRqGZi9Ca5MU7/?=
 =?us-ascii?Q?sPeJl+XKii8ioyv+vRuNkRwkGOUBdNGidxbjN+bXFIBqN7Zv8ejOU8oGRfhK?=
 =?us-ascii?Q?8vgdysrfMXqr8ciuX/tEfeSSTwGJl0RMiwwWdGbKcnEo9/yteD0QeBDPFEO0?=
 =?us-ascii?Q?Icrj6oBj+HkzlNw9cYjqMAcjl2aKjfK2GpQb5EPFa2sBl6fehk7rr8TuZSnn?=
 =?us-ascii?Q?t5sVlu/9Nvo6Y1DvMfvqXTACxQzIP3mIsl5GdoB33oaZZ8u99xULUB4B3+BK?=
 =?us-ascii?Q?Oogh9EipfXndtusm+dia36MZkFuugPxHa3udXDnEoldU9NTYCM7rKLExO8DN?=
 =?us-ascii?Q?LgmzPmMSgtsxA2BpW844wRrhNtf0YpYMnj6D8ATeTEgYXoWgh2X+78d9rzJD?=
 =?us-ascii?Q?Zm3KUbKFR64LjqgSC3WnS1bSwgmKm2XX2bhh/PqSurR7mTYeL50zZqf3HF/K?=
 =?us-ascii?Q?i7DbiBmEafKn1U5urQ7knDB9eRpx88XhO1VZY2bKXb+Kfny7cLZxGe/cv1ZB?=
 =?us-ascii?Q?/CztIU6L7yhQq/ehTTEOmAKvYdK7W7OtjOhnk1D8CGLzit0uT3yU/kD8ZA02?=
 =?us-ascii?Q?RlQ4SyHm0ml+HICp6hPSCDibw3SqLiEOb+5hJqnmD36P+pmdXP/NJ4R+PzXF?=
 =?us-ascii?Q?2fuu4n7jszjj3sy2SHgrR/P1blYEn4Z5u5HL+RawXYGCUspMa1ZLoKtiOnJD?=
 =?us-ascii?Q?CHtAMjvGXHi57V1dTFphu095lngsztfSE6VDJUv03xZ5dT/rtoEtvn3pM01b?=
 =?us-ascii?Q?oNQilkL+LW9eiSFXWvnqfvYoKEr0t1HXSMsRKp+IF5+vC8+xvFKJylIFv1DZ?=
 =?us-ascii?Q?sU3nbEvjjVT56yIAH1aI9arpDYSHJ5qC5IyjuAuvkIIkr5yBUC1XxGExqjoH?=
 =?us-ascii?Q?u7wIhZp288VioK2PkuzciDnQdCFYUNlQimIdQW8u+HL3xCQms5QMTKTBUpvT?=
 =?us-ascii?Q?ABFlX7z9jT5aPb7WwgqxAPc4Jfkn/yWDraegfBTWSG4QlgXVJTbTOTBKZU+N?=
 =?us-ascii?Q?JvsLPHq1Mp9BKAn9uyUhFJHwSBhA5y+beskkaWGTcJ5/qQ80CJWXe19i48tn?=
 =?us-ascii?Q?S1ydHwX55gPQbYkRuRWmahhiQ65yOE8ihVHXgwc02dtDeKizpp/WXjtxmsLE?=
 =?us-ascii?Q?mOdqv4YDmIaxhhSsrt6vA7Ucs9pK85es2IIIeIJE8tqIHoi6+AAz2/+GHw5+?=
 =?us-ascii?Q?TgydnQ84x4mGcJnq8RKqhZF6NV5NxVvzgzvsxYR4pgjTjHB6zXtAZ4IMAHfv?=
 =?us-ascii?Q?F6am25+aWAUgVgeAar8nrpRVBJlPZrFyGP9wpfO/bqgYTGfoZAItHMBywo41?=
 =?us-ascii?Q?+MP2dNqBuIfUwwAhQjLA73VD1PDYmPB8DggOVfv4xjc9T95L5M4qlnhKwYWf?=
 =?us-ascii?Q?GRlWaYx0smMlesS/1IiwQdmyoWp599lhhhlb2g799TeXIwbfCK6qLltyKIDJ?=
 =?us-ascii?Q?2010R+XeCzMkegKQ22eXznhPxXX0+zPCiJhUx4b8kpeJYtUXLXvMOk7dva6o?=
 =?us-ascii?Q?QovYDrNEq40E2TTgiGvDz7MKuRiAgoAMx9pRRAFCvOIl5EWTRoK7OGcC6z7Y?=
 =?us-ascii?Q?Nw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1acec5ef-60c0-43d3-8928-08dbdee1e855
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2023 16:03:25.1727
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 37xWTL9nRVyK+VzFCn5ui8bG9H4nnhT4HVV0AeJsSjqcW18Bd4ei+6FRyoi3xQqWwfR45zRHeDKx1cBo784C5Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9762
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 06 Nov 2023 08:03:42 -0800 (PST)

NETLINK_MAX_FMTMSG_LEN is currently hardcoded to 80, and we provide an
error printf-formatted string having 96 characters including the
terminating \0. Assuming each %d (representing a queue) gets replaced by
a number having at most 2 digits (a reasonable assumption), the final
string is also 96 characters wide, which is too much.

Reduce the verbiage a bit by removing some (partially) redundant words,
which makes the new printf-formatted string be 73 characters wide with
the trailing newline.

Fixes: 800db2d125c2 ("net: enetc: ensure we always have a minimum number of TXQs for stack")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/lkml/202311061336.4dsWMT1h-lkp@intel.com/
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/ethernet/freescale/enetc/enetc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c
index 30bec47bc665..cffbf27c4656 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc.c
@@ -2769,7 +2769,7 @@ static int enetc_setup_xdp_prog(struct net_device *ndev, struct bpf_prog *prog,
 	if (priv->min_num_stack_tx_queues + num_xdp_tx_queues >
 	    priv->num_tx_rings) {
 		NL_SET_ERR_MSG_FMT_MOD(extack,
-				       "Reserving %d XDP TXQs does not leave a minimum of %d TXQs for network stack (total %d available)",
+				       "Reserving %d XDP TXQs does not leave a minimum of %d for stack (total %d)",
 				       num_xdp_tx_queues,
 				       priv->min_num_stack_tx_queues,
 				       priv->num_tx_rings);
-- 
2.34.1