Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <21a93447-6830-4884-b488-cbac38df1b96@gmail.com>
Date:   Tue, 7 Nov 2023 00:13:06 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] bpf: Use E2BIG instead of ENOENT
To:     Alexei Starovoitov <alexei.starovoitov@gmail.com>
References: <20231104024444.385484-1-chen.dylane@gmail.com>
 <CAADnVQ+1pNzLRwNNzL-0ai0P281hG=eNO2COrCxuCv2VF3KGUA@mail.gmail.com>
 <CA+92Ff+ZW5wu3mZFs--nxcyJyc7YxEhP-yuL-BEsWzVChR9Jdg@mail.gmail.com>
Cc:     Song Liu <song@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Yonghong Song <yonghong.song@linux.dev>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        John Fastabend <john.fastabend@gmail.com>,
        Hao Luo <haoluo@google.com>, bpf <bpf@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
From:   Tao Chen <chen.dylane@gmail.com>
In-Reply-To: <CA+92Ff+ZW5wu3mZFs--nxcyJyc7YxEhP-yuL-BEsWzVChR9Jdg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


Hi, Alexei, the delete element api of stackmap return E2BIG when the key 
size beyond the buckets size, so i try to keep the same approach. Maybe 
it's not necessary, anyway, thanks for your reply.

在 2023/11/6 下午11:59, Tao Chen 写道:
> 
> 
> ---------- Forwarded message ---------
> 发件人： *Alexei Starovoitov* <alexei.starovoitov@gmail.com 
> <mailto:alexei.starovoitov@gmail.com>>
> Date: 2023年11月5日周日 04:54
> Subject: Re: [PATCH] bpf: Use E2BIG instead of ENOENT
> To: Tao Chen <chen.dylane@gmail.com <mailto:chen.dylane@gmail.com>>
> Cc: Song Liu <song@kernel.org <mailto:song@kernel.org>>, Jiri Olsa 
> <jolsa@kernel.org <mailto:jolsa@kernel.org>>, Alexei Starovoitov 
> <ast@kernel.org <mailto:ast@kernel.org>>, Daniel Borkmann 
> <daniel@iogearbox.net <mailto:daniel@iogearbox.net>>, Andrii Nakryiko 
> <andrii@kernel.org <mailto:andrii@kernel.org>>, Yonghong Song 
> <yonghong.song@linux.dev <mailto:yonghong.song@linux.dev>>, Martin KaFai 
> Lau <martin.lau@linux.dev <mailto:martin.lau@linux.dev>>, John Fastabend 
> <john.fastabend@gmail.com <mailto:john.fastabend@gmail.com>>, Hao Luo 
> <haoluo@google.com <mailto:haoluo@google.com>>, bpf <bpf@vger.kernel.org 
> <mailto:bpf@vger.kernel.org>>, LKML <linux-kernel@vger.kernel.org 
> <mailto:linux-kernel@vger.kernel.org>>
> 
> 
> On Fri, Nov 3, 2023 at 7:44 PM Tao Chen <chen.dylane@gmail.com 
> <mailto:chen.dylane@gmail.com>> wrote:
>  >
>  > Use E2BIG instead of ENOENT when the key size beyond the buckets size,
>  > it seems more meaningful.
> 
> seems more meaningful?
> Sorry. That's hardly a reason to break someone's code.