Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp2248435rdf; Mon, 6 Nov 2023 08:36:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IFyhuuLU0oinbca59PpOiA0HP/nG2xYw94dz7ibtSMHVBY5/7SklElyEhq0un0HaI2fyoRI X-Received: by 2002:a05:6a20:5493:b0:14e:2208:d62f with SMTP id i19-20020a056a20549300b0014e2208d62fmr16548728pzk.22.1699288619195; Mon, 06 Nov 2023 08:36:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699288619; cv=none; d=google.com; s=arc-20160816; b=DxeDsDWCq0pTS8k9Ff2E1nPhu0s0CgJmPzoW+QIUy2uue3LjU6afMQco98DG3oHDQS WXS+/h0WHXkZVjP5v4NiA625KfEzeEz39kk1ArhslxFGrWRWmyzotVczMsUdmlBg0BPe 5impzULJghnMsQUvrsN4vkSJrE9eWOVmGdaK/Wo0aUa7ipKtE6cprxXw2kFIx1tLIhh4 geqEV7Xo3w43R1u37gB3VsGcvgNGtTeT23rra7xG8bsfm0C+9VFW8XfM7yBp8DxfooNc eskycDDCd/vBeAJtf2AYFXb8EnlS5PxMLWp0hStckaB5spHxvyBQ8+uof0MQ8nYzMian ytwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=H1bVntGfi9PYOqW2w2sEKFCjGpKPAhuPekyPqw5Ea/s=; fh=qf5iqUw9fccW67zmzqSga1hHBo3UAc+uir0ql0mDZ5g=; b=FiNg/ApfkTru3OcgPJ8vpuiEhE5wsS3leY3U040NDRs/Ov8k9w0I95ixcjIXQzwZQI MTfBYR1chNeX2/ht+RgjZ4Ijffj6Cs7+7AplUe73qHeiIkBFoU88tqiHx/FYHq4FO1ux PFSmgJkGVaLY7G15niphJBLcRszyq0xUeXMeOqcnj5CqZSCb4aa9wgebdi7mkkeVZfqs ev0HkfoFO0rdx6fszpW7LIk4bJ/2uQcWDpBKq2l3i+plMm4Ws/8qJAe7Jidt6HMxpZ+Z ua1Pd/cf+HBUUHhaWHhXfo/wKUEcgGURQvhnJEc5wqLAAs2gyR+nm5lR6nNKLvLS5fzA xn2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L857G2yV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id q187-20020a6343c4000000b005af21fd2c6fsi10267pga.898.2023.11.06.08.36.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 08:36:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L857G2yV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id CE69880A8BBF; Mon, 6 Nov 2023 08:36:56 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232202AbjKFQgv (ORCPT + 99 others); Mon, 6 Nov 2023 11:36:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230086AbjKFQgu (ORCPT ); Mon, 6 Nov 2023 11:36:50 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2035F3 for ; Mon, 6 Nov 2023 08:36:47 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B76A2C433C8; Mon, 6 Nov 2023 16:36:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699288607; bh=i/ae4hJdIve54O+1/N5AmqSGvw4v4QG1RuIz6Bfe7CI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L857G2yVMIhWjeGXQli2nFJEwQ0RSUX8law95qewMP8pO770uwM75kzCM+9RHP2xd bDklj+dQFl3KO3+LMMGUoQJbKr7kI4bWrhxtAXUitScGAj00A3WjjtrggYUyqnFB5m qdzzL/ukBqUkmrRCiF/53Alr1Np7gu/D8eqACXQXOAVq51BVq8h6GNp2/q9gwvNQiw eQViz11kodlKygGXKutlU8+TyEiw9swBw5zBgehVtNWlBYl/zS4ZmZzp/8eBwlPhT3 dQqJluzNO4KQ/GRX0ZehccHL7qNp9O3SFhY94+qaSwIHXUbrS4NVNFsruuvpLM0Cw6 tkhPk1RU4Dy4A== Date: Mon, 6 Nov 2023 09:36:44 -0700 From: Keith Busch To: Mark O'Donovan Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de, axboe@kernel.dk, hare@suse.de Subject: Re: [PATCH v3 0/3] nvme-tcp: always set valid seq_num in dhchap reply Message-ID: References: <20231025105125.134443-1-shiftee@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231025105125.134443-1-shiftee@posteo.net> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 06 Nov 2023 08:36:57 -0800 (PST) On Wed, Oct 25, 2023 at 10:51:22AM +0000, Mark O'Donovan wrote: > The first patch is a small unrelated fix which makes it clear that the > response data section of the Success1 message is not optional. > > The second patch removes use of the host sequence number (S2) as an > indicator of bi-directional authentication. > > The third patch causes us to always set the host sequence number (S2) > to a non-zero value instead of the 0 value reserved for the secure > channel feature. Thanks, queued up for nvme-6.7.