Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Mon, 6 Nov 2023 08:39:36 -0800
In-Reply-To: <CALMp9eRzvj_Ach=QySHgpkKO6z=42OJmC4DPU=tCTxcioFvZEw@mail.gmail.com>
Mime-Version: 1.0
References: <20231104000239.367005-1-seanjc@google.com> <20231104000239.367005-12-seanjc@google.com>
 <CALMp9eRzvj_Ach=QySHgpkKO6z=42OJmC4DPU=tCTxcioFvZEw@mail.gmail.com>
Message-ID: <ZUkWyNBeaKiQrhiw@google.com>
Subject: Re: [PATCH v6 11/20] KVM: selftests: Test Intel PMU architectural
 events on fixed counters
From:   Sean Christopherson <seanjc@google.com>
To:     Jim Mattson <jmattson@google.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Kan Liang <kan.liang@linux.intel.com>,
        Dapeng Mi <dapeng1.mi@linux.intel.com>,
        Jinrong Liang <cloudliang@tencent.com>,
        Like Xu <likexu@tencent.com>,
        Aaron Lewis <aaronlewis@google.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Nov 04, 2023, Jim Mattson wrote:
> On Fri, Nov 3, 2023 at 5:03=E2=80=AFPM Sean Christopherson <seanjc@google=
.com> wrote:
> >  static void guest_test_arch_event(uint8_t idx)
> >  {
> >         const struct {
> >                 struct kvm_x86_pmu_feature gp_event;
> > +               struct kvm_x86_pmu_feature fixed_event;
> >         } intel_event_to_feature[] =3D {
> > -               [INTEL_ARCH_CPU_CYCLES]            =3D { X86_PMU_FEATUR=
E_CPU_CYCLES },
> > -               [INTEL_ARCH_INSTRUCTIONS_RETIRED]  =3D { X86_PMU_FEATUR=
E_INSNS_RETIRED },
> > -               [INTEL_ARCH_REFERENCE_CYCLES]      =3D { X86_PMU_FEATUR=
E_REFERENCE_CYCLES },
> > -               [INTEL_ARCH_LLC_REFERENCES]        =3D { X86_PMU_FEATUR=
E_LLC_REFERENCES },
> > -               [INTEL_ARCH_LLC_MISSES]            =3D { X86_PMU_FEATUR=
E_LLC_MISSES },
> > -               [INTEL_ARCH_BRANCHES_RETIRED]      =3D { X86_PMU_FEATUR=
E_BRANCH_INSNS_RETIRED },
> > -               [INTEL_ARCH_BRANCHES_MISPREDICTED] =3D { X86_PMU_FEATUR=
E_BRANCHES_MISPREDICTED },
> > +               [INTEL_ARCH_CPU_CYCLES]            =3D { X86_PMU_FEATUR=
E_CPU_CYCLES, X86_PMU_FEATURE_CPU_CYCLES_FIXED },
> > +               [INTEL_ARCH_INSTRUCTIONS_RETIRED]  =3D { X86_PMU_FEATUR=
E_INSNS_RETIRED, X86_PMU_FEATURE_INSNS_RETIRED_FIXED },
> > +               /*
> > +                * Note, the fixed counter for reference cycles is NOT =
the same
> > +                * as the general purpose architectural event (because =
the GP
> > +                * event is garbage).  The fixed counter explicitly cou=
nts at
> > +                * the same frequency as the TSC, whereas the GP event =
counts
> > +                * at a fixed, but uarch specific, frequency.  Bundle t=
hem here
> > +                * for simplicity.
> > +                */
>=20
> Implementation-specific is not necessarily garbage, though it would be
> nice if there was a way to query the frequency rather than calibrating
> against another clock.

Heh, I'll drop the editorial commentry, though I still think an architectur=
al event
with implementation-specific behavior is garbage :-)