Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <8ab5175c-5ea8-4bc4-81c9-2f37dc15f270@amd.com>
Date:   Mon, 6 Nov 2023 10:49:18 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/9] drm/nouveau: Switch from
 pci_is_thunderbolt_attached() to dev_is_removable()
Content-Language: en-US
To:     Mika Westerberg <mika.westerberg@linux.intel.com>,
        =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     Karol Herbst <kherbst@redhat.com>, Lyude Paul <lyude@redhat.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Lukas Wunner <lukas@wunner.de>,
        Danilo Krummrich <dakr@redhat.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Xinhui Pan <Xinhui.Pan@amd.com>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Mark Gross <markgross@kernel.org>,
        Andreas Noever <andreas.noever@gmail.com>,
        Michael Jamet <michael.jamet@intel.com>,
        Yehezkel Bernat <YehezkelShB@gmail.com>,
        =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali@kernel.org>,
        =?UTF-8?Q?Marek_Beh=C3=BAn?= <kabel@kernel.org>,
        "Maciej W . Rozycki" <macro@orcam.me.uk>,
        Manivannan Sadhasivam <mani@kernel.org>,
        "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" 
        <dri-devel@lists.freedesktop.org>,
        "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" 
        <nouveau@lists.freedesktop.org>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:RADEON and AMDGPU DRM DRIVERS" 
        <amd-gfx@lists.freedesktop.org>,
        "open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
        "open list:ACPI" <linux-acpi@vger.kernel.org>,
        "open list:X86 PLATFORM DRIVERS" 
        <platform-driver-x86@vger.kernel.org>,
        "open list:THUNDERBOLT DRIVER" <linux-usb@vger.kernel.org>
References: <20231103190758.82911-1-mario.limonciello@amd.com>
 <20231103190758.82911-2-mario.limonciello@amd.com>
 <55563d57-60c3-1789-1e7c-5e618fbd6253@linux.intel.com>
 <20231106164751.GS17433@black.fi.intel.com>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20231106164751.GS17433@black.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dGNkb3dOc0ZqVDM2czNJaEU5aFFLVHlVVTBWZTlxQVBlakpua1lDNGwrUFNx?=
 =?utf-8?B?YldvbW9jSGhNaE5mTGJjUjErSjdhQWF3SUhHYndSSkFtSXdDOXg4Q1NwM1Ji?=
 =?utf-8?B?ZlVHTFpCZmkyYWJIbXpEekVxUVI3bDhOYmducFpQQVBaekhIcWpsa0svcXA3?=
 =?utf-8?B?VCt3Y1o1RHNhck5TQjNLS2pHT1R3czVPRTJqdExTMnBFcnpTOGl6K0ZPUlpt?=
 =?utf-8?B?WGlaT3FJdGVreTNZWGhKdER5M1JqQy9uTFVMK2lOQ3h4YXVPUFhYaXV0TnBH?=
 =?utf-8?B?YU91SzdnWUVxdjdJV3Qxa25ta2ZtRno4RVlqTG51OVlYR2UvVkhhSXd3REgv?=
 =?utf-8?B?cVg0LzZmTnoxWEgvQzNGZk13elRXMWlWdjQ3WmVHYVlKMFJ3L21wcVZlMmhp?=
 =?utf-8?B?U1MxWVhiYUdHenZqeWJ3cGZFQndEdW9OWTFiN004aDNkR1pWWDBjeEh1WG9m?=
 =?utf-8?B?Z3BzVlZqUHhZMkN1WnRlLzdKcVNIbzU3YzZvSW9EK3U2QVgzS2lSK01RaWVI?=
 =?utf-8?B?VmFRWitXMFhYVGk3YldDZkxxaWNlTkJsTElRc05PMWIrcXRlVzZRYk1PbCtu?=
 =?utf-8?B?dDRBMVAyaWRralY1bFJ0bDBkU1VoaXRlZUpqZCtrQm9OMXZOQnJEUmxxY2E5?=
 =?utf-8?B?L1VBWTcxTEh3dGQvK2o1a3QzUU1pb2JueWJKZGhDdFU3NmJDSkQwd2krUWZ1?=
 =?utf-8?B?NHlIUUY0NzgyWm5WOTN6VXVieFdBMkpNNU9wMUhxQ2VzeGFjWXVzUS90a2p1?=
 =?utf-8?B?T2V6WWVrTytjajJhclpCSTJaWkhFRWREMHc1WHJPWXcyZE9Vbk1uR0VydDNR?=
 =?utf-8?B?czFJL1N6M1gzdUpOdkJRVkxsWitpWkFoK2o2clRDZWFORkIvVUQvcFJiYkxN?=
 =?utf-8?B?NVJ1Qi9aOEhRWUdweDQ5clB1ZE0wbE9VWm12YTVFL24rcE9QVFdnNS9MVWNo?=
 =?utf-8?B?S3NkQXdHQmlGbEtrN2hBNVNCcFp5alpBWHBJb2FYSExabVJzakVxM0lPUWQv?=
 =?utf-8?B?ZUt1Snp6OVZvSGNSTFIyNUhSckJIMUhrcEkvbEJwUkJWdXpHTlR2THdWQVhR?=
 =?utf-8?B?aTJGT2NlclpDa21rV0RaejVoU25sbkxnT0tVNXFsQTJrQVFneVZudDNYQ01o?=
 =?utf-8?B?V3hjL3h1K2ZJRUdKdmJWUEorZ2g3eEwwam0yQlJvTWp3NUVVMEcra0ozbzdz?=
 =?utf-8?B?UmhkL1FGVlpLS2pCN1JLVDJhVmF6cU93andFbVpsWDZnQXF4ejZrSmtGYmFD?=
 =?utf-8?B?M1JsSG84Y0lldXh6YzZKOHdha2JLaXEwemI1ZmpiUkw3M0ZIZ0hZc3lObXpG?=
 =?utf-8?B?Mk5xdWwxQ2tsOHBkTnFhdGdOWEkwMUc3b3AyRkV0UmcvdUNVTk4xWS9JTmsr?=
 =?utf-8?B?WWpmc25HU3FaQVNWa3JWYTdQM2xER09ybG9YUmhuMHZOSmVzd0N6ZHJZcFp4?=
 =?utf-8?B?Vm0yVGtCMkpqWkxadXA0dDRVV0hoS3JpOUFRUytXeTZKQlBsUkNBYTd3d2E4?=
 =?utf-8?B?UHNQbkUzNWxDUncvOHlEbjIwRjRNdDF4bTY3a0lONkROYTh6clJ0dkZySU5h?=
 =?utf-8?B?NVYyRFMraHZEWERJZ00wWDVVUmhPNWJLeDREM09wSDgzZEtpaWR6enRSRXRh?=
 =?utf-8?B?V3hOMmg3NWpLSkNvT0FSYm5kYzVFa20wSm5XdW13RDVrODMxTnBJTUdEK3Ro?=
 =?utf-8?B?ZHlDdXB5VkJOQW9ZQldNKy9lQU0xMmpHdnF0ZFVQVVQwa1kwU0QrZDVkbDRZ?=
 =?utf-8?B?S2F4ajMwR2JyZzBXRC9aeVMwS0RtTTRTZnNWSmM2ZjVSblJpTmJYWWVPdnQ4?=
 =?utf-8?B?R0c3MzE1bXlDbCtPTHJQT1gzclFVdXpiM3lNL2ZxNkIwdFpWNjRqSW0vL3oz?=
 =?utf-8?B?dGhSM2dkZExpSFdMREFvSjRidlZqUmhGV3JDRi9VMTBweHJaUU9nRE9VN3ho?=
 =?utf-8?B?VmRuQXBoaWNtT1VPamFZTHhrd0ZUclBya1F3WFNOQ1NwdjVWMy9GZWNIc092?=
 =?utf-8?B?Z3c0Vk9aOHp3Uk5pVjVDWnhFT0NqUXVkTHM3NG5BaW5zc0JLVVJBdnAwU2tl?=
 =?utf-8?B?L1FKbFh0SmVDOXFRK0J1SlcxUDc2cGxWYjIxd0l5K28zZEFyZGlWblZtWTFR?=
 =?utf-8?Q?xMoLelBMAVWn/UDsYsot5kp2W?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c258e1b1-2d1e-4772-2167-08dbdee85402
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2023 16:49:22.7955
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ozmyfd+G8tYhPtqofH0LUjykaFHSbhN22gvyjw7MBE05/FEp4SrZ76Ms1/VHtbS4OM8+IBBxIRl4ChfJmc5jlA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9097
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 06 Nov 2023 08:49:37 -0800 (PST)

On 11/6/2023 10:47, Mika Westerberg wrote:
> On Mon, Nov 06, 2023 at 02:25:24PM +0200, Ilpo Järvinen wrote:
>> On Fri, 3 Nov 2023, Mario Limonciello wrote:
>>
>>> pci_is_thunderbolt_attached() only works for Intel TBT devices. Switch to
>>> using dev_is_removable() to be able to detect USB4 devices as well.
>>
>> Please extend this with more details. I had to lookup the TBT change to
>> be able to make any guess why you're doing this (and it's still a guess
>> at best).
> 
> Also please write it as Thunderbolt not TBT so that it is clear what we
> are talking about. Ditto to all patches.

Ack, thanks I will add more detail to these first few patches and make 
that s/TBT/Thunderbolt/ change when I rebase this on 6.7-rc1.