Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
MIME-Version: 1.0
References: <20231103105440.23904-1-quic_anshar@quicinc.com>
In-Reply-To: <20231103105440.23904-1-quic_anshar@quicinc.com>
From:   Doug Anderson <dianders@chromium.org>
Date:   Mon, 6 Nov 2023 08:53:59 -0800
Message-ID: <CAD=FV=XOyHr9hNA0gEdssGz5qqyXHU75K9TUH3HSHK3+jpfswg@mail.gmail.com>
Subject: Re: [PATCH v2] arm64: dts: qcom: sc7280: Add capacity and DPC properties
To:     Ankit Sharma <quic_anshar@quicinc.com>
Cc:     cros-qcom-dts-watchers@chromium.org, agross@kernel.org,
        andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, quic_ashayj@quicinc.com,
        quic_atulpant@quicinc.com, quic_rgottimu@quicinc.com,
        quic_shashim@quicinc.com, quic_pkondeti@quicinc.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Fri, Nov 3, 2023 at 3:54=E2=80=AFAM Ankit Sharma <quic_anshar@quicinc.co=
m> wrote:
>
> The "capacity-dmips-mhz" and "dynamic-power-coefficient" are
> used to build Energy Model which in turn is used by EAS to take
> placement decisions. So add it to SC7280 soc.
>
> Signed-off-by: Ankit Sharma <quic_anshar@quicinc.com>
> ---
> changes in v2: https://lore.kernel.org/all/20231103095358.29312-1-quic_an=
shar@quicinc.com/
>  - updated commit message and subject.
>
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/q=
com/sc7280.dtsi
> index 8601253aec70..b1890824188c 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -176,6 +176,8 @@
>                                            &CLUSTER_SLEEP_0>;
>                         next-level-cache =3D <&L2_0>;
>                         operating-points-v2 =3D <&cpu0_opp_table>;
> +                       capacity-dmips-mhz =3D <1024>;
> +                       dynamic-power-coefficient =3D <100>;
>                         interconnects =3D <&gem_noc MASTER_APPSS_PROC 3 &=
mc_virt SLAVE_EBI1 3>,
>                                         <&epss_l3 MASTER_EPSS_L3_APPS &ep=
ss_l3 SLAVE_EPSS_L3_SHARED>;
>                         qcom,freq-domain =3D <&cpufreq_hw 0>;
> @@ -204,6 +206,8 @@
>                                            &CLUSTER_SLEEP_0>;
>                         next-level-cache =3D <&L2_100>;
>                         operating-points-v2 =3D <&cpu0_opp_table>;
> +                       capacity-dmips-mhz =3D <1024>;
> +                       dynamic-power-coefficient =3D <100>;
>                         interconnects =3D <&gem_noc MASTER_APPSS_PROC 3 &=
mc_virt SLAVE_EBI1 3>,
>                                         <&epss_l3 MASTER_EPSS_L3_APPS &ep=
ss_l3 SLAVE_EPSS_L3_SHARED>;
>                         qcom,freq-domain =3D <&cpufreq_hw 0>;
> @@ -227,6 +231,8 @@
>                                            &CLUSTER_SLEEP_0>;
>                         next-level-cache =3D <&L2_200>;
>                         operating-points-v2 =3D <&cpu0_opp_table>;
> +                       capacity-dmips-mhz =3D <1024>;
> +                       dynamic-power-coefficient =3D <100>;
>                         interconnects =3D <&gem_noc MASTER_APPSS_PROC 3 &=
mc_virt SLAVE_EBI1 3>,
>                                         <&epss_l3 MASTER_EPSS_L3_APPS &ep=
ss_l3 SLAVE_EPSS_L3_SHARED>;
>                         qcom,freq-domain =3D <&cpufreq_hw 0>;
> @@ -250,6 +256,8 @@
>                                            &CLUSTER_SLEEP_0>;
>                         next-level-cache =3D <&L2_300>;
>                         operating-points-v2 =3D <&cpu0_opp_table>;
> +                       capacity-dmips-mhz =3D <1024>;
> +                       dynamic-power-coefficient =3D <100>;
>                         interconnects =3D <&gem_noc MASTER_APPSS_PROC 3 &=
mc_virt SLAVE_EBI1 3>,
>                                         <&epss_l3 MASTER_EPSS_L3_APPS &ep=
ss_l3 SLAVE_EPSS_L3_SHARED>;
>                         qcom,freq-domain =3D <&cpufreq_hw 0>;
> @@ -273,6 +281,8 @@
>                                            &CLUSTER_SLEEP_0>;
>                         next-level-cache =3D <&L2_400>;
>                         operating-points-v2 =3D <&cpu4_opp_table>;
> +                       capacity-dmips-mhz =3D <1946>;

Though I don't think it's technically required, in other systems
(including the examples in the documentation) the biggest CPU gets
1024 "capacity-dmips-mhz" and the other ones are scaled to that.


> +                       dynamic-power-coefficient =3D <520>;
>                         interconnects =3D <&gem_noc MASTER_APPSS_PROC 3 &=
mc_virt SLAVE_EBI1 3>,
>                                         <&epss_l3 MASTER_EPSS_L3_APPS &ep=
ss_l3 SLAVE_EPSS_L3_SHARED>;
>                         qcom,freq-domain =3D <&cpufreq_hw 1>;
> @@ -296,6 +306,8 @@
>                                            &CLUSTER_SLEEP_0>;
>                         next-level-cache =3D <&L2_500>;
>                         operating-points-v2 =3D <&cpu4_opp_table>;
> +                       capacity-dmips-mhz =3D <1946>;
> +                       dynamic-power-coefficient =3D <520>;
>                         interconnects =3D <&gem_noc MASTER_APPSS_PROC 3 &=
mc_virt SLAVE_EBI1 3>,
>                                         <&epss_l3 MASTER_EPSS_L3_APPS &ep=
ss_l3 SLAVE_EPSS_L3_SHARED>;
>                         qcom,freq-domain =3D <&cpufreq_hw 1>;
> @@ -319,6 +331,8 @@
>                                            &CLUSTER_SLEEP_0>;
>                         next-level-cache =3D <&L2_600>;
>                         operating-points-v2 =3D <&cpu4_opp_table>;
> +                       capacity-dmips-mhz =3D <1946>;
> +                       dynamic-power-coefficient =3D <520>;
>                         interconnects =3D <&gem_noc MASTER_APPSS_PROC 3 &=
mc_virt SLAVE_EBI1 3>,
>                                         <&epss_l3 MASTER_EPSS_L3_APPS &ep=
ss_l3 SLAVE_EPSS_L3_SHARED>;
>                         qcom,freq-domain =3D <&cpufreq_hw 1>;
> @@ -342,6 +356,8 @@
>                                            &CLUSTER_SLEEP_0>;
>                         next-level-cache =3D <&L2_700>;
>                         operating-points-v2 =3D <&cpu7_opp_table>;
> +                       capacity-dmips-mhz =3D <1985>;
> +                       dynamic-power-coefficient =3D <552>;

The fact that cpu7 has different values for capacity-dmips-mhz and
dynamic-power-coefficient is surprising to me. I think what this means
is that at the same MHz this core can process more instructions than
the other big CPUs but that (at the same MHz) it burns more power
doing so. Is that really true? I thought that this core was
essentially the same as the other big cores but was simply anointed to
be able to run a little faster.


-Doug