Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Mon, 6 Nov 2023 16:54:37 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Brandon Cheo Fusi <fusibrandon13@gmail.com>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: add regmap_update_bits variant to autoshift mask
Message-ID: <ZUkaTcV9cYxKjmap@finisterre.sirena.org.uk>
References: <20231106163406.33952-1-fusibrandon13@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="fDKSb34zooPaposF"
Content-Disposition: inline
In-Reply-To: <20231106163406.33952-1-fusibrandon13@gmail.com>
Precedence: bulk


--fDKSb34zooPaposF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Nov 06, 2023 at 05:34:06PM +0100, Brandon Cheo Fusi wrote:

> +static inline int regmap_update_bits_autoshift_val(struct regmap *map, unsigned int reg,
> +				     unsigned int mask, unsigned int val)
> +{

Really not a fan of the name here, and in any case if the shifting of
the value is an issue wouldn't this be a good case for using a field?

Please also add kunit testcases for new APIs.

--fDKSb34zooPaposF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmVJGksACgkQJNaLcl1U
h9BpPAf7Bnykb22GZAW2TLe5X+BWpxuHcrWH3eKNLm7UAzwl03PmGcFmf8bT1C5q
jF6nSL1PkO1xyNnpdXDPyC7xi+qMhiK4rc7eA9/1wkydf0aXjVIlpr9Thdfk5XpF
yJ+mAPI2RBklovOFxWt6nQJAolu8k4Itfd5WzNXuB/OgrVwVneNzE0CLMZjcoDeM
WBnwKFB/3WaTZ3pIeLrd9UCHuOwdNOIV6hm2/a2LWlafjc656/10VpGfjGXj4mR/
vpwVLgeljfz+FkjFAN/InksjJyOSB/fKRUTRlJ7SWfM/8N7e1MrzUbzehpHKO59y
pkhgAk7dy2Devl2o7A0RMeiP3ylv3w==
=qlyF
-----END PGP SIGNATURE-----

--fDKSb34zooPaposF--