Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <9b1a5e36-337b-4750-9dad-b54e28cde03a@amd.com>
Date:   Mon, 6 Nov 2023 10:59:13 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 6/9] PCI: Rename is_thunderbolt to is_tunneled
Content-Language: en-US
To:     Lukas Wunner <lukas@wunner.de>
Cc:     Karol Herbst <kherbst@redhat.com>, Lyude Paul <lyude@redhat.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Hans de Goede <hdegoede@redhat.com>,
        =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Danilo Krummrich <dakr@redhat.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Xinhui Pan <Xinhui.Pan@amd.com>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Mark Gross <markgross@kernel.org>,
        Andreas Noever <andreas.noever@gmail.com>,
        Michael Jamet <michael.jamet@intel.com>,
        Yehezkel Bernat <YehezkelShB@gmail.com>,
        =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali@kernel.org>,
        =?UTF-8?Q?Marek_Beh=C3=BAn?= <kabel@kernel.org>,
        "Maciej W . Rozycki" <macro@orcam.me.uk>,
        Manivannan Sadhasivam <mani@kernel.org>,
        "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" 
        <dri-devel@lists.freedesktop.org>,
        "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" 
        <nouveau@lists.freedesktop.org>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:RADEON and AMDGPU DRM DRIVERS" 
        <amd-gfx@lists.freedesktop.org>,
        "open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
        "open list:ACPI" <linux-acpi@vger.kernel.org>,
        "open list:X86 PLATFORM DRIVERS" 
        <platform-driver-x86@vger.kernel.org>,
        "open list:THUNDERBOLT DRIVER" <linux-usb@vger.kernel.org>
References: <20231103190758.82911-1-mario.limonciello@amd.com>
 <20231103190758.82911-7-mario.limonciello@amd.com>
 <20231105173946.GA31955@wunner.de>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20231105173946.GA31955@wunner.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVo1WDJOVUtGS3h3cER2Z292U0RGbXFBMVoySHV0Mlp3bXBLR2dwWjlwM3I4?=
 =?utf-8?B?Y2lGblhTckRLZnRyM0ZSQzhaVkRtYW1MUzNNNkx6UkpVUVJSM1FaV3lQMkFF?=
 =?utf-8?B?UWQ4Qm01T1gxNGRoM1RkVUdQUStVZEsrYXorRmRvZDNqdGUzamxGQnRnTVg4?=
 =?utf-8?B?dFljT0FBcjJDM0hpR2xEU3VzZ2N0UG5MRCs5ajJMQ09DVTB4eHFIR2NiT0hn?=
 =?utf-8?B?VHgwTkRGN29KOFNCTTdRampmQk5VNU83SW84dzNtd2xiYjU4MFc2RytRY2x3?=
 =?utf-8?B?a3ZHYm1ORlBqN3dRQm4weERsSTgxK2VlQTVQZ253S1o0K1Yyay9JeWt5UkdH?=
 =?utf-8?B?N2lIZ2xSWEQzaDlKeGdjZlJ6S0hQdlQyb1cxbElhR3VuMXZkV0dxUWZrUnZM?=
 =?utf-8?B?YVdQT3NTV0VEeWw4TThwVUZtdjk5YzcyQlFpMXd6ck5USDZZTG9qUDZUY0dq?=
 =?utf-8?B?MUsvVlVhVDM1dGhLemJtMTAwMGtqN2FDRDAwd1BqODZ5eUlKcVZ2MzYrRmEz?=
 =?utf-8?B?WHlDcXFPQTNqVVNQTkZ2djJwc3puNDBhclpQZEtzZDJCVG45TmNwb0lnc0pi?=
 =?utf-8?B?dXBjYVEzTDRaVlBmN3VZZzMzZXpFQVNRRDMwZzVtdHNKY3JXY2tRc3pTT29w?=
 =?utf-8?B?a2Z1Qld6aXkxT3R2Y2tmQW5nNjRiTGxwdGhLU3N0ek5wZG9hOEUyT1ljWXZE?=
 =?utf-8?B?VFF5bjk3ZjFMd3ZCMnZhV0wvQWlOREFqaDFLN3RjS05abTNCNXFoZU9nOWdX?=
 =?utf-8?B?anByMGt6YXRxYWlBSGR0WHRRYmlCVHV1ckRrdFJ3SXpUWkQwbUhwcjFpLzg4?=
 =?utf-8?B?L2VxdndlemlMb0hZL0RBVndjWWtoenJYd1I2UjVYVHJ5OHU3VFBvQ3hPaElV?=
 =?utf-8?B?REZGRzI3NXZrVWM3M09UNkRmRFFrR0x1NmRhcnVUeldIOUtsN1JEUHg1ckZp?=
 =?utf-8?B?OTUwUlhiQlpXYVkwQVNJcVE2OFh0MXc2anlVclFzOEQ5aWJ4SDJybFlrOTJW?=
 =?utf-8?B?L0kweU16ZDZzcG5vSkVOUE12bS9jSUhJY1lnK2lxdHJlbDFMWVljWm9YSUNm?=
 =?utf-8?B?MFhtd0o5ai9VcUFOVngxbFlmaWtkTklWY1BXdGduaENYRkRkQm4zZFhINmlm?=
 =?utf-8?B?VDlYb3RtR1ZVemdSSm1OVnN2Vm1ycVR5NGFONm5uVlpJUmFaNTAvSWVTaTVq?=
 =?utf-8?B?OWcwWDA1cnpFMXBPcjhLWDhZNEpuUzJ2R0RuOVN0a2pLa2lDQVBaUVg5clc4?=
 =?utf-8?B?TDczR1RaZGNDTmtPSXh2OEdTelBKK2JZeGdSVC8xQUpPMitrdlJidFVWdDJv?=
 =?utf-8?B?T25FNndWUW0vbE5QRU5oRk5UdkxDWEh0ejEwMTl4Q1U3VkdBV3BUOXZWOTky?=
 =?utf-8?B?Q2IrZFFXV0QxbnZ2alpqV1YwWE9ZTjFpNVMwSGJ4YXlxZkZRT1hGci9tNmZN?=
 =?utf-8?B?RFF5MXZxTmN1TWU5a2RScTJEVE9la1VlZGJ2S0ptUEF1T1ZwNkdMR1FxVWZC?=
 =?utf-8?B?Vm5nYWJrcWdKYjhYMmtmME9nbTBhZ2V6K0xmaE1QSDRsZmhLWXI4WHRDZDlY?=
 =?utf-8?B?dDFNWmFVd2dKZTJQVnVaZmZ4VktxUXJFdXBQbURjNjFxY2g1OHQyWFdVYnF1?=
 =?utf-8?B?dVRKNk9XOEVaVDZDZmhNZUZWL0E4cjMxS3ZBNVFCNGxKTklUeWJsTlRvZXRx?=
 =?utf-8?B?d3g1TXRialRJdVNIS21QU0dTSFN0QWtWWFZQeXBSdHJQd1d3QnZTZVBXekJh?=
 =?utf-8?B?a1hUSWVDdE95TnJTVDFZRXRKNmMrMUhUZ3JHaHREL09nclpPbEJVSVQzdGdQ?=
 =?utf-8?B?dkw4a3BwTlhpWDNTRkhqME92L0hQSmJtNUtoVXRhM0F6WlpjdWowcmY5TzdI?=
 =?utf-8?B?Y0pRTDViWmV5NnlydVFhem1HL3ZHVWFLcUhtSkw1UU5sYnNXb0pJWm81SWQw?=
 =?utf-8?B?UmRwdGl5cHBqSW9yeUg0c0l4ZXEwRFlnRWZ5V252T0lIR2JGd1RhdUFLWUVK?=
 =?utf-8?B?L2lraUlrczV0eXVRV0JuNGFQZXV2d25uQUJEbFZOMEU5NTlEMlZBZGxaVitT?=
 =?utf-8?B?WVEwelg2djNXaW5CMGZKNjBNL081bHF3Yzh0R1FqdldsZGJXT3UwaU50enE3?=
 =?utf-8?Q?V9fHI8bLiebJdylVPqUglJ6hO?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97f51e6b-f870-4531-a580-08dbdee9b6d6
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2023 16:59:18.0995
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nmKEfuiiQxg97LxE1t/pGMHuA/Qfw/C0XLsYQR8X4IOI+/ZGRJYwrW8E6grWW6AU0a6qMHpVxmQ1b4DibyXBjw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5806
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 06 Nov 2023 08:59:35 -0800 (PST)

On 11/5/2023 11:39, Lukas Wunner wrote:
> On Fri, Nov 03, 2023 at 02:07:55PM -0500, Mario Limonciello wrote:
>> The `is_thunderbolt` bit has been used to indicate that a PCIe device
>> contained the Intel VSEC which is used by various parts of the kernel
>> to change behavior. To later allow usage with USB4 controllers as well,
>> rename this to `is_tunneled`.
> 
> This doesn't seem to make sense.  is_thunderbolt indicates that a device
> is part of a Thunderbolt controller.  See the code comment:
> 
>> -	unsigned int	is_thunderbolt:1;	/* Thunderbolt controller */
> 
> A Thunderbolt controller is not necessarily tunneled.  The PCIe switch,
> NHI and XHCI of the Thunderbolt host controller are not tunneled at all.
> 
> Thanks,
> 
> Lukas

I could really use some clarification which PCIe devices actually 
contain the Intel VSEC.

Is it in all 3 of those PCIe devices and not just the switch?

If so, I think I would rather introduce a separate bit.  So after this 
series we would have:

is_tunneled:1
is_thunderbolt:1
no_command_complete:1

* TBT1 devices would set no_command_complete
   - The consumer would be pcie_init()
* All devices with the Intel VSEC would set is_thunderbolt and the two 
consumers would be:
  - apple-gmux.c
  - pci_bridge_d3_possible()
* USB4 devices and PCIe switches with the VSEC would set is_tunneled.