Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp2266755rdf; Mon, 6 Nov 2023 09:06:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IERdyqAp4CycXaML6TFNRFsIrT5ktFBj6YN2btIfyVxAHJLidqnIIIeTfag6pA1MSe0kwsR X-Received: by 2002:a05:6870:1157:b0:1d5:a303:5f39 with SMTP id 23-20020a056870115700b001d5a3035f39mr269026oag.49.1699290385639; Mon, 06 Nov 2023 09:06:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699290385; cv=none; d=google.com; s=arc-20160816; b=gGbJY4yqy4GxAQSMGKoSC/ziOAEN5pyiTTVock0h+OQfqDBq5wO/XdhNOAW0kM3PAs jmxju5NYKcyZmxlZsbS7pWwNeiRbgJwRRa2i8tGRTRc9xw7vxVrs6SksB4v7zGxQdUKB lZ7RdxhMZ1W58oQOdTfCqocpB47bm1n3n9aBzdcEliORoie087YgKQ58iEycEmU2zvY1 iOo9NHOCXSjiJDDdhF/2GBpVUGjYzbdlI+LHZxF/drOCh+41C9l6c+2qXg05kdMBjbil c+5QzBGj95JRzwVgCCmweaqnmP/+lumBRxmrNUzsi0ZhMeb3Rq4JymTro85wcbEwXHUx uV9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=pZ3oZu5FL3iDnulyvyRySUZ+OPqqpbFeLzlANOh/grc=; fh=NyvNrJ6p0Op8d1xqi6HRC9u96ucO6ma2Na91oqKldnc=; b=RbN4joniPoOlYgIjz5rR8nQulW3A9xMluGmYxXX7v5XemOlWdwDTCsVcp49c3KMFWs dgJmAz60YU8VJRUcLTQDOPYdCYFqJinTHiWu8SmCAq6U+tDCVZQ0FMS+s67q3yj81dRJ yy5iuFzGuhEOF/meEX8nMaj8YmgqCduJ5mZ4eyHiM9QQqvDeYWZC2gC3V3F1gF2n9C9s 8gkH/nhe2uYgg/DwK4QFTkZr/WFcSZxCHRqfChno4sWZhuW0HaKjU2R2YK4j0dTtgXDW KI7HRjMW/OxjvmLHErmeMNRArn4/DG5fdfUMK0RMJj2+4kbrafpkQzEGf5OQfY4vhbdj eG3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=s52TttkO; dkim=neutral (no key) header.i=@linutronix.de header.b=RKv6GAwc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id u4-20020a056870420400b001e9ff0ff72esi3491061oac.335.2023.11.06.09.06.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 09:06:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=s52TttkO; dkim=neutral (no key) header.i=@linutronix.de header.b=RKv6GAwc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 45FEC8038B04; Mon, 6 Nov 2023 09:06:23 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232929AbjKFRGP (ORCPT + 99 others); Mon, 6 Nov 2023 12:06:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232948AbjKFRGL (ORCPT ); Mon, 6 Nov 2023 12:06:11 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F5D7D4D for ; Mon, 6 Nov 2023 09:06:04 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1699290362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pZ3oZu5FL3iDnulyvyRySUZ+OPqqpbFeLzlANOh/grc=; b=s52TttkOLnmZQGf7EPUklZuD0TXWk1gi1FMyXTNlJF/jgcfVkOveVLztrr9osQj5L7n3ml 4fUJj6sFZjs0Fiw2O0DYChfLBs/mhNCM2u4rZeBU8Rw8SnZsaI7ckKMwr2geCPhAeSiwYd eGKmuUJ8k2/f5p4JtJ/X3ng/C5uN4VPrrCsMBtKiz+qlxMGf+SxMzLeKr/8DT9nPxj2MG0 NzR87j5qU179UTyRhW60pdwz6aSyYidvOaASlB/+1Fk/BBDZfmkt/Zclyk0IxsZx789P8E I5w3vmmtU0wd3oFuH5757y8RkEaq+NN0AvK/A3L6xJi38645+ffVys8Y5Y5FLQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1699290362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pZ3oZu5FL3iDnulyvyRySUZ+OPqqpbFeLzlANOh/grc=; b=RKv6GAwcsVU207jCbt5AH8f2VwnTBfhmN+igtJzZNO1st0+sbTaaE0gPIMzD3pNQCWJzSh su3nsfnmP0zq8KBQ== To: James Tai , linux-kernel@vger.kernel.org, linux-realtek-soc@lists.infradead.org Cc: Marc Zyngier Subject: Re: [PATCH 3/6] irqchip: Introduce RTD1319 support using the Realtek Common Interrupt Controller Driver In-Reply-To: <20231102142731.2087245-4-james.tai@realtek.com> References: <20231102142731.2087245-1-james.tai@realtek.com> <20231102142731.2087245-4-james.tai@realtek.com> Date: Mon, 06 Nov 2023 18:06:01 +0100 Message-ID: <87r0l2hkw6.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 06 Nov 2023 09:06:23 -0800 (PST) On Thu, Nov 02 2023 at 22:27, James Tai wrote: > + > +enum rtd1319_iso_isr_bits { > + RTD1319_ISO_ISR_TC3_SHIFT = 1, > + RTD1319_ISO_ISR_UR0_SHIFT = 2, Please use tabular formatting all over the place. > + RTD1319_ISO_ISR_LSADC0_SHIFT = 3, > + RTD1319_ISO_ISR_IRDA_SHIFT = 5, > + > +static const struct realtek_intc_info rtd1319_intc_iso_info = { > + .isr_offset = 0x0, > + .umsk_isr_offset = 0x4, > + .scpu_int_en_offset = 0x40, Magic numbers. Defines exist for a reason.