Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
MIME-Version: 1.0
References: <20231106130309.112650042@linuxfoundation.org> <2665d8bc-111c-45ca-a473-b1c892867e9c@oracle.com>
In-Reply-To: <2665d8bc-111c-45ca-a473-b1c892867e9c@oracle.com>
From:   Allen Pais <stable.kernel.dev@gmail.com>
Date:   Mon, 6 Nov 2023 09:08:20 -0800
Message-ID: <CAJq+SaCqtQwk+eCgXT9jQU33Ufqr+aOaQq+VsXHCqdc1Qp8Vkg@mail.gmail.com>
Subject: Re: [PATCH 5.15 000/128] 5.15.138-rc1 review
To:     Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        stable@vger.kernel.org, Sasha Levin <sashal@kernel.org>,
        mizhang@google.com, patches@lists.linux.dev,
        linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
        akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org,
        patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de,
        jonathanh@nvidia.com, f.fainelli@gmail.com,
        sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de,
        conor@kernel.org, Vegard Nossum <vegard.nossum@oracle.com>,
        Darren Kenny <darren.kenny@oracle.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

>
> On 06/11/23 6:32 pm, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.15.138 release.
> > There are 128 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Wed, 08 Nov 2023 13:02:46 +0000.
> > Anything received after that time might be too late.
> >
>
> I am seeing a build failure with perf:
>
> tools/perf/util/evlist.c: In function evlist__add_aux_dummy:
> tools/perf/util/evlist.c:266:31: error: implicit declaration of function
> evlist__dummy_event; did you mean evlist__add_sb_event=C3=A2=E2=82=AC=E2=
=84=A2?
> [-Werror=3Dimplicit-function-declaration]
>    266 |         struct evsel *evsel =3D evlist__dummy_event(evlist);
>        |                               ^~~~~~~~~~~~~~~~~~~
>        |                               evlist__add_sb_event
>
>
> I think we should drop these three commits:
>
> 20a5799cae7dc perf evlist: Avoid frequency mode for the dummy event
> 7de783c81c7e7 perf tools: Get rid of evlist__add_on_all_cpus()
> 141ce9207068e perf evlist: Add evlist__add_dummy_on_all_cpus()
>
> Backport was requested here:
> https://lore.kernel.org/stable/CAL715WLTjMGQrhm6wWqFSeL_Oq-HzoQd5CqewvLRL=
v0Xbnibgw@mail.gmail.com/
>


 Just tested perf build, I see the same errors:

tools/perf/util/evlist.c: In function 'evlist__add_aux_dummy':
/linux/tools/perf/util/evlist.c:266:24: error: implicit declaration of
function 'evlist__dummy_event'; did you mean 'evlist__add_sb_event'?
[-Werror=3Dimplicit-function-declaration]
  struct evsel *evsel =3D evlist__dummy_event(evlist);
                        ^~~~~~~~~~~~~~~~~~~
                        evlist__add_sb_event
linux/tools/perf/util/evlist.c:266:24: error: initialization makes
pointer from integer without a cast [-Werror=3Dint-conversion]

Thanks,
Allen