Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <f97c86a6-34d3-45e1-8673-8a3f02f88392@quicinc.com>
Date:   Mon, 6 Nov 2023 09:35:55 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/3] drm/ci: Add support for SM8250 Gitlab Runner
Content-Language: en-US
To:     Helen Koike <helen.koike@collabora.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>
CC:     <robdclark@chromium.org>, <quic_abhinavk@quicinc.com>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        <freedreno@lists.freedesktop.org>
References: <20231010-rb5-runner-v1-0-aba1fcc6e3aa@quicinc.com>
 <0b0b1065-06e8-44ea-a4a1-395980afac5a@collabora.com>
From:   Jessica Zhang <quic_jesszhan@quicinc.com>
In-Reply-To: <0b0b1065-06e8-44ea-a4a1-395980afac5a@collabora.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 11/4/2023 6:02 AM, Helen Koike wrote:
> Hi Jessica,
> 
> On 10/10/2023 19:25, Jessica Zhang wrote:
>> Recently, we've registered a Gitlab runner for a Qualcomm RB5 device 
>> that will be
>> hosted and maintained in Qualcomm labs.
>>
>> This series will add a corresponding CI job for testing SM8250 devices 
>> and add the
>> skip/fails/flakes list. We were able to complete a successful run [1] 
>> with these
>> changes.
>>
>> For now, we will keep the job as manual trigger only and drop that 
>> rule later
>> after we stabilize the tests.
>>
>> [1] https://gitlab.freedesktop.org/drm/msm/-/jobs/50092719
>>
>> ---
> 
> Thank you for you patchset.
> 
> I'm getting the following error:
> 
> "serial.serialutil.SerialException: [Errno 2] could not open port 
> /dev/ttyUSB0: [Errno 2] No such file or directory: '/dev/ttyUSB0'"
> 
> https://gitlab.freedesktop.org/helen.fornazier/linux/-/jobs/51193215#L146
> 
> I'm wondering if I'm missing some configuration.
> 
> I tested on top of drm-misc-next.

Hi Helen,

Sorry for the inconvenience, but I had to temporarily take down the 
runner last Friday to physically move the setup (as part of a 
reorganization of our lab here).

I'll update this thread as soon as the runner is back up -- the move 
will be complete by the end of this week.

> 
> Also, I'd like to add in the docs an entry about the devices we have, 
> which tag they need, which dts they correspond to, which farm they are 
> located, who to contact if there is any problem and maybe some comment 
> about the device (how it is hooked up, the logs comes from uart or ssh, 
> does it use fastboot, etc) if you find it useful.
> Would you mind adding an entry in the docs with this information for the 
> sm8250? (Than I'll add the info of the other devices after yours).

Sure, sounds good.

> 
> 
>> Jessica Zhang (3):
>>        drm/ci: Add SM8250 job to CI
> 
> I would also move this patch to last, so we don't have a commit where 
> things shouldn't work properly.
> Or maybe squash them all.

Acked -- I'll move this patch to the end.

Thanks,

Jessica Zhang

> 
> Regards,
> Helen
> 
>>        drm/ci: enable CONFIG_INTERCONNECT_QCOM_SM8250 for arm64 config
>>        drm/ci: Add skips, fails and flakes for SM8250
>>
>>   drivers/gpu/drm/ci/arm64.config                 |  1 +
>>   drivers/gpu/drm/ci/build.sh                     |  1 +
>>   drivers/gpu/drm/ci/test.yml                     | 15 +++++++++++++
>>   drivers/gpu/drm/ci/xfails/msm-sm8250-fails.txt  | 29 
>> +++++++++++++++++++++++++
>>   drivers/gpu/drm/ci/xfails/msm-sm8250-flakes.txt |  3 +++
>>   drivers/gpu/drm/ci/xfails/msm-sm8250-skips.txt  |  8 +++++++
>>   6 files changed, 57 insertions(+)
>> ---
>> base-commit: dcd88f8c63341ed11a8c5019408f62202cd9d1f2
>> change-id: 20230919-rb5-runner-77ec32bd61e7
>>
>> Best regards,