Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
MIME-Version: 1.0
References: <202311051347.7J6bthD7-lkp@intel.com>
In-Reply-To: <202311051347.7J6bthD7-lkp@intel.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 6 Nov 2023 20:07:00 +0200
Message-ID: <CAHp75VcKj_zFNZTkipdJokzZWoWUk5M2RyWO-=49VbmUmt6-Pw@mail.gmail.com>
Subject: Re: drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined
 but not used
To:     kernel test robot <lkp@intel.com>, Peter Rosin <peda@axentia.se>
Cc:     Chris Packham <chris.packham@alliedtelesis.co.nz>,
        oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
        Mark Brown <broonie@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

(Resend to all)

On Sun, Nov 5, 2023 at 7:03=E2=80=AFAM kernel test robot <lkp@intel.com> wr=
ote:
>
> Hi Chris,
>
> First bad commit (maybe !=3D root cause):

Indeed.

>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.gi=
t master
> head:   aea6bf908d730b01bd264a8821159db9463c111c
> commit: e9e40543ad5b38b848879768359fd13650529961 spi: Add generic SPI mul=
tiplexer
> date:   3 years, 9 months ago
> config: i386-randconfig-004-20231101 (https://download.01.org/0day-ci/arc=
hive/20231105/202311051347.7J6bthD7-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/archi=
ve/20231105/202311051347.7J6bthD7-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new vers=
ion of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202311051347.7J6bthD7-lkp=
@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/mux/adg792a.c:134:34: warning: 'adg792a_of_match' defined but =
not used [-Wunused-const-variable=3D]
>      134 | static const struct of_device_id adg792a_of_match[] =3D {
>          |                                  ^~~~~~~~~~~~~~~~
>

I dunno why it's pointing out to that commit and some (random?) people
in Cc list, but the real problem there from day 1, i.e. (ab)using
of_match_ptr(). The of_match_ptr() should not ever be used. It appears
more harmful than useful.

Hence the proper fix is to drop of_match_ptr() in this file.


> vim +/adg792a_of_match +134 drivers/mux/adg792a.c

--=20
With Best Regards,
Andy Shevchenko