Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
MIME-Version: 1.0
References: <20231024181134.48066-1-bragathemanick0908@gmail.com>
In-Reply-To: <20231024181134.48066-1-bragathemanick0908@gmail.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 6 Nov 2023 13:35:37 -0500
Message-ID: <CADnq5_OS+15+u-4w3Ca9Q+ivm8U1P=6r-pOrC9fCbZSAUR=5hA@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/display: avoid variable reinitialization
To:     Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
Cc:     harry.wentland@amd.com, sunpeng.li@amd.com,
        Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, daniel@ffwll.ch,
        airlied@gmail.com, Qingqing.Zhuo@amd.com, alvin.lee2@amd.com,
        wenjing.liu@amd.com, jun.lei@amd.com, Samson.Tam@amd.com,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Tue, Oct 24, 2023 at 2:11=E2=80=AFPM Bragatheswaran Manickavel
<bragathemanick0908@gmail.com> wrote:
>
> The member variable enable_hpo_pg_support is already initialized
> and hence the reinitialization instruction can be removed. Issue
> identified using the doubleinit.cocci Coccinelle semantic patch script.
>
> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c b/driv=
ers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
> index 99d55b958977..1fd9df8da09c 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
> @@ -739,7 +739,6 @@ static const struct dc_debug_options debug_defaults_d=
rv =3D {
>         .disable_boot_optimizations =3D false,
>         .disable_unbounded_requesting =3D false,
>         .disable_mem_low_power =3D false,
> -       .enable_hpo_pg_support =3D false,
>         //must match enable_single_display_2to1_odm_policy to support dyn=
amic ODM transitions
>         .enable_double_buffered_dsc_pg_support =3D true,
>         .enable_dp_dig_pixel_rate_div_policy =3D 1,
> --
> 2.34.1
>