Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp2344416rdf; Mon, 6 Nov 2023 11:12:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IFVuHvmt6ZFlPC2G/urIHmXCmAGzL5UYho1MzsVhVxfHmTZz2mi/dVICOoFG14zWk5YxtWe X-Received: by 2002:a17:903:11c4:b0:1cc:6e8f:c14d with SMTP id q4-20020a17090311c400b001cc6e8fc14dmr18237111plh.50.1699297926389; Mon, 06 Nov 2023 11:12:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699297926; cv=none; d=google.com; s=arc-20160816; b=WAsKQj+Cim92ur4iHjZGzjttCWh7/nOQwJaYo9WfpIvNTtqUhKp90RwY0gSSDV/Dk9 VhImTycQr8Boq4kSNYHRf8glKxFPTHnA/Qk0MCeyaMTUeE4sKLsBUqp7Tg6XH2ea4fFB YsbZWjj1y3O8rEbiMk/52IUJ490RVCX2t4pgxqGMP6HbVxFZ+XuEQJZUC8jfnftled7U hpzTzwvQf5C3e6R0wox1EJRwz26+Q987+SuRWgaP/hTVVPp53jANA24t9k6v9DFNWlmx zyXfiDclnseVfFS9ICWRaym581mTNP27jsKP0yTpAc7ckUkDjtRLzsF7Eql1fnaQKccx opFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:to:content-language:subject:user-agent:mime-version :date:message-id:sender:dkim-signature; bh=zjxyr63IgmgRdCkCZDYvIKtFKHrkFcVGXga7i17d8lg=; fh=Xie/nU3lBHlo196JwbXeZSmWIynhv4CYHSGLqX4b0kw=; b=TaEx2OTTccFeYrBvz60WBGoFhrJU2DF12nC5Ohd46HVA+EPz9rnFDIYBOenbnJl6aL 6tWlIQyIkvJDCTXhycnauRnMRCHdmUML3JUpvHcozAoKBmhDl9BepyeunX5+b/4JYlFa Vnm2/hf/vaG4X3B4aRXj653bgxHP++4VFMd/acjUgNvRCP03QW5GgUUSnMw/15pXSelC atpC7FJk4yyWLysvMqzko7IhJDxqHbTW5fq+rEceofbLoxOT+PXsXhD/4Y2jjtq+nStn 5oixbOj8X8cvLEeByc3xJ86qoQ517xLjriw2EHPGMPqsTO6O76eKch+dDXp4I8/7LrMw A5/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ALb6jTxQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id u15-20020a17090341cf00b001c9e765e151si9598089ple.116.2023.11.06.11.12.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 11:12:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ALb6jTxQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id C88CB803319B; Mon, 6 Nov 2023 11:12:03 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232329AbjKFTMA (ORCPT + 99 others); Mon, 6 Nov 2023 14:12:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231801AbjKFTL7 (ORCPT ); Mon, 6 Nov 2023 14:11:59 -0500 Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDF87A2; Mon, 6 Nov 2023 11:11:50 -0800 (PST) Received: by mail-ot1-x335.google.com with SMTP id 46e09a7af769-6ce2b6b3cb6so3171393a34.3; Mon, 06 Nov 2023 11:11:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699297910; x=1699902710; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=zjxyr63IgmgRdCkCZDYvIKtFKHrkFcVGXga7i17d8lg=; b=ALb6jTxQKM7zfcw08Ep7fbsuMV6lXmIOdP4eclZKq1eCRe3CLGSB4hHqE1E+2e2hn+ pvHM361dii4RjT10HXeu/fxCKQakL6kBTXILw/DIUyMB/qAz+uvA+RMCKlXAHtWI/Shd ksez47NXNPbIpkWqGwKDYYOorBl85Jdr3hHqBh0/wk/qu1+13RW7unKR8mQc+pmBF1LR eauZLrCepiADoSJEkc++oWBnKcRz6e3geHIqvQIIVIwcIZVOOSFXGpYm0NCbDeaDpJpI yF9pZlccCRi1U5GqUY0lsmG7d8ypnTmGrEyltGhZfzJoWvumugs37gPmOP63HcirNbLI eAkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699297910; x=1699902710; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zjxyr63IgmgRdCkCZDYvIKtFKHrkFcVGXga7i17d8lg=; b=qbVhIruzz9fX7LLynQlkSqeN7QZjZmhod/OKXn8reRW3UZQjGD7Re1Q97evXp540tC IpHYzk9/wJTQvoePigXb8CGiDkUHUQNKts12Yfpko7p/mgvDtxV4bQIZ8cUHOlxEv4zn ZimsNf/sjpF+wx8za0SfhKYA0ztd6FLVIqTYqQPg56TFqdb7r/PbpIRlIkrUPyMhBDWe 6bb7l8ru74taLfrh2kqH1Joz4Lno6oaqek6dQ+mYMB60TyB+siyqbgIIUJ0oPDUJd6K5 G/2teHmkP1j9cZeAVu3EYBxzzt+q3cfs1JBG5Tse3t6wmX9cj5stoS7peyeMheqdau4i almQ== X-Gm-Message-State: AOJu0YxzqhbcrpmD6KvTqUHjeXqdH481gjOsGJc0ZuDwVh3xKQVb4F3v F13Ly1Nd2WTe+a5Xs/kKs+M= X-Received: by 2002:a05:6358:5e16:b0:169:7f96:7f84 with SMTP id q22-20020a0563585e1600b001697f967f84mr17713052rwn.1.1699297909983; Mon, 06 Nov 2023 11:11:49 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id h24-20020a63e158000000b005af9dcb4756sm119952pgk.42.2023.11.06.11.11.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Nov 2023 11:11:48 -0800 (PST) Sender: Guenter Roeck Message-ID: Date: Mon, 6 Nov 2023 11:11:47 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] hwmon: (pmbus) Add support for MPS Multi-phase mp5990 Content-Language: en-US To: PeterYin , patrick@stwcx.xyz, Jean Delvare , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20231103080128.1204218-1-peteryin.openbmc@gmail.com> <20231103080128.1204218-3-peteryin.openbmc@gmail.com> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 06 Nov 2023 11:12:03 -0800 (PST) On 11/6/23 00:02, PeterYin wrote: > [ ... ] >>> + >>> +static const struct of_device_id mp5990_of_match[] = { >>> +    { .compatible = "mps,mp5990" }, >>> +    {} >>> +}; >>> + >>> +static const struct i2c_device_id mp5990_id[] = { >>> +    {"mp5990", 0}, >>> +    { } >>> +}; >>> +MODULE_DEVICE_TABLE(i2c, mp5990_id); >>> + >>> +static struct i2c_driver mp5990_driver = { >>> +    .driver = { >>> +           .name = "mp5990", >>> +           .of_match_table = of_match_ptr(mp5990_of_match), >> >> Using of_match_ptr() will result in a build failure if CONFIG_OF=n. >> > Should I use .of_match_table = mp5990_of_match, ? > Yes. Thanks, Guenter