Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <c4abc49c31643baa34bf889d689e8c587c28da54.camel@sipsolutions.net>
Subject: Re: [PATCH] devcoredump: Send uevent once devcd is ready
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Greg KH <gregkh@linuxfoundation.org>,
        Mukesh Ojha <quic_mojha@quicinc.com>
Cc:     rafael@kernel.org, linux-kernel@vger.kernel.org
Date:   Mon, 06 Nov 2023 20:37:33 +0100
In-Reply-To: <2023110659-december-cranium-c98e@gregkh>
References: <1699280735-31482-1-git-send-email-quic_mojha@quicinc.com>
         <2023110659-december-cranium-c98e@gregkh>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-11-06 at 20:36 +0100, Greg KH wrote:
> On Mon, Nov 06, 2023 at 07:55:35PM +0530, Mukesh Ojha wrote:
> > dev_coredumpm() creates a devcoredump device and adds it
> > to the core kernel framework which eventually end up
> > sending uevent to the user space and later creates a
> > symbolic link to the failed device. An application
> > running in userspace may be interested in this symbolic
> > link to get the name of the failed device.
> >=20
> > In a issue scenario, once uevent sent to the user space
> > it start reading '/sys/class/devcoredump/devcdX/failing_device'
> > to get the actual name of the device which might not been
> > created and it is in its path of creation.
> >=20
> > To fix this, suppress sending uevent till the failing device
> > symbolic link gets created and send uevent once symbolic
> > link is created successfully.
> >=20
> > Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
>=20
> What commit id does this fix?=C2=A0
>=20

I guess the original introduction.

>  What in-kernel driver does this affect
> that is using devcoredump?
>=20

All of them really, it's really about how fast userspace is to access it
after the event.

Looks fine to me, FWIW, but a Fixes tag wouldn't hurt.

johannes