Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp2360744rdf; Mon, 6 Nov 2023 11:44:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IGJ5I8F1npPt04ZQIA8L14QdkvnxWMGFExklTRInK0OHZk4wpjhkoWJYzqBGKmnYD2RLI8K X-Received: by 2002:a05:6a20:3d85:b0:181:78ef:dc90 with SMTP id s5-20020a056a203d8500b0018178efdc90mr13369518pzi.13.1699299876067; Mon, 06 Nov 2023 11:44:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699299876; cv=none; d=google.com; s=arc-20160816; b=qPK3bm5M9sLF0r7Rv7iThvOtyYXMvHP8CWJfOu7N94MWYsqeP+n1idodOL86w1Kw1x b8+r0dllpfJPQW3hGSNoz6OpWO4Hpq5ke2vnNeFZTjkIAo7DiYoWT0fMP3gb1xxNtn2G v6qpgEv7PrjfNOC7/D4G05WydDTkFu0RLsOjRgFMOjD998QgFaPC7pLcZ6pWybUQsLg0 7w8FmCUvIgn/cuHQPnh0CF8Ka8R46bdq0tlPnJkrd9iFHEwrCFchrNrtPRZuEmBG7s/Q IV6jUNwV8mjZdttqFLjycOnnyEsiJLXcooelRmX9maxii9ufsdgNzHnmMHnEBibfSFgN 97Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :in-reply-to:from:references:cc:to:content-language:subject :user-agent:date:message-id:dkim-signature; bh=6lQnPtAuDs1yRDYUZNA0X4oNLITc1jI3WcvtpB0zAlw=; fh=Apu8gx1sm5KS+pjOm9YIZuR/Git8Ri64zlRpdhPjGxs=; b=f9j8zJ88kF2DDKT5DN60g6qUIwa/6T/K1pVs5qYO5BNr7KA27a1GtyF1+tz9go13io mWMehzk7ULXWnFyAS3zDmdJ3/PsxxiHKS9fgD8ph1GM6s5vKhYLeHc2kWk6aXk4DWzEA 3M0dv9x7HOg5z01r8XoTvRoxQFdPJBpuip0j5EycANCe0MubL/R2ilDKi4ZGb9YoWr+E NwJFz8dctg9Sq255/ULZ9JKsoj0QqB5vV32FmmbTCzJM3GR4xpz2GO4MJlmX4xKq23pr 6xyTr1zFQYjjcKSJKbkCdmBgPpZL+x4svRekDUgCZWsRTGObsAwz/JsvhfIOzfThwm2J 1GoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=QXZgfynS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id h23-20020a17090aa89700b0027ce6cd3144si8973470pjq.126.2023.11.06.11.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 11:44:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=QXZgfynS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id BF1498065339; Mon, 6 Nov 2023 11:44:33 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232774AbjKFTo0 (ORCPT + 99 others); Mon, 6 Nov 2023 14:44:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231555AbjKFToZ (ORCPT ); Mon, 6 Nov 2023 14:44:25 -0500 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8ACC6125; Mon, 6 Nov 2023 11:44:21 -0800 (PST) Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3A6JeLZJ023059; Mon, 6 Nov 2023 19:44:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=6lQnPtAuDs1yRDYUZNA0X4oNLITc1jI3WcvtpB0zAlw=; b=QXZgfynS6iAtYhsOyd7HmwwL/ddVN705GW9VN8pEFsZLU3jV4Uzslx7Cb3oCvSSvZyH5 cQrsDuh0dotyKURYNbxGre3Zri4Ez1mzG6Wt5i0paCLjw73g8tqhrj2xxA6KDLqdDjDd Qs9Q2lxax5KtmL0gVuA/1nsIyHAZ+WYwyFLrmaV5yXBqVUW/1WpsDNT8CmuKLqydWT79 Y1GmsEzfBuQaVGO+JVIfHpgLTOQYGa/7bQmyagmJf62mTxhIyl5yEsEgfdh3GtQyOVPs Vi3OoLFY8fdfQqI4e49flyGn0rJeINgkGU6M1/B8ZSkbgslnDqDXoOD9Fc4CvfSjBLXf 2Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3u76gkg3ep-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Nov 2023 19:44:15 +0000 Received: from m0353723.ppops.net (m0353723.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3A6JeX4K023381; Mon, 6 Nov 2023 19:44:15 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3u76gkg3dw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Nov 2023 19:44:14 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3A6HPkZT028230; Mon, 6 Nov 2023 19:44:14 GMT Received: from smtprelay04.dal12v.mail.ibm.com ([172.16.1.6]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3u62gjuaqf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Nov 2023 19:44:14 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay04.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3A6JiDQE20644526 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Nov 2023 19:44:13 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9D26358067; Mon, 6 Nov 2023 19:44:13 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E9A6D58056; Mon, 6 Nov 2023 19:44:12 +0000 (GMT) Received: from [9.47.158.152] (unknown [9.47.158.152]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTPS; Mon, 6 Nov 2023 19:44:12 +0000 (GMT) Message-ID: Date: Mon, 6 Nov 2023 14:44:12 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fs: Pass AT_GETATTR_NOSEC flag to getattr interface function Content-Language: en-US To: Christian Brauner , amir73il@gmail.com, Stefan Berger Cc: linux-unionfs@vger.kernel.org, miklos@szeredi.hu, syzbot+a67fc5321ffb4b311c98@syzkaller.appspotmail.com, Alexander Viro , linux-fsdevel@vger.kernel.org, Tyler Hicks , Mimi Zohar , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231002125733.1251467-1-stefanb@linux.vnet.ibm.com> <20231010-erhaben-kurznachrichten-d91432c937ee@brauner> From: Stefan Berger In-Reply-To: <20231010-erhaben-kurznachrichten-d91432c937ee@brauner> Content-Type: text/plain; charset=UTF-8; format=flowed X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: gSqzhJehY9bxuE4KRXjUZVNnUI4SZ_11 X-Proofpoint-GUID: fPkaI9lKmqP-HtzBlQ-ahemvBEgOQOBg Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-06_15,2023-11-02_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 adultscore=0 clxscore=1011 spamscore=0 malwarescore=0 mlxlogscore=836 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310240000 definitions=main-2311060162 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 06 Nov 2023 11:44:33 -0800 (PST) On 10/10/23 04:35, Christian Brauner wrote: > On Mon, 02 Oct 2023 08:57:33 -0400, Stefan Berger wrote: >> When vfs_getattr_nosec() calls a filesystem's getattr interface function >> then the 'nosec' should propagate into this function so that >> vfs_getattr_nosec() can again be called from the filesystem's gettattr >> rather than vfs_getattr(). The latter would add unnecessary security >> checks that the initial vfs_getattr_nosec() call wanted to avoid. >> Therefore, introduce the getattr flag GETATTR_NOSEC and allow to pass >> with the new getattr_flags parameter to the getattr interface function. >> In overlayfs and ecryptfs use this flag to determine which one of the >> two functions to call. >> >> [...] > > Applied to the vfs.fixes branch of the vfs/vfs.git tree. > Patches in the vfs.fixes branch should appear in linux-next soon. Did something happen to this patch? I do not see it in your branch nor the linux-next one nor Linus's tree. > > Please report any outstanding bugs that were missed during review in a > new review to the original patch series allowing us to drop it. > > It's encouraged to provide Acked-bys and Reviewed-bys even though the > patch has now been applied. If possible patch trailers will be updated. > > Note that commit hashes shown below are subject to change due to rebase, > trailer updates or similar. If in doubt, please check the listed branch. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git > branch: vfs.fixes > > [1/1] fs: Pass AT_GETATTR_NOSEC flag to getattr interface function > https://git.kernel.org/vfs/vfs/c/6ea042691c74