Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp2394191rdf; Mon, 6 Nov 2023 12:53:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IF7+7GGvcmRg+cTzeFkC0dwlEFQxRr8qmrYBVCsO97HsmneCMTbhfoJ0qoocMFBFbgx+ZF4 X-Received: by 2002:a17:90b:fd7:b0:280:c576:31bc with SMTP id gd23-20020a17090b0fd700b00280c57631bcmr14071001pjb.32.1699303993949; Mon, 06 Nov 2023 12:53:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699303993; cv=none; d=google.com; s=arc-20160816; b=qreuKKpcy2tu8DsJof8qhKL3K+Z2fjCRHlFsuFZWBoiAEvhWDFVvpEoxVN/PWLtQwD QYDzlIyEHa0wMfA7aptJRWvWbFrCL+7l97Fjye7iT+s1AZPd8rtpiosvDrFj1Y6ZEHTV +dDoEE2Vteae+YrYThlmyhQfDGrZg/sBWV3GrYa6hhpXMAOk9Nfs1GO72wkPsLe0XA40 NNUfCafk78OHhoRflJ3sfed5APueUhXtbtw9loOdc2VLtcXTTb8jSSWPP66iSM0EJobu UiB4HHVcfRKFBLYq5tXzTrAE4t5BaHUclfy+eQx7zYcuhBdsXAUuxUhINBLD3stx7SEt a59A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=uiFtSMJtgsfJ/bNf1yRT0A0/EhLw1YECLioBli3+JIg=; fh=SCMifNfbFIJVP0XM1+H27reRnzw2gAXxQFVGF7OMORM=; b=rUhy4Zg+9LJaxmz4fHYACtdkTeu3oBxMHcABqTTV7/pcrC7UpDx6mXJvkMN/ceUbCq vBWveBryJ+WG0I/ytIv8vHzUippxjaN3LvHTHYEX4OHehPTqGVEpZJNILkgAM/kfVKLs JCu4QQHbydBpvJx9QcTptUFe241qThAl9ql5RMEbB9lNKg76+BZcTBSg6vOUgv6tHXtc kEBpRWsNwhM1tYRZwOcRVR/mF+H6Q1tSeQnd94/HnEYOcX4Cv8eTKrBrYt50c9Ke+r4A UbTssr8TMDQ5w9DGIBoQebA52mxtiLXpM0XRZQbK9yPlAOvwJVMvibdvlgAbg6AkMteT K06g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="O/D1O9li"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id h5-20020a17090acf0500b0027d82c2b020si8721740pju.88.2023.11.06.12.53.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 12:53:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="O/D1O9li"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id A79F58039A11; Mon, 6 Nov 2023 12:53:11 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232979AbjKFUxC (ORCPT + 99 others); Mon, 6 Nov 2023 15:53:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229755AbjKFUxB (ORCPT ); Mon, 6 Nov 2023 15:53:01 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2921CF3 for ; Mon, 6 Nov 2023 12:52:59 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19BA1C433C8; Mon, 6 Nov 2023 20:52:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699303978; bh=uiFtSMJtgsfJ/bNf1yRT0A0/EhLw1YECLioBli3+JIg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=O/D1O9li5NFX7VnY8p1Cnp7xXe8lptR2O9UlSt18mn++8+oOnxz/2V6eh9tDxQv/e 2QiWpE+CVUe9Hbxb5y8pNBTmMO88ZQIrSkAcfnyzWRcHAxceLVy/qBvIY4uJWT2RJN etoyYRUGGz/XMZDVEdgv8XnA1QYEnY+ww1mVqUrlwqT/fGckC7H7EeDFo+4zWgzgGx M0fqaMTIw5eJUCJQcHBP3cLNIEsRlAMxL3bSXf4Osj3u+4vPvvA+tgjPcCCF1tod/F riATYD4H4Z/glc2YBFWqG24cSSHDIuosZsiUAOVYT//1xsc57GNtGcqzae+w0frUn9 KLPZS6LQLXihA== Date: Mon, 6 Nov 2023 12:52:57 -0800 From: Jakub Kicinski To: Nathan Chancellor Cc: Eric Dumazet , davem@davemloft.net, dsahern@kernel.org, pabeni@redhat.com, ndesaulniers@google.com, trix@redhat.com, 0x7f454c46@gmail.com, noureddine@arista.com, hch@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, patches@lists.linux.dev Subject: Re: [PATCH net v2] tcp: Fix -Wc23-extensions in tcp_options_write() Message-ID: <20231106125257.43f52b1f@kernel.org> In-Reply-To: <20231106155806.GA1181828@dev-arch.thelio-3990X> References: <20231106-tcp-ao-fix-label-in-compound-statement-warning-v2-1-91eff6e1648c@kernel.org> <20231106155806.GA1181828@dev-arch.thelio-3990X> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 06 Nov 2023 12:53:11 -0800 (PST) On Mon, 6 Nov 2023 08:58:06 -0700 Nathan Chancellor wrote: > Ah, this suggestion is much better, thanks. I'll make this adjustment > and send a v3 later today in case others have any suggested changes (I > know netdev prefers waiting 24 hours for another revision but I'd like > to get this warning cleared up by -rc1 so it does not proliferate into > other trees and I sent v1 almost a week ago). Definitely, sorry about the delay, feel free to post v3 ASAP.