Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
MIME-Version: 1.0
References: <20231106210337.2900034-1-hsinyi@chromium.org> <20231106210337.2900034-4-hsinyi@chromium.org>
In-Reply-To: <20231106210337.2900034-4-hsinyi@chromium.org>
From:   Doug Anderson <dianders@chromium.org>
Date:   Mon, 6 Nov 2023 13:12:23 -0800
Message-ID: <CAD=FV=VYd96GKM9VzmOPbF55-QEVL3EaCHhY8g+7hPSrDBL31Q@mail.gmail.com>
Subject: Re: [PATCH v4 3/3] drm/panel-edp: Avoid adding multiple preferred modes
To:     Hsin-Yi Wang <hsinyi@chromium.org>
Cc:     Neil Armstrong <neil.armstrong@linaro.org>,
        Jessica Zhang <quic_jesszhan@quicinc.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Mon, Nov 6, 2023 at 1:03=E2=80=AFPM Hsin-Yi Wang <hsinyi@chromium.org> w=
rote:
>
> @@ -622,7 +627,7 @@ static int panel_edp_get_modes(struct drm_panel *pane=
l,
>          * and no modes (the generic edp-panel case) because it will clob=
ber
>          * the display_info that was already set by drm_add_edid_modes().
>          */
> -       if (p->desc->num_timings || p->desc->num_modes)
> +       if (has_hard_coded_modes)

nit: the comment above this line is a bit confusing now and probably
needs to be updated or removed.