Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp2406701rdf; Mon, 6 Nov 2023 13:17:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IFzF3mOzIQg/gVuSKEF7rZK0bMYlfeHCHF+cfdXae5hh1lXT6wprIPs2qK59z5DfwRD4hWJ X-Received: by 2002:a05:6a21:7742:b0:181:10ee:20ca with SMTP id bc2-20020a056a21774200b0018110ee20camr18277329pzc.30.1699305430965; Mon, 06 Nov 2023 13:17:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699305430; cv=none; d=google.com; s=arc-20160816; b=ZeNdoNFYxsHs4ftT0AkFco0UgHko+1B+O10Or9nirYn/VXn/esXZR+6bgvPzxSbYM+ SXmsSxJZOHufATUZsdRfk/WIm26IrKSfQw2AvyhfpYMFPN8wSPDDt7mB+aCtHAfGY94z RR8KgruAXFQhIXTY2w7XDxICwnD1/5H5Me+8deVi3BLx16qJjULsNI9JnW9UK1PIcvn4 ytmcytkjZUcMvKVAw4ps4U3raiwSomzxpHVwyBaEecrrpGPEC8TwMVGbXhq5jmSZk5dV nHusNKVJYbYPNuETD4E8YgIRkPTvSjVT1K17pqe5nj3elRf8l4F6wZAPLi5BUZUK03wQ Z/wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=m0s0NPlNKVuypyWonsuGD7+z822Gp77P6CUxJcbBi0s=; fh=ACxZAypb/PMmo4vVKnXSPT93prSxIgwaGUj/+6ZNh08=; b=TXMgB35xdH+xyJsrEt0x/SKFJ8pJlSGhxBTeFaWT2CUVYOXtYNHqYzMiMtawA7PqNG NkDzyyrtygwdWvRKjf+461BUvxaOqk6tS9sEoFjyNUquh6IAxVXB8AxA//rrB85e+9eI khmULmbXhwna5XaNz1qSON+vzO3PeosP9aM1swEVdK3PVehfW9lCmjqXU7F4WAhryQBj IGAf1MmMfu8F0EdI4/h0jVMH25ZV1Z2PNjN14T6BlMHiF0hxUElwWZ38WyUfoup43ydv x1W9uTRTSw+gwE56TBW2o7ZNQEvUYXwOhBTG1hxCwZ5QvL1d1+OLjGAjXGl856hXLZuz 94cQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rXYeTCNV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id pf14-20020a17090b1d8e00b0027d15abe599si9633943pjb.143.2023.11.06.13.17.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 13:17:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rXYeTCNV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 856E28073283; Mon, 6 Nov 2023 13:17:08 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232954AbjKFVQz (ORCPT + 99 others); Mon, 6 Nov 2023 16:16:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231739AbjKFVQx (ORCPT ); Mon, 6 Nov 2023 16:16:53 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B174A3 for ; Mon, 6 Nov 2023 13:16:51 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4821EC433C9; Mon, 6 Nov 2023 21:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699305411; bh=k2iHsevdylVfNnzq7vpSFHrz7HmQmltAVDcN12lB57M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rXYeTCNVWqISuAwfrqkINqGZUcV4qtcxPGdhwjgQXWbySb/hqmbVlZ3jbClBYSZcU Z31DK2I3f59Tkv9EeDg1BGoAw8jf8EOPv+IPNxHcD7X5DSpCwql8fODXsgvOIHSXug uBF0ZvmhqKP8nlLwdZ1Iw1PZdcChZ9Yz+TqjrmnAHfZ6K9W2LFLlF+rz1gxZa7Gz+o erGJBRBZ89WPxVdDsrVDn/c5v9y80iLmnVMz7wDhMkvv+ngMA1R6LfnRJHEeB7Qu87 Bd1KkuoRe1uPJaS7ncTHNi2LxqjkKfOFkp1e9AJLyLz67rvCKdFP5rhfI+WQI/5VV5 P+5LCDGNU27Rg== Date: Mon, 6 Nov 2023 14:16:48 -0700 From: Nathan Chancellor To: Jakub Kicinski Cc: Eric Dumazet , davem@davemloft.net, dsahern@kernel.org, pabeni@redhat.com, ndesaulniers@google.com, trix@redhat.com, 0x7f454c46@gmail.com, noureddine@arista.com, hch@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, patches@lists.linux.dev Subject: Re: [PATCH net v2] tcp: Fix -Wc23-extensions in tcp_options_write() Message-ID: <20231106211648.GA682811@dev-arch.thelio-3990X> References: <20231106-tcp-ao-fix-label-in-compound-statement-warning-v2-1-91eff6e1648c@kernel.org> <20231106155806.GA1181828@dev-arch.thelio-3990X> <20231106125257.43f52b1f@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231106125257.43f52b1f@kernel.org> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 06 Nov 2023 13:17:08 -0800 (PST) On Mon, Nov 06, 2023 at 12:52:57PM -0800, Jakub Kicinski wrote: > On Mon, 6 Nov 2023 08:58:06 -0700 Nathan Chancellor wrote: > > Ah, this suggestion is much better, thanks. I'll make this adjustment > > and send a v3 later today in case others have any suggested changes (I > > know netdev prefers waiting 24 hours for another revision but I'd like > > to get this warning cleared up by -rc1 so it does not proliferate into > > other trees and I sent v1 almost a week ago). > > Definitely, sorry about the delay, feel free to post v3 ASAP. Done, thanks Jakub! https://lore.kernel.org/20231106-tcp-ao-fix-label-in-compound-statement-warning-v3-1-b54a64602a85@kernel.org/ Cheers, Nathan