Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <af68ec80-7511-4861-b4ec-0fb9c7284513@intel.com>
Date:   Mon, 6 Nov 2023 13:22:48 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 23/24] selftests/resctrl: Add L2 CAT test
Content-Language: en-US
From:   Reinette Chatre <reinette.chatre@intel.com>
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC:     <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        LKML <linux-kernel@vger.kernel.org>
References: <20231024092634.7122-1-ilpo.jarvinen@linux.intel.com>
 <20231024092634.7122-24-ilpo.jarvinen@linux.intel.com>
 <8051f3ef-1126-41fb-b6cc-f48441936dd7@intel.com>
 <2514e73e-2419-7c88-3f22-469db4b2fa25@linux.intel.com>
 <48c6795b-554a-4019-bb8d-a2ca0f6fbb2b@intel.com>
 <4008929-d12b-793e-dce8-eb5ba03b4ebb@linux.intel.com>
 <755ed028-f73a-47ed-a58a-65f4f48eaee3@intel.com>
In-Reply-To: <755ed028-f73a-47ed-a58a-65f4f48eaee3@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MjRFZ29hR3dLWVNwRmt6OFdtMXQydHZUa0dxRE1maCtQYk9JQ0FiOHlKU0ty?=
 =?utf-8?B?QmM0bjc4SUFZdlFqZndWeXBXUEhGNjEyRU5Id25yZko0Sk5lUTFqWUJyWHgr?=
 =?utf-8?B?K2Vja294SHIvSlZLT0NwNDFqWHVMc3Nsb29NbjFqNERqM1I4bGZYVSsrQzU3?=
 =?utf-8?B?RVhLWnRlb3lIdk43a2E5THRsQnFZa29IWHpNV3k5aFBOMjFIaUE0aVN5dGd3?=
 =?utf-8?B?UXRNT29jYTdRYk1QRVpRdmE3K0w4Y3FIdEpHRmF0WXlQUUJPWnFWbm1JM2lD?=
 =?utf-8?B?ZXUxbms2Z0FEK0ppd2xWYWptajNEUDFLRjNMdklDL1g3QkZUZ1Q1UmplVzJq?=
 =?utf-8?B?TXQwQnlGWGlXcUNOenhRUmRIbVRXbUNqQWw1TU1qVSsrWXljMzhnVWZ4Z2cz?=
 =?utf-8?B?T1AxVmRkYjJmN2d2dVFFVlV3RGZTMHFQeWFjTExCa0toTTlzMllYOGtPbFNR?=
 =?utf-8?B?UGdaRDQ0YlBINy9MZVpWUVFRZXFlUGkvTnovYzBacU55Q0JRSzc0Rldia1JH?=
 =?utf-8?B?Rit4L3U1QWQ4WTN1Uks1cS95SGp0TkZaOHltd2dzMTNQbEFJaFdUTEpEazlO?=
 =?utf-8?B?Y0Y2ZXZ5ZUtRWE0yQ05YOW9WVzlHd3NLSVJPbHJndytKbTNwODBxNFhlTklD?=
 =?utf-8?B?ZjJFK3VmVENGdTJoR3R3QmFUQkpScXpKNlBaaUJ6UDdKQkRaZ09KUGthb0tz?=
 =?utf-8?B?azMrRlkvZnQzc3pseXpkMkxnTzQzU2ZjSzZab0Z1Vk45bVpkRXgxL2tQUC9H?=
 =?utf-8?B?cHBQclVpZFN5RUcwdzhLYlZxYU83enpwNmgwWG9INnFPc0VNaUJjN2V1NFhJ?=
 =?utf-8?B?L1NZUVJwV0xIQzVsM1FncVZEVHVIbm1TMXQzMmpJOURFRHVLcUIxNWR0Mm1T?=
 =?utf-8?B?eUJKNmV4WnJPbDRjczZHSm1oMHpOOGpPRjF0THRCQVZZYWJCVXdJMnJQVU9J?=
 =?utf-8?B?ZmNWY0sxWmtIaDZ4QmI4TFYrTVdyU0FJaXBibEUvaVpSdS9rNnhGTGFlQkhP?=
 =?utf-8?B?WFg5bE9JOE5GSnpqeWhZY3lkWlhkM1lsZnVhWCsyRm9PV2xoYkx1cXZYZG14?=
 =?utf-8?B?Zlh3RzdFMUNZSENDYWdPWlRmRFVUNWJvczdwcThMV3RiVThoaytTbHZzSk44?=
 =?utf-8?B?NEc4NmN0VVZxUmsxejQ4N0VzK0p2WjdQTmVYOTBUMzF4NXZtQXlnekduL2Yw?=
 =?utf-8?B?MFdQOFcvNkRMSDBSaTNKTkdodTl3eXNOSHFoQlE0VVpJdjhicmNINzBZNGor?=
 =?utf-8?B?a1JXMkNNYUx3b3BFbnJ1aUdRNHZkekk4ZnNtamRwOGFnTnhDajA5L3ZrcUZU?=
 =?utf-8?B?a1lPSUhZOHJEaFJOWGNEUS84dmxsZmh6aVV4T2xNOHpnS0VJQXE2eVBwb3BC?=
 =?utf-8?B?WUF4ZzVRR3dseE5BWGpEaVYranIwNWZ0QzlNMmZIaEJEOFg0U2s4WG9nZ1FH?=
 =?utf-8?B?aVhkL1hXSnI5dVljQWRMQ0J5UFN4bFBpYUpvWEhjaURYRnVDQ2J6UnFWQWJD?=
 =?utf-8?B?RGoydXNTMFI5OTgySnhCbjNGbHZ1QWNObitvaGU0R2FPSVFPd0RNSThqZDFM?=
 =?utf-8?B?Y2Q5MGtOL2RlM2dhYjlEUmFxOTBkQ1RUZEtYejhZTG9ORmJkcHlHamtQTHUr?=
 =?utf-8?B?REtVN1Q1Uk1UZ1VKRHhPU2tqb0VJZVlMWXQ1aUl3bnVzcWlFc045eGpMci9h?=
 =?utf-8?B?TTdTZzRFVk9ZU3RkRXBuQTdycTBKRlJKbVo1YlVza3hNTER2M2xDM3V2MG5N?=
 =?utf-8?B?UmowaDhNVElydytseE85Wmp2THgxVVZqMExsSEJyd1BocjkxVHJQME9ucUxD?=
 =?utf-8?B?UzhFTTJicEFRNnZZajlTMHpDc2xMdlIrQ0pLUllHb2NTNmFaWTdMaFZtK3ow?=
 =?utf-8?B?STRiSXRlSGM2WU45Q3FjZG9lbVRlYWt6bEpXK1VMWWdlcWYrSG1mWDVVa09x?=
 =?utf-8?B?N25HOW9RTWpkSW11TUlDMWxzSFpTR0hXUlZzVFFaSk1lbFNZOWw1NmJqb2s5?=
 =?utf-8?B?MVJDUlh4VEJOenUxNzdRUzVJUDA2eGw5aDBIU3NDWGtaZ0VEN05udU85L3Ez?=
 =?utf-8?B?ckpMRm5XRXNndDI2dVVHRit0YUwwSjVYdUFxRlNsb2htNlJoQmZnNm1uOCt0?=
 =?utf-8?B?aVZWRGgrVmhlZkVNSTVzaUtjdHQ1b3V5ZU1iRnphNTF3R05Zd2VmeWpPL2l0?=
 =?utf-8?B?N3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7507d864-780e-4d63-eb10-08dbdf0e880d
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2023 21:22:51.0830
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nMDuQGiyUCCfuNf5lixb9bqY6da9RTiN8W5lITGQwBW1ufGWgY9z9YBvOYFiNikipqdyWnkfZ7n7cmc2Pfr5Wn4HGoZD8gBw+9kiJ5lyGn8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB5965
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 06 Nov 2023 13:23:05 -0800 (PST)

Hi Ilpo,

On 11/6/2023 9:03 AM, Reinette Chatre wrote:
> On 11/6/2023 1:53 AM, Ilpo Järvinen wrote:
>> On Fri, 3 Nov 2023, Reinette Chatre wrote:
>>> On 11/3/2023 3:39 AM, Ilpo Järvinen wrote:
>>>> On Thu, 2 Nov 2023, Reinette Chatre wrote:
>>>>> On 10/24/2023 2:26 AM, Ilpo Järvinen wrote:
>>>>
>>>>>> Add L2 CAT selftest. As measuring L2 misses is not easily available
>>>>>> with perf, use L3 accesses as a proxy for L2 CAT working or not.
>>>>>
>>>>> I understand the exact measurement is not available but I do notice some
>>>>> L2 related symbolic counters when I run "perf list". l2_rqsts.all_demand_miss
>>>>> looks promising.
>>>>
>>>> Okay, I was under impression that L2 misses are not available. Both based 
>>>> on what you mentioned to me half an year ago and because of what flags I 
>>>> found from the header. But I'll take another look into it.
>>>
>>> You are correct that when I did L2 testing a long time ago I used
>>> the model specific L2 miss counts. I was hoping that things have improved
>>> so that model specific counters are not needed, as you have tried here.
>>> I found the l2_rqsts symbol while looking for alternatives but I am not
>>> familiar enough with perf to know how these symbolic names are mapped.
>>> I was hoping that they could be a simple drop-in replacement to
>>> experiment with.
>>
>> According to perf_event_open() manpage, mapping those symbolic names 
>> requires libpfm so this would add a library dependency?
> 
> I do not see perf list using this library to determine the event and
> umask but I am in unfamiliar territory. I'll have to spend some more
> time here to determine options.

tools/perf/pmu-events/README cleared it up for me. The architecture specific
tables are included in the perf binary. Potentially pmu-events.h could be
included or the test could just stick with the architectural events.
A quick look at the various cache.json files created the impression that
the events of interest may actually have the same event code and umask across
platforms.
I am not familiar with libpfm. This can surely be considered if it supports
this testing. Several selftests have library dependencies.

Reinette