Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Mon, 6 Nov 2023 14:05:39 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Shiju Jose <shiju.jose@huawei.com>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Ira Weiny <ira.weiny@intel.com>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
        Yazen Ghannam <yazen.ghannam@amd.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Dave Jiang <dave.jiang@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        "Vishal Verma" <vishal.l.verma@intel.com>,
        Ard Biesheuvel <ardb@kernel.org>,
        "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>
Subject: RE: [PATCH RFC v3 1/6] cxl/trace: Remove uuid from event trace known
 events
Message-ID: <65496333c1dc9_90fed29479@iweiny-mobl.notmuch>
References: <20230601-cxl-cper-v3-0-0189d61f7956@intel.com>
 <20230601-cxl-cper-v3-1-0189d61f7956@intel.com>
 <20231103142756.00000e20@Huawei.com>
 <547d055eb85d4cee9c636c69e89a82ed@huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <547d055eb85d4cee9c636c69e89a82ed@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zSoRDJ5ppo5BrQoYWP7kBNJxdgfBgK48EWh3cfLYidzIqoSDYfEYNKjP46hS?=
 =?us-ascii?Q?qcm1MevV44KPPmF3Bqk/pk29KQ3+XLMWHIsGmuOnVrSi9rmQrBRapEg59XGD?=
 =?us-ascii?Q?ntcrgMks7KIDGhkg5BPd+kzndN+QMRo/DFak0AhKBJPwbrU1TWpN3rtiP6yo?=
 =?us-ascii?Q?Rn7G3os6PE5SAlYqdLqRLmWgqoZHqKqxbrrhyFmoSl77LLGFaCeFXYyXgHHH?=
 =?us-ascii?Q?WkyiiRG0KptQXbMpGJFRkunAiVvmkZxj1MXGInYSFME0zEzh4DgHUIU2MLGF?=
 =?us-ascii?Q?ASC+uiBOwbzZjaFlt7DvMNmv63g0ga3bjGTSHjNjfAi+qBrbghthQJ7R0MZZ?=
 =?us-ascii?Q?TZzaj7/Y1FrYl//Gl84ldUfAppvzAoO5Je8DrCtLoz8BbwohCAI4gKQNPKrt?=
 =?us-ascii?Q?keBe3tizPOWO+KUJGp/T8uTjhvwhTAKM6PJk4EMCjke0vh6ol32yNc7JAbRM?=
 =?us-ascii?Q?ZB968DUeHeAJTrz7PWJ6jME1lIC8SdQFSjJLrb7R0Ui7LLnK09eeAVcVvtk8?=
 =?us-ascii?Q?LI7pLRA4aRw0wFuxjDdlt9LRcxlhcEO2w8dtYX2Y2EJPWWexGZ8b+807+e59?=
 =?us-ascii?Q?ERQOoWd5Lfi8+TqivpTU+ZWGzvVj1S+qyvAt2N6szZqMRgqqvoT/tQsLQQZO?=
 =?us-ascii?Q?WfkKwtH96ZmPiuoKnawImQbq1LiWZAUCAbPjktmv8fsBMsVi7WEcGr+bMDZi?=
 =?us-ascii?Q?nifEsCj+z+ni7rZlgrlILg3c16BN+bmtiVRfoGT7NsjDR8iFBuAkah6Vu5JZ?=
 =?us-ascii?Q?t4kwGbmgtwMMjYdZrx7MyeABlkKfkZCyuB1QwGfOGsCjC+b3wO85ZRYvf1bS?=
 =?us-ascii?Q?NCfqGWWDkst/Wvx25UYKht4b774NBT/CS/OwSmPJuxyN/eJHJlPmmN+KEIMU?=
 =?us-ascii?Q?eLd5BU3dgUIFnIXWKLRovflOnZB3sEYu1W+1nwvL7osRUm0N4D6ifZPVgwVM?=
 =?us-ascii?Q?Q5lMzhIuLuHI6tA4Ta4sAtYaIJyMWn2M3gpKZ4gnCV1KULwnrkHXveLAomXp?=
 =?us-ascii?Q?lOew2FPIzoQQ8ivswR2MUmh0gO8lzDmcgnledf9V457Mnc8mAp47Q8RfbZmG?=
 =?us-ascii?Q?S53dNh+NZObr7/Y6dgWTW3xn5LaheTpiKhJNND6M+Qj9lJgy7MvThGz9Tuyt?=
 =?us-ascii?Q?azTtFvqEBVr++oUlGu1q6lTRtjzwm+xjWw1cP5/QVpbhYcyMz3lddSMCpYQ3?=
 =?us-ascii?Q?OIwr6jEDmy8PKqdfsVUhi5NwglOeAVjmFgVy7yHxxah5V0IrG51CsWd2NL2z?=
 =?us-ascii?Q?8xJ6BAkOxfv7jR9MoAgqwrOXGuNBMXz/i340su/YwI4XjuYSjjOjHp3gjIL7?=
 =?us-ascii?Q?2xocncaCXwIrb7fZ0AiOqY03hk3sjxqqAe5T9ydYrsr2GcsCEHj0PMsDDYb3?=
 =?us-ascii?Q?CnCuCXYMVjYrpR5GtoCmbTOJrBLz2tRmZEhVWaGHOSDGwzPBo7qA2wfd4L4Y?=
 =?us-ascii?Q?a1yeJNGPOK/gCqPBI3XAvWMufwlZnv55fkWE5w1zWFNP2MhxZAY6bcFgui45?=
 =?us-ascii?Q?7OpWmMjSx9RejnKhxgo/dfGXHLretPAo/UiAqD80avj9VYDXp4tYU5HW9d8X?=
 =?us-ascii?Q?p6o44lriMej77faPvEj720qpttyFLrncrds/dciu?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d8514910-d04f-4c73-4c39-08dbdf1485d7
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2023 22:05:44.8059
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nyrR8RM/m/sAJA/NP0ZrD4if3woxakP1mOyKQ11Ov6IR97clTXBVte0NeqEF7JVYuKanhTIwYm87AiX8/1lLiw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5250
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 06 Nov 2023 14:06:02 -0800 (PST)

Shiju Jose wrote:
> 
> 
> >-----Original Message-----
> >From: Jonathan Cameron <jonathan.cameron@huawei.com>
> >Sent: 03 November 2023 14:28
> >To: Ira Weiny <ira.weiny@intel.com>
> >Cc: Dan Williams <dan.j.williams@intel.com>; Smita Koralahalli
> ><Smita.KoralahalliChannabasappa@amd.com>; Yazen Ghannam
> ><yazen.ghannam@amd.com>; Davidlohr Bueso <dave@stgolabs.net>; Dave
> >Jiang <dave.jiang@intel.com>; Alison Schofield <alison.schofield@intel.com>;
> >Vishal Verma <vishal.l.verma@intel.com>; Ard Biesheuvel <ardb@kernel.org>;
> >linux-efi@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> >cxl@vger.kernel.org; Shiju Jose <shiju.jose@huawei.com>
> >Subject: Re: [PATCH RFC v3 1/6] cxl/trace: Remove uuid from event trace known
> >events
> >
> >On Wed, 01 Nov 2023 14:11:18 -0700
> >Ira Weiny <ira.weiny@intel.com> wrote:
> >
> >> The uuid printed in the well known events is redundant.  The uuid
> >> defines what the event was.
> >>
> >> Remove the uuid from the known events and only report it in the
> >> generic event as it remains informative there.
> >>
> >> Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
> >> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> >> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> >
> >Removing the print is fine, but look like this also removes the actual trace point
> >field.  That's userspace ABI.  Expanding it is fine, but taking fields away is more
> >problematic.
> >
> >Are we sure we don't break anyone?  Shiju, will rasdaemon be fine with this
> >change?
> 
> The field hdr_uuid is removed from the common CXL_EVT_TP_entry shared by the
> trace events cxl_generic_event, cxl_general_media, cxl_dram and cxl_memory_module .
> rasdaemon will break because of this while processing these trace events
> and also affects the corresponding error records in the SQLite data base. 
> Rasdaemon needs update to avoid this.
>  

Ok we can leave the uuid field in easy enough.

But does rasdaemon use the value of the field for anything?  In other
words does CPER record processing need to generate a proper UUID value?

Ira