Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Mon, 6 Nov 2023 14:10:06 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        "Jonathan Cameron" <jonathan.cameron@huawei.com>
CC:     Yazen Ghannam <yazen.ghannam@amd.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Dave Jiang <dave.jiang@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ard Biesheuvel" <ardb@kernel.org>, <linux-efi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH RFC v3 6/6] cxl/memdev: Register for and process CPER
 events
Message-ID: <6549643e8d8a1_90fed2941f@iweiny-mobl.notmuch>
References: <20230601-cxl-cper-v3-0-0189d61f7956@intel.com>
 <20230601-cxl-cper-v3-6-0189d61f7956@intel.com>
 <d286ae7d-ea83-af3e-7df1-8ad83fdbdc57@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <d286ae7d-ea83-af3e-7df1-8ad83fdbdc57@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4z0YmkwKM4fmtIxEMv6P8qh1ogGC/LFWKecW7N8F8pUa3zoCXf1O/5YAi0Gg?=
 =?us-ascii?Q?QShXvSyOJSphwzSAQwGJCUzd+u6iH5XH0RWLw0W+d4vduKbg6OygYdxvD5kf?=
 =?us-ascii?Q?CBAU0ACum45emGSBT8NIXf/N3ykc27B4sALa51gVE/vrJ3vLbTqnLrIt3q6B?=
 =?us-ascii?Q?BgVGMpwAqSpM6C0bsSwegboB6SrYGij1uZWLSk17qLk4AR3Q+Ag5KPL6FfB5?=
 =?us-ascii?Q?Egb4vNtq8yW2N4blmejDxDgDtfrgdFULZIGmunABbNVSRpEyKkzZSO3wGIac?=
 =?us-ascii?Q?gl1g++sOvm/87qCsaRa7EhP7eEMkVwKSXwAWHL/pmuq9CxSnz4h4fGnTVzTS?=
 =?us-ascii?Q?qDCiCcIed9KvIu0XDllf4KUw5P7YT4M/WC4aR4hGsRpreyHJhur+cy6Y2se9?=
 =?us-ascii?Q?LI+e2yt332eO+nC7+whr+pOsoM0liUUacTfwkhx3cPMjoAN4hmC9EZjnM7sX?=
 =?us-ascii?Q?jIkWlvqvcw64C8oTeFWbqSgL96BdF6sImY0cwDaigqn2U5ehUSE9dR+8J6U2?=
 =?us-ascii?Q?f1XM4uWe3eN0qVAmTH1IsZJU2Awdf3mSyPpoc6fRMLZ0Z/jwUb01HsFGo1gu?=
 =?us-ascii?Q?cVMh4xKR8Nn4Cj6UfSj3tgtozWpQPfWQK1oULnEYipUEQdQZq1w3z1VdmEKt?=
 =?us-ascii?Q?OgiAG8gKvMtqzs8IhIhW2D1DLWBaKtKlccMf0S0N6J0v1N260LmMSwsUc/9Q?=
 =?us-ascii?Q?5XHwwaQF/Y4DAhEOYZU2vcp8gLfr3/imOCokLITzOOXfO/oPZBO3hkrzu58K?=
 =?us-ascii?Q?Ku0Cp0H0Cv3a9JMBzZAQ0o3zfIGDIH4yPL/mEg2kpcHinCPj0IfTgTLiSxg0?=
 =?us-ascii?Q?PnwqDexNtEM7MDK246P2TdqUlEHN6qGGsj7bmwZUYi1I7yE6JHMs1pIb0RUq?=
 =?us-ascii?Q?wGP6KME6xPp/bf/K1OX93bLvfRa3cMFggdxMhTBtNosz2hwokdmKC3iBNF9m?=
 =?us-ascii?Q?Z5SeQHym/fCMggFcaetX2NBNxNReQ6/2KVSma3FYhlBPttIYUdX/hb6V/Wlw?=
 =?us-ascii?Q?B39bW67oPbKSWCmQDUWFpigMeTWBZh15Uh751ck8mPfSglmgcpD91g2tP4XB?=
 =?us-ascii?Q?1/z4J9A7BpjEuxDuy7qfxXZrm0+HzNPzxrJZnmGWot89dsR2fk3Pd/MUuTVS?=
 =?us-ascii?Q?6KTfzgOdAU67DMPNyPjSjruQ0d0OdiIDoWzFGdChBw6P88WYeuVLDbzKVM0C?=
 =?us-ascii?Q?jAvJLmMIcqbeRTzt4eh9keWeKAVBGsX+8UqlkhwywepagHxupPxzxsOqA/9T?=
 =?us-ascii?Q?krZDaeu6kFKTranWAIIHYeHXyg3rbpBo7/PuwLOSRVlHlNWDYT5FIHybt8M2?=
 =?us-ascii?Q?6XAb1oqtuGLZfiouUFTAY3Mq+KaPX4fyagC/jNRVfYbBDeti5QinChEnAWH4?=
 =?us-ascii?Q?GvMdFGMKbQjIfNafcc/ekogXf5jC/VnU5n+8IT9PJ42V+R+2ViZtFzyIsQ7J?=
 =?us-ascii?Q?NFLSUYuwMXbSsSb+6lKF6DZoJgH+oLZyWJ4zyreyXtl3b5cmfl1EjeY1WL+e?=
 =?us-ascii?Q?vpFzDOhUaRhtebuaXMJ/+df8gs0zqG53BoDU8QNZpapUNyjVRrrgaQYTnLKE?=
 =?us-ascii?Q?COwn/nGDVGWRa31xyYo5P1ae4GMZD+m0M8DLyRBj?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ad7d1249-a9f5-48fc-3031-08dbdf1523e6
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2023 22:10:09.4942
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ug6V4ovQtmMDDCer3QBqhz6YRioNUybNUsrjZw/U0dj+VswBRKTcUlMHkp3MXxbHb7lZJx1nhAeaDJJgQcO+Rg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6455
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 06 Nov 2023 14:10:39 -0800 (PST)

Smita Koralahalli wrote:
> On 11/1/2023 2:11 PM, Ira Weiny wrote:
> 

[snip]

> > +#define CXL_EVENT_HDR_FLAGS_REC_SEVERITY GENMASK(1, 0)
> > +static int cxl_cper_event_call(struct notifier_block *nb, unsigned long action,
> > +			       void *data)
> > +{
> > +	struct cxl_cper_notifier_data *nd = data;
> > +	struct cper_cxl_event_devid *device_id = &nd->rec->hdr.device_id;
> > +	enum cxl_event_log_type log_type;
> > +	struct cxl_memdev_state *mds;
> > +	struct cxl_dev_state *cxlds;
> > +	struct pci_dev *pdev;
> > +	unsigned int devfn;
> > +	u32 hdr_flags;
> > +
> > +	mds = container_of(nb, struct cxl_memdev_state, cxl_cper_nb);
> > +
> > +	/* PCI_DEVFN() would require 2 extra bit shifts; skip those */
> > +	devfn = (device_id->slot_num & 0xfff8) | (device_id->func_num & 0x07);
> 
> devfn = PCI_DEVFN(device_id->device_num, device_id->func_num) should 
> also work correct?

Device num is the slot number right shifted?  If so then yes.  I'm not an
expert on the PCIe nomenclature.

> 
> > +	pdev = pci_get_domain_bus_and_slot(device_id->segment_num,
> > +					   device_id->bus_num, devfn);
> > +	cxlds = pci_get_drvdata(pdev);
> > +	if (cxlds != &mds->cxlds) {
> 
> Do we need a error message here?

No, it is just that this event is not for this device.  Another device
will process it.  Or if there is no driver loaded for the device it will
be ignored.  (Same as would happen if the events were coming through the
log because the driver is not monitoring the log.)

Ira