Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <51332bf8-d641-4a89-bcec-60b849fc6a34@intel.com>
Date:   Mon, 6 Nov 2023 16:32:56 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v10 4/8] x86/resctrl: Split the rdt_domain and
 rdt_hw_domain structures
Content-Language: en-US
To:     Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>,
        "Peter Newman" <peternewman@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        "Shuah Khan" <skhan@linuxfoundation.org>, <x86@kernel.org>
CC:     Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Babu Moger <babu.moger@amd.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
        <patches@lists.linux.dev>
References: <20231020213100.123598-1-tony.luck@intel.com>
 <20231031211708.37390-1-tony.luck@intel.com>
 <20231031211708.37390-5-tony.luck@intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231031211708.37390-5-tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFRIR0pxR0hJWDN0NUlncFVDcU9uSk5zUlQ4NkxqUEtXRHMybmkrS1loUzN2?=
 =?utf-8?B?MjRYNy9KR3BkRHM3c3NqTVdYN3dycVR1Z1dPN3QybXZkbFRXNWdCUjJPenR5?=
 =?utf-8?B?NnJyT0xNdzNGb0ZzWWlCUUl6QjJpL1NjMzRKVTduK3BKdWErN2loUzdmdnpF?=
 =?utf-8?B?aEVtU1ZHSUlVaElaU082RjRzaGh2aFVlUlgzNFh1RS9jTko2MlBORkZRQnZu?=
 =?utf-8?B?WVVneTRzMFRoR1ZEWGVhNk5nTDArelN6TUcrVW1lSGxjTVRLZUtkWTlxQmpJ?=
 =?utf-8?B?WjAzTDZ6Z0RIQmxVNGJVNldxQXpZcis1bnh3TE8vK21qb1RGL0JGMmRhSzl2?=
 =?utf-8?B?cFV6VFlIeWg4MXpnMlVZVU9lUm9nYkhNZWl4RHd6V0hkY0tqTGIwaGY4SlZh?=
 =?utf-8?B?WmF5NVhlUVZyWWViUHJvZDlxUTUvdGh2N3lXZTNoRjhSa05mZ05oTTRIZDFS?=
 =?utf-8?B?c29VTGRZQk9aUWJGSmpVMVpMd29yQUxlZjA0UkJWa25HWG1ERk5RUTZMczQ1?=
 =?utf-8?B?UThFQVU5bEVTOHB1SVRQMks0UHFEMGNmV3Ixd2p4blVBNjJkZ3Erbmtuczhn?=
 =?utf-8?B?eVRER2liNitvN2NqYkN6MlB2TnRFSGdFRmhaVWJ4YWwyRlpSUmdCR2pyblF1?=
 =?utf-8?B?L2VOeHY1S3lZUUFJaEVpaXRDM2ZWSnhlbE1McG42KzFBSkIzUmJEL1Z3OHZI?=
 =?utf-8?B?cVVSNS9SczJFaUZ2d1lpZFNSMjNUNmdySURRcWg3OURFWFhJWWIySlI4VUFh?=
 =?utf-8?B?V20vMVZ5c3VpV0g3SUVlZGZBRGJraGp1V25VeUswOU8zL0NmbW52THNRU0NC?=
 =?utf-8?B?UVNvUk9TY1Z6U1drMkQ2c3hQU2lhbGdUbEloRzRpSkpEUWxkRWRlVFY3UWNQ?=
 =?utf-8?B?emdPVzJJY1hIaWFXdEJxamdCU2R1RGZpajdpQ1ExcDRRUVVEbSt6a0Z1MXpK?=
 =?utf-8?B?dnZHbDY0SFYrb0V2bTduUDFuSzc1OElHZWlIZTlXekcwYjlOK2ZsY3dyOGlP?=
 =?utf-8?B?ZnVXWGtTUmFVVUJCNkg2MlNBRk1HQjN2Ni92a0VPMmJyeGtDZ29QOXhPYWsz?=
 =?utf-8?B?UUtma2lmeVNiUmtNZjdqNmFLWFV2b245YVNhYWMwRnU5ZGNPNk9JckJBNTlz?=
 =?utf-8?B?Z3h6eTFIRDgxZVJoQXRHcnUxYVNueU8wd2FlQ1NiRk8vMXN1VGN4amg2TFJ1?=
 =?utf-8?B?dVAvVklJc2t6aXZteUl0RlUxRWhrbmo1QjNCS29uRHJNdGwwSmI1MG92Y3Y5?=
 =?utf-8?B?M2d5cXg2czlCTXBGakpRL09uVVh5WWNnNmU1YTI5VTZ6THhiMVNFRUs3NUQ5?=
 =?utf-8?B?bDZ4VUF0NkpWWkwwelhXMjYxRURLOElsMlFubTVkTythYVo4QlRMNnJHV2dp?=
 =?utf-8?B?a1VLVkRLZnBrQ1Fwck4xU0lWUWt3S1J6c0JaYVQ2NnYvTERkUHd3TnRuOWFL?=
 =?utf-8?B?WjE1ME14MjRYNnJkaWdhKzM5SXZUTGZENXlucTVVbHBkUC9HM1JpdUNCZ2lM?=
 =?utf-8?B?eFloS3JzQmlUaTVNaE82Wi8zMnVRcTU1N294YnB3R3VDRXQvbmlSb1l5Uis0?=
 =?utf-8?B?RFZwSGpicFE3RHJxNHp4bnNGTEM4TURXTmxxYklCWmRIa3JOYVBhOUFJa28y?=
 =?utf-8?B?dVdlN2NBOVhmd1dDbFh1MWptMmFuOHBDaTJnUjViY1kyU3R6V0hKbE0rbVJS?=
 =?utf-8?B?R1lUb01oenEwUE8zdXJ1cW5vTFRZM1FucmNldDd4R2dkUDdtNTBYTWgzUFF1?=
 =?utf-8?B?bW1uRjFSOWRrSWFyZnZJTDczU2hlNTRzSS93dkQyOXVMWmF1RERMTEZocDA0?=
 =?utf-8?B?ZnBKcVVER3FmeTJNQTM1a25KQWxkWjgvbEJaWUVjbk1EM2I2TlpTODlIT2dx?=
 =?utf-8?B?K0kxZFZBNVJZSVVDVjBVZTFJMmY5QStVdkpQQkFRanljdVJYSDdKTkU4OXly?=
 =?utf-8?B?OXNNU2tTQlliUlM2L2tibHg1RmVLekFZcmEwNkZFTHg2SnI4YUdqUlRxUEpk?=
 =?utf-8?B?TENrTzIydE5hRUdKV2F6QXBZYkx3Nzh6VDE1YmV4bzNQWitPdXFDcXUzSDNx?=
 =?utf-8?B?M0RUMTIvY2NIa01SWDlSQkY4eDZtcWMyUDNqUEowcXk1N016UGY1MHZFWmRY?=
 =?utf-8?B?RG5iR25lZ1ptTWxVc2k1Q0d0OGp2VlJFNnZGam9vTmtrVnpvaU1aOVZWMDNB?=
 =?utf-8?B?bUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b5b8cf89-63ce-4681-884f-08dbdf291700
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2023 00:32:57.6977
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F5kaz7SqIszUuHd8yh++DBky/9c3dH9HoqqpdV8/ejMmdcEIILeCUh1YeOzizmmPQef0pOOvc5mL3lrk21q/ELbsdQCo38wkl4pqyRviOyk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7614
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 06 Nov 2023 16:33:09 -0800 (PST)

Hi Tony,

On 10/31/2023 2:17 PM, Tony Luck wrote:
> The same rdt_domain structure is used for both control and monitor
> functions. But this results in wasted memory as some of the fields are
> only used by control functions, while most are only used for monitor
> functions.
> 
> Split into separate rdt_ctrl_domain and rdt_mon_domain structures with
> just the fields required for control and monitoring respectively.
> 
> Similar split of the rdt_hw_domain structure into rdt_hw_ctrl_domain
> and rdt_hw_mon_domain.
> 
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
> Changes since v9
> Comment against patch 4, but now fixed in patch #2. cpu_mask
> is included in common header.
> 
>  include/linux/resctrl.h                   | 50 +++++++------
>  arch/x86/kernel/cpu/resctrl/internal.h    | 60 ++++++++++------
>  arch/x86/kernel/cpu/resctrl/core.c        | 87 ++++++++++++-----------
>  arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 32 ++++-----
>  arch/x86/kernel/cpu/resctrl/monitor.c     | 40 +++++------
>  arch/x86/kernel/cpu/resctrl/pseudo_lock.c |  6 +-
>  arch/x86/kernel/cpu/resctrl/rdtgroup.c    | 62 ++++++++--------
>  7 files changed, 184 insertions(+), 153 deletions(-)
> 
> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> index 35e700edc6e6..36503e8870cd 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -72,7 +72,25 @@ struct rdt_domain_hdr {
>  };
>  
>  /**
> - * struct rdt_domain - group of CPUs sharing a resctrl resource
> + * struct rdt_ctrl_domain - group of CPUs sharing a resctrl control resource
> + * @hdr:		common header for different domain types
> + * @cpu_mask:		which CPUs share this resource
> + * @plr:		pseudo-locked region (if any) associated with domain
> + * @staged_config:	parsed configuration to be applied
> + * @mbps_val:		When mba_sc is enabled, this holds the array of user
> + *			specified control values for mba_sc in MBps, indexed
> + *			by closid
> + */
> +struct rdt_ctrl_domain {
> +	struct rdt_domain_hdr		hdr;
> +	struct cpumask			cpu_mask;

This patch did not change what it said it changed.

Reinette