Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Tue, 7 Nov 2023 09:27:18 +0800
From:   Yujie Liu <yujie.liu@intel.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     <oe-kbuild-all@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: drivers/comedi/drivers/tests/../ni_stc.h:1140:35: warning:
 'range_ni_E_ao_ext' defined but not used
Message-ID: <ZUmSdrIFnGloqGz0@yujie-X299>
References: <202311060001.aEuf1q9y-lkp@intel.com>
 <2023110641-profusely-factor-b3c5@gregkh>
 <ZUiybtcMJGI5ZCF5@yujie-X299>
 <2023110639-overbuilt-caliber-28ef@gregkh>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2023110639-overbuilt-caliber-28ef@gregkh>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGJhdzhvWDNHdzEzU3g4cGhTTlFSQm1tcktHZU92emNhSUJBcXhmb09OMzlU?=
 =?utf-8?B?Y2RCMXF2bEtRQ3RTUDNqaDZEWDFRKzVLWnVmUy83ZXRId2s5RGpzV042cHZS?=
 =?utf-8?B?V2c2RC8xQnJnWjRhcVJqQUVhQWI1UFJqYks2NlNhN3ZpbU0xalRvTjRwNHps?=
 =?utf-8?B?enRtdlFtMnY4dTJ3QUV4NW9lMlJPbXVwMnJnaXM1cm9vakJ1T2tmcmM2MlZS?=
 =?utf-8?B?eHpPeXNhWC80ZDFGS1NvKzAxb2lDVmlqd1dIaUpzQnJyeVNyRzRyaEdieisy?=
 =?utf-8?B?ZVU0RnZEYnJqUk13UkFRcFpMblNmWHFDQW95T3R5SFNkMHhUanViQlJTeG1F?=
 =?utf-8?B?Qjg2eXhabHJ2Vy9LZ2twemZXcXRXUXJBdXdFMGtoY2doemlaOG8yenpXclhm?=
 =?utf-8?B?MnNWaXJzQmZZNnMvZDR3aGpmSmlKSldXTlRCMWk1WXQ2T21lbjRSMkVBQUcw?=
 =?utf-8?B?ZHkzLy9zKy9oUXJJUXc2Yjk0dDVpa01XVWpSbDlOYWk4R0RlWGdsdGdzV0xv?=
 =?utf-8?B?Q2tlNGpXN3hRcEZQMjdpRVlCLzdaV0VVbFVOaFJjamE4bG9TWW9NVk10ekpG?=
 =?utf-8?B?L3E3dWJndnk3ZHRZL285RDNQR2Q5and6UnVOL1FCMVAwdXN2cWZQRFhncXJB?=
 =?utf-8?B?aXQvY3JFbzhIMWtMOWtVWXlrT0oyWmxiNFR5UnpYYWMzbXIyZzFrYzY3RS9I?=
 =?utf-8?B?S3dHbUxhMSt0alhKZVpXcDFIMTNJUGxFaFVrWUkxRlVlZ0tPYVgyT3FDV3JZ?=
 =?utf-8?B?VjBieWk4ZGlMdG4xNE1wZ0pTTGliVDZ3clhqdmllZitzZVVmSVYvMEM2emhE?=
 =?utf-8?B?cm5HTnlOaTB4aEZidHZocUtBd2xybEwxaktUYjFQRWpNSUx0b2E0UEpHUUc0?=
 =?utf-8?B?czcwS013dXlXSlphY3ErTWRqREcweWRkOEUzYmFuTWsrcGs4SjlGRkxNWkVT?=
 =?utf-8?B?SnpyZk02eDA4U0JETTNDYkNraVBxVTI3TlE5S0U4Ym1QaHhNOUtHSlUvalZh?=
 =?utf-8?B?bFdTaU9GeUI4WDRqRWJTMnVLTEI4R0MzNXAyUU92TE45TlpLNGdremo5c3M0?=
 =?utf-8?B?R1ZHbnhXZDQ5Y1hLSkNNQmthNGZrVGhLeHc4dHpGMnYzWU5pODE2dVRHQU9M?=
 =?utf-8?B?SEZrRjBmWmo2UlU0TlBVUWhDZDRvZGhUcjl5bVRFZXRya1ZaWWJwUXpzZWtH?=
 =?utf-8?B?K0E2K0ZOb1l0dXVxZk95SXdjLzYzVDJVcDBhTWFBS1dvbkc0T1FqQ3YyL0Vh?=
 =?utf-8?B?VVJIVi9mU0o4djJBV0VXVmwzNzFwN0h2akxpNVZxa2M2YnpMNlJSWThtNFN0?=
 =?utf-8?B?KzZESjE1S2dBUUtuYTlmOGJHeUVlbG9scmxMcHdwek16RXg0My9zSk51T0RO?=
 =?utf-8?B?UTZ3Rm0xejVTZ05RZUZBUnhEdG1YNzMzcnp6dkJnbHdYVkpJYmthd0JtcHBS?=
 =?utf-8?B?dkdYOThxTC9Kam1ianQzVWgrbkxXajBVQ1EyMGVtd2hlTnMyNjN1RU0yV0xV?=
 =?utf-8?B?c0FPVkdsRFBicU9aNFl6RVY5RVNHVG83dWdYNnlibGQ1c1k3eitYUFRVR0lL?=
 =?utf-8?B?Z0JMMGowYUZSZnExQ0lSeS9aY3d0SzN5Z1IweTZUTHZnbi9jN3NXdjRJb1Rt?=
 =?utf-8?B?Z0tjY0JSR291bWpTbUN1bjYwZVNmNHJsd05HeWsyQ3Q0QUNsSm9wQklWaUN0?=
 =?utf-8?B?dFo5Y1NkMkRZcmMyUThtV1NYMFU0a2dkQ0N3M0daY2RWUHMveDNnSzBPdy9o?=
 =?utf-8?B?OEF0dDIrdUhaWVFiUkRDWlUzWFp0MFl3UzJYVUtSS0FGY0laK1ZnRW50Wkpp?=
 =?utf-8?B?cEZLVjNnS0x1QXB4bE5SMy9EV3RDMFA5bGdFMy9wYnNwZ0QyQlcrcEZlbTlN?=
 =?utf-8?B?R1VCZjQwYnJnVlo2SVNPR1h4RjYva3duNTBaYkVHK2thV0h6Vk9QSmo4bDRN?=
 =?utf-8?B?cmQrc3B6dWR0K0xqN01GUEFuelRlYnNMaEZpb3ltN1FrTGplRXFkYklmUWRS?=
 =?utf-8?B?cGtGVzR6d0VhYlhMaDh3RmJRNkkwM0IzVGpnWVlKbUdaL1g5NjRRaG9aZmFq?=
 =?utf-8?B?eVVKQ0RUR1RHdUpqbHpZczRSZ0VHU0RGMFRrT2FHOWxRVlVUOVZFeFEzZklG?=
 =?utf-8?Q?gxh75MaQ6f/Fjtmd2bKhlT990?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b22a6afb-8195-40c3-9592-08dbdf3156dd
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6392.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2023 01:32:00.8838
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UMzn3nCjxxgs/RXihyQLy1bIHeaBnOyoWYf2mrkPUn/5XSuWn/aRqagIxjvkd6nhn1kJvnLk9hRR013QmBYUFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7764
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 06 Nov 2023 17:32:19 -0800 (PST)

On Mon, Nov 06, 2023 at 10:48:57AM +0100, Greg Kroah-Hartman wrote:
> On Mon, Nov 06, 2023 at 05:31:26PM +0800, Yujie Liu wrote:
> > Hi Greg,
> > 
> > On Mon, Nov 06, 2023 at 10:00:14AM +0100, Greg Kroah-Hartman wrote:
> > > On Mon, Nov 06, 2023 at 04:49:17PM +0800, kernel test robot wrote:
> > > > Hi Greg,
> > > > 
> > > > kernel test robot noticed the following build warnings:
> > > > 
> > > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > > head:   1c41041124bd14dd6610da256a3da4e5b74ce6b1
> > > > commit: 8ffdff6a8cfbdc174a3a390b6f825a277b5bb895 staging: comedi: move out of staging directory
> > > > date:   2 years, 7 months ago
> > > 
> > > Have you tested a newer kernel?  Testing a 2 1/2 year old commit feels
> > > odd to me, was this intentional?
> > 
> > We did test new kernels with W=1, and the issue was captured by the
> > bot, then bisected to this 2 years 7 months ago commit that was likely
> > to introduce this issue initially.
> 
> This commit is a "move files around" commit, so it obviously was not the
> original problem commit here :)
> 
> > We have no intention of directly
> > testing a very old commit, and we're sorry that the date info may
> > cause some misunderstanding.
> > 
> > This can be reproduced by allyesconfig build on v6.6 with W=1:
> > 
> > $ git checkout v6.6
> > HEAD is now at ffc253263a13 Linux 6.6
> > 
> > $ make ARCH=x86_64 allyesconfig
> > 
> > $ make W=1 ARCH=x86_64 drivers/comedi/drivers/tests/ni_routes_test.o
> > ...
> >   CC      drivers/comedi/drivers/tests/ni_routes_test.o
> > In file included from drivers/comedi/drivers/tests/ni_routes_test.c:22:
> > drivers/comedi/drivers/tests/../ni_stc.h:1140:35: error: ‘range_ni_E_ao_ext’ defined but not used [-Werror=unused-const-variable=]
> >  1140 | static const struct comedi_lrange range_ni_E_ao_ext;
> >       |                                   ^~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
> 
> This is odd in that a static constant is being defined in a .h file, so
> anything that happens to include it, like this test, will then need to
> use it in order to silence this warning.  I don't think that's going to
> happen any time soon, so it's good that we don't really care aobut W=1
> just yet :)

Thanks a lot for the information. We will learn from this case and be
more careful when handling similar reports on "old commits", thus to
reduce false positives.

Best Regards,
Yujie