Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   Minjie Du <duminjie@vivo.com>
To:     Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        David Ahern <dsahern@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        netdev@vger.kernel.org (open list:NETWORKING [TCP]),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v1] net/tcp: use kfree_sensitive() instend of kfree() in tcp_md5_twsk_free_rcu()
Date:   Tue,  7 Nov 2023 10:34:43 +0800
Message-Id: <20231107023444.3141-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DiY5b+TfqHktvl0PcobMFT/7q6/Xg4OXHduxjREeoHY0dzwoX6CISDXw/pUw?=
 =?us-ascii?Q?cC1fGdRJxg5ZRbgo55S2S+gTuVNSf8pSxgmIDRHOqw1QR0rON/bo5CsiwjjE?=
 =?us-ascii?Q?8FavLkn+SUPbKAdDGJrlBcke/zfd91ZtEh6Ce429xPA5ySEnAZAmaCDxNI2T?=
 =?us-ascii?Q?XtIikmuzpT18v58soo/QfBhAj3/WvE31GOvAphazk8AHnB9uh8wPkCje4FiU?=
 =?us-ascii?Q?wP+7MpbqJk1X1vsKTiNxDpTCWDfRg0tjg1hC+7xLoTf67MFeHxD+ZM1A0h11?=
 =?us-ascii?Q?VpoXCA9Wo2MaI99rsBnG+wLQocXHghdwyJ3X1jU+eWVjlsUdv6sDvGcHcCDO?=
 =?us-ascii?Q?SrFEQcn67mtqEn71KLI09c3k5dLulLglxZ7mJK59p5IZwfw2tciBXUHWmvHw?=
 =?us-ascii?Q?KIr2WkPbKHHzD6X9bYdJDaY5B5RdwW16Pon1kb0gP/DaC2qKbxMW0QxveGEL?=
 =?us-ascii?Q?aGJADOYDSz39/yq2Je5skwPkulBg6TGKBec0X1S+L7JHdt7YHxdlOZYUrWdO?=
 =?us-ascii?Q?yrt23AHsfWWkLqjWP0RI+sZpvB2/Bp1c36dcvizsCCLJc7TZINvU4KuVjegY?=
 =?us-ascii?Q?38/OnVr/BGum/jc75eTxU6PZqF2SjtXcUvh9hh2gbBLHKL9DKKFJK4WgkOIA?=
 =?us-ascii?Q?RxGarL4n0jbEK2//FTXny6GVP4O+FHM4L9zQVS3/i3jSsnGoT54UQpmpgOts?=
 =?us-ascii?Q?U95l4qacgt1cDBpfAt+ILw+KaE85bF4foyxJmVTiqB8J912n4t/wpHnmMVgb?=
 =?us-ascii?Q?ytCT3VxAnq+X8EfXQTw5n5abu3Bm/sKvT7nObeze37s7jq3V7GFmSaxCMln8?=
 =?us-ascii?Q?eQzihjno0DynofEg1C6IHfMnjbNkfCf7DhpEgM0BaAv9LxFZVBKGv46wDPf6?=
 =?us-ascii?Q?SxlxZZ4AeQaX21XaZ3rfqnohkXvojJku3vauAl5j5mbg0uiwx+ffWFTBD4vg?=
 =?us-ascii?Q?FtzxAQeSAhQ9DpsT1fG0EH2/IDJbloz1GbGO+qdrWPq9c/30C0RFF9USMBGn?=
 =?us-ascii?Q?JXGR3pT3lyE8aJpHdhLN47nLZ5cGFAVCVWmS/e3HEwJPh4OHWfSsOj6TjlcQ?=
 =?us-ascii?Q?QUCuBAi6X2874V3syRteDdnqVJr53D+Xy8oces1mf9bopfNiE5TICu1xaHn6?=
 =?us-ascii?Q?GUQnJe09RjE+oP6pQj8bLxhiEa6zItLkQxX7Q3AEjAuhSXuq9qxcExJf7Lov?=
 =?us-ascii?Q?ZxlrkrZzRJRUUeBYCVwvWIiziSOEOnBzuXKvjLODqWf62U0T+zLBNEWAviDZ?=
 =?us-ascii?Q?EiqhPZ3I0WBOyjgf6auwdyLIbc0IQN/f8DPWQ6YrgBiIpR582uXD4HeHbR6K?=
 =?us-ascii?Q?ZJuteMere5BjAAlKZof1pSdLDafHUiZh9HTk4gYThdrOeI1RVZpr6u0Pw+Nr?=
 =?us-ascii?Q?0wUfxDlYIjQDTprNK3Uv88S2ERFV1uu2rGLC+ELlPlaDtiZhc7Z4beB56pnB?=
 =?us-ascii?Q?iPUEShG4WpMo2eum1vwhG35NMgbeH/lZeoj1B3WT+0dpccgg0Wn2kpwUvXW3?=
 =?us-ascii?Q?DNlC4Ya7kV9Fkntua/dGrRxNAknM/CEZtsJwgS0JnLD/a2YRzwmHaJMlkxsH?=
 =?us-ascii?Q?GcLeSRuzbd9K/mFsxlKDkjJIo/gfbsi3DerRUAqs?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46e05e36-371a-4515-5ae3-08dbdf3a3040
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2023 02:35:21.5624
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GNgD+JpeMvASOF4HSNOOtDTcRTs9fRxIyU3Bpp7FUBLoo/by7z4pPvIAK7GDI4RzUyd2qrxLbVCxJT3eKaGcJA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB5421
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 06 Nov 2023 18:35:43 -0800 (PST)

key might contain private information, so better use
kfree_sensitive to free it.
In tcp_md5_twsk_free_rcu() use kfree_sensitive().

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 net/ipv4/tcp_minisocks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c
index a9807eeb311c..a7be78096783 100644
--- a/net/ipv4/tcp_minisocks.c
+++ b/net/ipv4/tcp_minisocks.c
@@ -368,7 +368,7 @@ static void tcp_md5_twsk_free_rcu(struct rcu_head *head)
 	struct tcp_md5sig_key *key;
 
 	key = container_of(head, struct tcp_md5sig_key, rcu);
-	kfree(key);
+	kfree_sensitive(key);
 	static_branch_slow_dec_deferred(&tcp_md5_needed);
 	tcp_md5_release_sigpool();
 }
-- 
2.39.0