Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Tue, 7 Nov 2023 11:55:48 +0800
From:   Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
To:     Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v2] tty: serial: Add RS422 flag to struct serial_rs485
Message-ID: <ZUm1RD2icq+Vh6Cp@moxa-ThinkCentre-M90t>
References: <20231101064404.45711-1-crescentcy.hsieh@moxa.com>
 <0d203024-ba5c-4258-b549-b9304622978b@gmx.de>
 <ZUiTkyZSbbmTUGYQ@moxa-ThinkCentre-M90t>
 <3fc18b13-fef0-439e-abf0-1fe4e46b224a@gmx.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3fc18b13-fef0-439e-abf0-1fe4e46b224a@gmx.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xDzMchdir3S7zaDZFyOcL/oLBFmEO/lIOksQUoKPgcLW5GC5iS5Edmx+qLX0?=
 =?us-ascii?Q?n3U19IrHp5IouprQAbg3+GaiZWjrqFxgFJib+ybYx/U281Neuvmby6Euk8vv?=
 =?us-ascii?Q?QE/+ZG0AY4Jazr4gw55FB3mEfsaDy1SUshLYF/fnr/CR6vm1csO403wGUn8C?=
 =?us-ascii?Q?qcYriuw/iyJKgq9w0fvcNx9R1+25Dj/Sr8ZjizL3yzpLFBdLFWpNbjHkjwSh?=
 =?us-ascii?Q?qpDh05J0UvEWHf//nYHVumOyhjk8jcmRZfUMSXmP5zPy+SBWImGRWn84aJGJ?=
 =?us-ascii?Q?KHtWuLT4qaGVB2kxmCZiRILDAD/LZnRR+0G4/ol1saZUpVybpnWqrOzFaZD5?=
 =?us-ascii?Q?FAtfezaqJlXQQRt1xL+a5TB1VcWlFyYo28mYuiZTLk/DPz5z6ZPIDfg6v5rN?=
 =?us-ascii?Q?Z2EY/2+sIv5qW4/KfpZzYj0RYV/IblB8EyzeNB7maJ9MO2UaoeYM+26tyHco?=
 =?us-ascii?Q?2A/NUhjd7KAvi7+n9/dp9UrlzE8s2uhzORUQW0HdUdd0lwMiV3gDPd+GJFSJ?=
 =?us-ascii?Q?XGdWL7nq/z6bm42w7PuWRM1HPHGPjIl0uXQdCsT1YzVjCHCX3yTUG71Vm4R2?=
 =?us-ascii?Q?n+tDmTI67pDjvXbM8HqXD4Od4P/Q/WKuSJD/cB3H3M+laMYLjZTzdR8IH91K?=
 =?us-ascii?Q?zqeYPTQ3J1ZHsPms280yuRVUvqLwaFU/DeNL3kD08SmM5sfYgylpaUFbrp1h?=
 =?us-ascii?Q?QAY4bkbuJhfNdoukbBoERqrkp1EzYp0/pOLoxao+9ZjBfuOLF+Cb9GOPlxOP?=
 =?us-ascii?Q?g/FksmYRIa67hpgdePMdPUhTGhR+oMrXJFl5aAszOs/7+IATTxLyNsJwK/iB?=
 =?us-ascii?Q?TWcUkPoLAr+EjcYtzcd77uIvTOiOAZFTlrUuia2rwTa4dmt4cJ6vK8SVmEXp?=
 =?us-ascii?Q?iv6mKBRxI2ee3ftFMC3YYjybnOoHUJQ5ddNIsqRzsJZcacpZiaTN8ip7xJV8?=
 =?us-ascii?Q?LjA2FsAP3N+VTQGaOu0XvrP6WbinHKFqu/1tTV6Xv+7pI2myamcNEHrBqawF?=
 =?us-ascii?Q?Jw6y1W9k5iar9NmoeI0Ft9MErYXDAvUAN0Sxaf4ql1l6/h8vrMyP4l3tR4v4?=
 =?us-ascii?Q?oFBv030J38Mm6Kf/m7qvM38+xN/oZOLKXduC5F8ZwZTn1QTJdspVsoIRzHcB?=
 =?us-ascii?Q?iqtXSU5EBH0MejXjp0kqAvw13Xn2WfFL0QiU6JlN/xf7a8wq72FhNxmGsNwU?=
 =?us-ascii?Q?en1NVCIYWTNrmFpjZWTdTqqdy1ydj++XF6phM1GA3Ty8YqqMZVi/ZaOixyoL?=
 =?us-ascii?Q?c4EgaU1QRJmr5G+ifMnrTrnktqpJUSnFXzuQk7xPd6AVf5ZR9MbJN6cCSxhf?=
 =?us-ascii?Q?Cc6lZZJfnNKKIk9LHvcxK8NJlhDvktGiklbSIC/dMpPTaccf8CErzkfuVjxe?=
 =?us-ascii?Q?XRYX4eVj8z2kIr1r+n/VMLR+nIenDnnyunUNZe7mvL1aE86gJx5iTg4kqPGy?=
 =?us-ascii?Q?TLuT2wWhflG+AtrBdLPY3P2XMmp+PasmVU0GhlQQZ5DNB1EaoX65uRWuxKpA?=
 =?us-ascii?Q?obHyYvCcVqCp96u9Pzc1ST3oShC1VM1BESXAMRDVqJQs2fCMrRF3Ta59xxWF?=
 =?us-ascii?Q?VxgM+FCY0K03zGDFktQyYubmf8cvH81JI0HH/p5qTaDgfGACXkeVHsTNzrGN?=
 =?us-ascii?Q?Qw=3D=3D?=
X-OriginatorOrg: moxa.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a31937c-3840-4003-a568-08dbdf4570dc
X-MS-Exchange-CrossTenant-AuthSource: PUZPR01MB5405.apcprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2023 03:55:54.3625
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5571c7d4-286b-47f6-9dd5-0aa688773c8e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uOJBG8msjFZD8PTScWW9anGzxc/F9jKDlTYCNqlyRBOhd5A0Ciz1/U/aK3tB1zj2HTaFVNTo4o5paQNwtBcKAhJos0yXxMn/yqQmeIx0H2E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR01MB4391
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 06 Nov 2023 19:56:07 -0800 (PST)

On Mon, Nov 06, 2023 at 03:43:49PM +0100, Lino Sanfilippo wrote:
> On 06.11.23 08:19, Crescent CY Hsieh wrote:
> > On Sat, Nov 04, 2023 at 08:53:18PM +0100, Lino Sanfilippo wrote:
> > > 
> > > Maybe it would be better to change the meaning of the flag: Instead of being a substitution for
> > > SER_RS485_ENABLED, it could be used to mark a special mode.
> > > So if both SER_RS485_ENABLED and SER_RS485_MODE_RS422 are set it would mean that we have RS422.
> > 
> > RS422 is not a mode of RS485, so I think using two flags to represent
> > them is much more reasonable, even though they are both included in the
> > "struct serial_rs485".
> 
> Yes, RS422 is not a mode of RS485, but you are already using the rs485 (and not a rs422) structure.
> And treating RS422 as a different mode in the existing code would make things much easier and keep the code
> clean. For example you would not have to alter all the code places that check for SER_RS485_ENABLED.
> Also SER_RS485_ENABLED and SER_RS422_ENABLED would have the exact same effect, so why use two
> different flags, when the effect is the same?

Agree, by treating RS422 as a mode, it would make things easier.

However, I think, eventually, RS422 might add some configuration flags
and should be distinguished from RS485 (Perhaps by adding RS422
structure or revising the name of RS485 structure...) But this should be
a future work and require more discussion.

Anyway, I will see RS422 as a mode in the next patch. Thanks for the
suggestion.

---
Sincerely,
Crescent CY Hsieh