Received: by 2002:a05:7412:4e10:b0:e2:908c:2ebd with SMTP id gb16csp20701rdb; Mon, 6 Nov 2023 22:13:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IGM68AsTfzpRkbqPZxjLBCw+ifZf5x36ZhbqbtxMK6zkYaABqZWPQcFXe1wtFRrLWHXjOOz X-Received: by 2002:a05:6358:5e08:b0:168:e438:15e5 with SMTP id q8-20020a0563585e0800b00168e43815e5mr29439332rwn.29.1699337599836; Mon, 06 Nov 2023 22:13:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699337599; cv=none; d=google.com; s=arc-20160816; b=cLKf9r1qn/ZBFpGdcT6vKqOSoptG2/ptADPDtUYk82Emabxh1iTNDvfIJGwOB865BZ TgO26iUV0fJQCguGbB1khcWmZsPZVsO6p0htv5iG3x08fWdcajwHxLtCuEVEJZf/fgAh 4yaPKL0lAfzoY9xVL31ozeCLHteNVvYR2UETPCTRZApwyrXUTrv0CvOE3Ib1cdbeL2z7 oFeUet2O9tV6hXrHKJkP4Nmg6g3qCWcCa9id8fK1zs+i6rKQrx7TfNBK7EElaLT7UtOt uJ9P9K8gs3qgBqlema1P80XPV0Bj1KH7pl8nAL/WS0sGu4HSXHHjvNdjhsFDwTpPp+em sezw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=eYDdK5bxPox1XDZTxjW6zzD5nW+jVYa/FuFqSU8icUM=; fh=ZSFcBMfG+2/IXx+yRuY5IbwIW+S1hCvcWSVzj3A/XYI=; b=J0vd5wg9dCXhOXtPPz5dDotQYNDyjgaDHkk/l39p6/8dTZrpcyO5HpL9TG/vTEfoyo xrNl7GsXBHVhu+DsMwC2G1MNejTEgKhm6BcGKGqW6qZNqdaquvQKjolvvhYTMj7eQhV5 6H3Im1B26d1C6rZrSEX9mu/aqWOJ9LcumIGfvoWDIcTg6EjJjTsl2el9KOed9I0Dq+bs jplB4u8sXiwhgG4tRn17XMdvl8kltQrb6XbBgkhEYod1yjJna2lvkHBCep1PRO+CdyzN HY05vJ52S5amTzPgEjI2yoJvbffDEa6tgIQ0eAJtfkzzgU7mHsLWxMHePuu7VUQbA6Cm C5FQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="EX/9QLC4"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id q8-20020a632a08000000b00578b6e2f462si1303158pgq.351.2023.11.06.22.13.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 22:13:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="EX/9QLC4"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 73FC7802B3E9; Mon, 6 Nov 2023 22:13:17 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231303AbjKGGNI (ORCPT + 99 others); Tue, 7 Nov 2023 01:13:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229559AbjKGGNI (ORCPT ); Tue, 7 Nov 2023 01:13:08 -0500 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FD6410F; Mon, 6 Nov 2023 22:13:05 -0800 (PST) Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-6bd20c30831so974946b3a.1; Mon, 06 Nov 2023 22:13:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699337585; x=1699942385; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eYDdK5bxPox1XDZTxjW6zzD5nW+jVYa/FuFqSU8icUM=; b=EX/9QLC4rkeRsgc+c2OqF6gYkQH43wBqJWbx46oKQtTaRsdiNY99+0/In00/AtLbI8 CoGcFeEc65+ZGD4YL42CFa4G0VH0ZJ3/u/43yePBGhn9/TbCGO3fbcqnpAXxsKp8a2/2 h1Gs7iqDxg/OZAs6Q2OTGjKeu2gslBsa6IL437LX/aA8asuCqmyuILCqUVQ+B/5XQY6L OGPRABhHgc8rTh4/FFfTgDGLbrisSRM8MhZ/LW0ZIbnnVDL9E4o8NsU/cq8hYVLCZ3au uCECtUXznuhEp7VyTphJR0cuBZ5zAED8KT7lOHPEHfDMUF1ZYGdMu4FI8I9kKDqCsqRP oyIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699337585; x=1699942385; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eYDdK5bxPox1XDZTxjW6zzD5nW+jVYa/FuFqSU8icUM=; b=VMoWNMPnjKvE0BkB1z11pqBUf/jBPhk28ZPoJfjUO8Y19fudCOj7fZif2+8fsbTDDu jdAIWgCzdH5IIztAIefAir7hp12+yGT28E+8Pw5JVCgxRuHylebsAUIT+Y8GnB9ZQZIl jGgAjq/EZIFZndJ4oBFBHmjcV6zdaJVbSSrSf3zDUHHEH2UZ5N1zOcLJWwvScp8DajGo 4EJT+WfOocUeuSoCPIvM8odmmtZllctr4SSx97aAQ1mpt9lm7arEC4wEIhuK0mqaTDAu PhX1W60WG2h5sM0TURQukqjXUPsYgo8F5hJahllp8Gj/KtoHBw3BaabIL/8wl8JePXm+ ozoQ== X-Gm-Message-State: AOJu0YzmfpSgbjAZtOo2EQ0wqFFKRmoNt4LN9gr/ttwmQ/CuPrStM8xw cD0YBhS8KUukopiJsu0J1c0= X-Received: by 2002:a05:6a00:309b:b0:6b9:7d5c:bb58 with SMTP id bh27-20020a056a00309b00b006b97d5cbb58mr29937251pfb.0.1699337584912; Mon, 06 Nov 2023 22:13:04 -0800 (PST) Received: from hoboy.vegasvil.org ([2601:640:8000:54:e2d5:5eff:fea5:802f]) by smtp.gmail.com with ESMTPSA id bd32-20020a056a0027a000b006870ed427b2sm6626300pfb.94.2023.11.06.22.13.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 22:13:04 -0800 (PST) Date: Mon, 6 Nov 2023 22:13:02 -0800 From: Richard Cochran To: Edward Adam Davis Cc: davem@davemloft.net, habetsm.xilinx@gmail.com, jeremy@jcline.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, reibax@gmail.com, syzbot+df3f3ef31f60781fa911@syzkaller.appspotmail.com Subject: Re: [PATCH net-next V8 1/2] ptp: ptp_read should not release queue Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 06 Nov 2023 22:13:17 -0800 (PST) On Mon, Nov 06, 2023 at 10:31:27PM +0800, Edward Adam Davis wrote: > Firstly, queue is not the memory allocated in ptp_read; > Secondly, other processes may block at ptp_read and wait for conditions to be > met to perform read operations. > > Reported-and-tested-by: syzbot+df3f3ef31f60781fa911@syzkaller.appspotmail.com > Fixes: 8f5de6fb2453 ("ptp: support multiple timestamp event readers") > Signed-off-by: Edward Adam Davis (This should go to net and not net-next.) Acked-by: Richard Cochran